* [PATCH v2] i2c: jz4780: Fix build for m68k and sparc64
@ 2015-04-15 15:48 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2015-04-15 15:48 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, linux-kernel, Guenter Roeck, Zubair Lutfullah Kakakhel
Fix:
drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw':
drivers/i2c/busses/i2c-jz4780.c:181:2: error:
implicit declaration of function 'readw'
drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew':
drivers/i2c/busses/i2c-jz4780.c:187:2: error:
implicit declaration of function 'writew'
seen with sparc64:allmodconfig and m68k:allmodconfig.
The driver has to include linux/io.h.
Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver
for Ingenic JZ4780")
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: HAS_IOMEM dependency already existed
Fixed include file order
drivers/i2c/busses/i2c-jz4780.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
index ce1d69324169..19b2d689a5ef 100644
--- a/drivers/i2c/busses/i2c-jz4780.c
+++ b/drivers/i2c/busses/i2c-jz4780.c
@@ -23,6 +23,7 @@
#include <linux/i2c.h>
#include <linux/init.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] i2c: jz4780: Fix build for m68k and sparc64
@ 2015-04-15 15:48 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2015-04-15 15:48 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Guenter Roeck,
Zubair Lutfullah Kakakhel
Fix:
drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw':
drivers/i2c/busses/i2c-jz4780.c:181:2: error:
implicit declaration of function 'readw'
drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew':
drivers/i2c/busses/i2c-jz4780.c:187:2: error:
implicit declaration of function 'writew'
seen with sparc64:allmodconfig and m68k:allmodconfig.
The driver has to include linux/io.h.
Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver
for Ingenic JZ4780")
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
---
v2: HAS_IOMEM dependency already existed
Fixed include file order
drivers/i2c/busses/i2c-jz4780.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
index ce1d69324169..19b2d689a5ef 100644
--- a/drivers/i2c/busses/i2c-jz4780.c
+++ b/drivers/i2c/busses/i2c-jz4780.c
@@ -23,6 +23,7 @@
#include <linux/i2c.h>
#include <linux/init.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: jz4780: Fix build for m68k and sparc64
@ 2015-04-15 15:57 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2015-04-15 15:57 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-i2c, linux-kernel, Zubair Lutfullah Kakakhel
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Wed, Apr 15, 2015 at 08:48:47AM -0700, Guenter Roeck wrote:
> Fix:
>
> drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw':
> drivers/i2c/busses/i2c-jz4780.c:181:2: error:
> implicit declaration of function 'readw'
> drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew':
> drivers/i2c/busses/i2c-jz4780.c:187:2: error:
> implicit declaration of function 'writew'
>
> seen with sparc64:allmodconfig and m68k:allmodconfig.
>
> The driver has to include linux/io.h.
>
> Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver
> for Ingenic JZ4780")
> Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: jz4780: Fix build for m68k and sparc64
@ 2015-04-15 15:57 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2015-04-15 15:57 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Zubair Lutfullah Kakakhel
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wed, Apr 15, 2015 at 08:48:47AM -0700, Guenter Roeck wrote:
> Fix:
>
> drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw':
> drivers/i2c/busses/i2c-jz4780.c:181:2: error:
> implicit declaration of function 'readw'
> drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew':
> drivers/i2c/busses/i2c-jz4780.c:187:2: error:
> implicit declaration of function 'writew'
>
> seen with sparc64:allmodconfig and m68k:allmodconfig.
>
> The driver has to include linux/io.h.
>
> Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver
> for Ingenic JZ4780")
> Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-15 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 15:48 [PATCH v2] i2c: jz4780: Fix build for m68k and sparc64 Guenter Roeck
2015-04-15 15:48 ` Guenter Roeck
2015-04-15 15:57 ` Wolfram Sang
2015-04-15 15:57 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.