[PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data

[PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data

[Jin Yao]

kbuild robot reports following warning:
"sound/soc/intel/haswell/sst-haswell-ipc.c:2204:1-6:
 WARNING: invalid free of devm_ allocated data"

As julia explains to me, the memory allocated with devm_kalloc
is freed automatically on failure of a probe function. So this
kfree should be removed otherwise the double free will be got in
error handler path.

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
---
 sound/soc/intel/haswell/sst-haswell-ipc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
index 344a1e9..324eceb 100644
--- a/sound/soc/intel/haswell/sst-haswell-ipc.c
+++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
@@ -2201,7 +2201,6 @@ dma_err:
 dsp_new_err:
 	sst_ipc_fini(ipc);
 ipc_init_err:
-	kfree(hsw);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(sst_hsw_dsp_init);
-- 
1.9.1

Re: [PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 221 bytes --]

On Mon, Apr 13, 2015 at 02:20:54PM +0800, Jin Yao wrote:
> kbuild robot reports following warning:
> "sound/soc/intel/haswell/sst-haswell-ipc.c:2204:1-6:
>  WARNING: invalid free of devm_ allocated data"

Appied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]