* [Buildroot] [PATCH 0/1] Added linux drivers backports project @ 2015-04-15 21:55 Petr Vorel 2015-04-15 21:55 ` [Buildroot] [PATCH 1/1] " Petr Vorel 0 siblings, 1 reply; 13+ messages in thread From: Petr Vorel @ 2015-04-15 21:55 UTC (permalink / raw) To: buildroot Hi there, this is a patch adding [1] to buildroot. Backports provide drivers released on newer kernels backported for usage on older kernels. This is very handy, for those which have to use and old kernel (some SoC requires this). This project was discussed more than one year ago [2], but nothing was actually implemented. I plan further improvements: * Allow to use different versions There are stable releases, snapshot based on current linux-next and some archived versions based on linux-next. Although it's recommended to use the latest stable version, some people prefer / need different version. * Version check For kernel versions older than 3.0 version backports-3.14 is needed, kernels < 2.6.26 aren't supported. * Custom patches Ekvivalent of BR2_LINUX_KERNEL_PATCH. * Custom repository version Ekvivalent of BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION. Credits: I got inspired by implementation in gfiber project (but rewrited). Kind regards, Petr [1] https://backports.wiki.kernel.org [2] http://lists.busybox.net/pipermail/buildroot/2013-December/084663.html [3] https://gfiber.googlesource.com/buildroot/+/gfiber-openbox-2/package/backports/backports.mk Petr Vorel (1): Added linux drivers backports project package/Config.in | 1 + package/linux-backports/Config.in | 36 ++++++++++++++ package/linux-backports/linux-backports.hash | 2 + package/linux-backports/linux-backports.mk | 73 ++++++++++++++++++++++++++++ 4 files changed, 112 insertions(+) create mode 100644 package/linux-backports/Config.in create mode 100644 package/linux-backports/linux-backports.hash create mode 100644 package/linux-backports/linux-backports.mk -- 1.8.0 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-15 21:55 [Buildroot] [PATCH 0/1] Added linux drivers backports project Petr Vorel @ 2015-04-15 21:55 ` Petr Vorel 2015-04-16 20:29 ` Arnout Vandecappelle 0 siblings, 1 reply; 13+ messages in thread From: Petr Vorel @ 2015-04-15 21:55 UTC (permalink / raw) To: buildroot https://backports.wiki.kernel.org Signed-off-by: Petr Vorel <petr.vorel@gmail.com> --- package/Config.in | 1 + package/linux-backports/Config.in | 36 ++++++++++++++ package/linux-backports/linux-backports.hash | 2 + package/linux-backports/linux-backports.mk | 73 ++++++++++++++++++++++++++++ 4 files changed, 112 insertions(+) create mode 100644 package/linux-backports/Config.in create mode 100644 package/linux-backports/linux-backports.hash create mode 100644 package/linux-backports/linux-backports.mk diff --git a/package/Config.in b/package/Config.in index 34b6017..c8e24a7 100644 --- a/package/Config.in +++ b/package/Config.in @@ -365,6 +365,7 @@ endif source "package/iucode-tool/Config.in" source "package/kbd/Config.in" source "package/lcdproc/Config.in" + source "package/linux-backports/Config.in" source "package/lirc-tools/Config.in" source "package/lm-sensors/Config.in" source "package/lshw/Config.in" diff --git a/package/linux-backports/Config.in b/package/linux-backports/Config.in new file mode 100644 index 0000000..c108b59 --- /dev/null +++ b/package/linux-backports/Config.in @@ -0,0 +1,36 @@ +config BR2_PACKAGE_LINUX_BACKPORTS + bool "Linux kernel driver backports" + help + The backports package includes many Linux drivers from recent + kernels, backported to older ones. + + https://backports.wiki.kernel.org + +if BR2_PACKAGE_LINUX_BACKPORTS + +choice + prompt "Linux kernel driver backports configuration" + default BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + bool "Using a defconfig" + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + bool "Using a custom config file" + +endchoice + +config BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG + string "Defconfig name" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + help + Name of the backports defconfig file to use. The defconfig is located + in defconfigs/ directory in the backports tree. + +config BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE + string "Configuration file path" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + help + Path to the kernel configuration file + +endif diff --git a/package/linux-backports/linux-backports.hash b/package/linux-backports/linux-backports.hash new file mode 100644 index 0000000..6b8cb4f --- /dev/null +++ b/package/linux-backports/linux-backports.hash @@ -0,0 +1,2 @@ +# From: https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.19-rc1/sha256sums.asc +sha256 d782422d664b84128154fc5d0e9b8cd04bb208e53546d68856ad3f7f53f7de98 backports-3.19-rc1-1.tar.xz diff --git a/package/linux-backports/linux-backports.mk b/package/linux-backports/linux-backports.mk new file mode 100644 index 0000000..f49cd7d --- /dev/null +++ b/package/linux-backports/linux-backports.mk @@ -0,0 +1,73 @@ +LINUX_BACKPORTS_VERSION = 3.19-rc1 +LINUX_BACKPORTS_REVISION = 1 +LINUX_BACKPORTS_SOURCE = backports-$(LINUX_BACKPORTS_VERSION)-$(LINUX_BACKPORTS_REVISION).tar.xz +LINUX_BACKPORTS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/projects/backports/stable/v$(LINUX_BACKPORTS_VERSION) +LINUX_BACKPORTS_DEPENDENCIES = linux + +LINUX_BACKPORTS_MAKE_FLAGS = \ + $(TARGET_MAKE_ENV) \ + $(LINUX_MAKE_FLAGS) \ + KLIB_BUILD=$(LINUX_DIR) \ + KLIB=$(TARGET_DIR) + + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) +LINUX_BACKPORTS_SOURCE_CONFIG = $(@D)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)) +else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +LINUX_BACKPORTS_SOURCE_CONFIG = $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) +endif + +define LINUX_BACKPORTS_CONFIGURE_CMDS + $(INSTALL) -m 0644 $(LINUX_BACKPORTS_SOURCE_CONFIG) $(@D)/.config + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(@D) olddefconfig +endef + +define LINUX_BACKPORTS_BUILD_CMDS + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(@D) +endef + +define LINUX_BACKPORTS_INSTALL_TARGET_CMDS + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(LINUX_DIR) M=$(@D) \ + INSTALL_MOD_DIR=backports \ + modules_install +endef + +$(eval $(generic-package)) + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS),y) +linux-backports-menuconfig linux-backports-xconfig linux-backports-gconfig linux-backports-nconfig: linux-backports-configure + $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) -C $(LINUX_BACKPORTS_DIR) \ + $(subst linux-backports-,,$@) + rm -f $(LINUX_BACKPORTS_DIR)/.stamp_{built,target_installed,images_installed} + +linux-backports-savedefconfig: linux-backports-configure + $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) -C $(LINUX_BACKPORTS_DIR) \ + $(subst linux-backports-,,$@) + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +linux-backports-update-config: linux-backports-configure $(LINUX_BACKPORTS_DIR)/.config + cp -f $(LINUX_BACKPORTS_DIR)/.config $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) + +linux-backports-update-defconfig: linux-backports-savedefconfig + cp -f $(LINUX_BACKPORTS_DIR)/defconfig $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) +else +linux-backports-update-config: ; +linux-backports-update-defconfig: ; +endif +endif + +# Checks to give errors that the user can understand +ifeq ($(filter source,$(MAKECMDGOALS)),) +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) +endif +endif + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) +endif +endif + +endif -- 1.8.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-15 21:55 ` [Buildroot] [PATCH 1/1] " Petr Vorel @ 2015-04-16 20:29 ` Arnout Vandecappelle 2015-04-17 8:01 ` Thomas Petazzoni 2015-04-17 9:03 ` Petr Vorel 0 siblings, 2 replies; 13+ messages in thread From: Arnout Vandecappelle @ 2015-04-16 20:29 UTC (permalink / raw) To: buildroot On 15/04/15 23:55, Petr Vorel wrote: > https://backports.wiki.kernel.org > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> > --- > package/Config.in | 1 + > package/linux-backports/Config.in | 36 ++++++++++++++ > package/linux-backports/linux-backports.hash | 2 + > package/linux-backports/linux-backports.mk | 73 ++++++++++++++++++++++++++++ > 4 files changed, 112 insertions(+) > create mode 100644 package/linux-backports/Config.in > create mode 100644 package/linux-backports/linux-backports.hash > create mode 100644 package/linux-backports/linux-backports.mk > > diff --git a/package/Config.in b/package/Config.in > index 34b6017..c8e24a7 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -365,6 +365,7 @@ endif > source "package/iucode-tool/Config.in" > source "package/kbd/Config.in" > source "package/lcdproc/Config.in" > + source "package/linux-backports/Config.in" I would say that this package fits better in the linux extensions menu. Even if you just consider this package as a set of kernel modules, I think that from a users perspective it fits better together with the kernel. But also, if you ever want to add the possibility to link the backported drivers in the kernel itself (which I believe is supported by backports), then you really need it to be a kernel extension. The opinion of other developers may differ, though. > source "package/lirc-tools/Config.in" > source "package/lm-sensors/Config.in" > source "package/lshw/Config.in" > diff --git a/package/linux-backports/Config.in b/package/linux-backports/Config.in > new file mode 100644 > index 0000000..c108b59 > --- /dev/null > +++ b/package/linux-backports/Config.in > @@ -0,0 +1,36 @@ > +config BR2_PACKAGE_LINUX_BACKPORTS > + bool "Linux kernel driver backports" This package should depend on BR2_LINUX_KERNEL, with the appropriate comment. However, if it moves to the kernel extension then that's implicit. > + help > + The backports package includes many Linux drivers from recent > + kernels, backported to older ones. > + > + https://backports.wiki.kernel.org > + > +if BR2_PACKAGE_LINUX_BACKPORTS > + > +choice > + prompt "Linux kernel driver backports configuration" > + default BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG > + > +config BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG > + bool "Using a defconfig" > + > +config BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG > + bool "Using a custom config file" > + > +endchoice > + > +config BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG > + string "Defconfig name" > + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG > + help > + Name of the backports defconfig file to use. The defconfig is located > + in defconfigs/ directory in the backports tree. > + > +config BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE > + string "Configuration file path" > + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG > + help > + Path to the kernel configuration file s/kernel/backports/ > + > +endif > diff --git a/package/linux-backports/linux-backports.hash b/package/linux-backports/linux-backports.hash > new file mode 100644 > index 0000000..6b8cb4f > --- /dev/null > +++ b/package/linux-backports/linux-backports.hash > @@ -0,0 +1,2 @@ > +# From: https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.19-rc1/sha256sums.asc > +sha256 d782422d664b84128154fc5d0e9b8cd04bb208e53546d68856ad3f7f53f7de98 backports-3.19-rc1-1.tar.xz > diff --git a/package/linux-backports/linux-backports.mk b/package/linux-backports/linux-backports.mk > new file mode 100644 > index 0000000..f49cd7d > --- /dev/null > +++ b/package/linux-backports/linux-backports.mk > @@ -0,0 +1,73 @@ > +LINUX_BACKPORTS_VERSION = 3.19-rc1 We prefer "stable" versions rather than rc's. > +LINUX_BACKPORTS_REVISION = 1 > +LINUX_BACKPORTS_SOURCE = backports-$(LINUX_BACKPORTS_VERSION)-$(LINUX_BACKPORTS_REVISION).tar.xz > +LINUX_BACKPORTS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/projects/backports/stable/v$(LINUX_BACKPORTS_VERSION) > +LINUX_BACKPORTS_DEPENDENCIES = linux If it's a kernel extension this will be implicit. > + > +LINUX_BACKPORTS_MAKE_FLAGS = \ > + $(TARGET_MAKE_ENV) \ > + $(LINUX_MAKE_FLAGS) \ > + KLIB_BUILD=$(LINUX_DIR) \ > + KLIB=$(TARGET_DIR) > + > + > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) > +LINUX_BACKPORTS_SOURCE_CONFIG = $(@D)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)) > +else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > +LINUX_BACKPORTS_SOURCE_CONFIG = $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) > +endif > + > +define LINUX_BACKPORTS_CONFIGURE_CMDS > + $(INSTALL) -m 0644 $(LINUX_BACKPORTS_SOURCE_CONFIG) $(@D)/.config > + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(@D) olddefconfig LINUX_MAKE_FLAGS are normally passed as arguments to make. So I'd remove TARGET_MAKE_ENV from LINUX_BACKPORTS_MAKE_FLAGS and turn the make commands into $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) \ ... That said, we now have a kconfig package infrastructure and this package should make use of it. Then these commands are no longer needed, but you do have to define LINUX_BACKPORTS_KCONFIG_OPTS = LINUX_BACKPORTS_MAKE_FLAGS > +endef > + > +define LINUX_BACKPORTS_BUILD_CMDS > + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(@D) > +endef > + > +define LINUX_BACKPORTS_INSTALL_TARGET_CMDS > + $(LINUX_BACKPORTS_MAKE_FLAGS) $(MAKE) -C $(LINUX_DIR) M=$(@D) \ > + INSTALL_MOD_DIR=backports \ > + modules_install > +endef > + > +$(eval $(generic-package)) > + Replace with $(kconfig-package), remove all the following and just set LINUX_BACKPORTS_KCONFIG_EDITORS and LINUX_BACKPORTS_KCONFIG_FILE. Regards, Arnout > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS),y) > +linux-backports-menuconfig linux-backports-xconfig linux-backports-gconfig linux-backports-nconfig: linux-backports-configure > + $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) -C $(LINUX_BACKPORTS_DIR) \ > + $(subst linux-backports-,,$@) > + rm -f $(LINUX_BACKPORTS_DIR)/.stamp_{built,target_installed,images_installed} > + > +linux-backports-savedefconfig: linux-backports-configure > + $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) -C $(LINUX_BACKPORTS_DIR) \ > + $(subst linux-backports-,,$@) > + > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > +linux-backports-update-config: linux-backports-configure $(LINUX_BACKPORTS_DIR)/.config > + cp -f $(LINUX_BACKPORTS_DIR)/.config $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) > + > +linux-backports-update-defconfig: linux-backports-savedefconfig > + cp -f $(LINUX_BACKPORTS_DIR)/defconfig $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) > +else > +linux-backports-update-config: ; > +linux-backports-update-defconfig: ; > +endif > +endif > + > +# Checks to give errors that the user can understand > +ifeq ($(filter source,$(MAKECMDGOALS)),) > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) > +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) > +endif > +endif > + > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) > +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) > +endif > +endif > + > +endif > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-16 20:29 ` Arnout Vandecappelle @ 2015-04-17 8:01 ` Thomas Petazzoni 2015-04-17 9:03 ` Petr Vorel 1 sibling, 0 replies; 13+ messages in thread From: Thomas Petazzoni @ 2015-04-17 8:01 UTC (permalink / raw) To: buildroot Dear Arnout Vandecappelle, On Thu, 16 Apr 2015 22:29:47 +0200, Arnout Vandecappelle wrote: > I would say that this package fits better in the linux extensions menu. Even if > you just consider this package as a set of kernel modules, I think that from a > users perspective it fits better together with the kernel. But also, if you ever > want to add the possibility to link the backported drivers in the kernel itself > (which I believe is supported by backports), then you really need it to be a > kernel extension. > > The opinion of other developers may differ, though. While I do understand the reasoning, I'm not so sure about the conclusion. The linux extension stuff is really for things that needed to be tightly integrated with the kernel build process, because it requires patching the kernel (xenomai, rtai, etc.). Here, it is much more like lttng-modules, or linux-fusion, cryptodev-linux, ktap, sysdig and so on: a bunch of external modules that can be built with no problem as separate packages from the kernel. So I would actually tend to prefer keeping linux-backports as a package in package/, like the author did. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-16 20:29 ` Arnout Vandecappelle 2015-04-17 8:01 ` Thomas Petazzoni @ 2015-04-17 9:03 ` Petr Vorel 2015-04-17 9:14 ` Arnout Vandecappelle 1 sibling, 1 reply; 13+ messages in thread From: Petr Vorel @ 2015-04-17 9:03 UTC (permalink / raw) To: buildroot Thanks for comments, I'll create new version tonight. > I would say that this package fits better in the linux extensions menu. Even if > you just consider this package as a set of kernel modules, I think that from a > users perspective it fits better together with the kernel. Sounds reasonable, I'll do it. > But also, if you ever > want to add the possibility to link the backported drivers in the kernel itself > (which I believe is supported by backports), then you really need it to be a > kernel extension. Not sure, I have to explore it. > > +LINUX_BACKPORTS_VERSION = 3.19-rc1 > We prefer "stable" versions rather than rc's. Ok, let it be 3.18.1. I just find 3.19-rc1 on http://drvbp1.linux-foundation.org/~mcgrof/rel-html/backports/ (Temporary backports release page, linked from homepage), I considered it as stable enough. > LINUX_MAKE_FLAGS are normally passed as arguments to make. So I'd remove I do probably something wrong: content of $(LINUX_MAKE_FLAGS) aren't added, so at least CROSS_COMPILE is missing. But That's for $(kconfig-package). It might not be needed for linux extension. > TARGET_MAKE_ENV from LINUX_BACKPORTS_MAKE_FLAGS and turn the make commands into > $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) \ > ... Ok. > Replace with $(kconfig-package), remove all the following and just set > LINUX_BACKPORTS_KCONFIG_EDITORS and LINUX_BACKPORTS_KCONFIG_FILE. > > +# Checks to give errors that the user can understand > > +ifeq ($(filter source,$(MAKECMDGOALS)),) > > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) > > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) > > +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) > > +endif > > +endif > > + > > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) > > +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) > > +endif > > +endif > > + > > +endif I'd keep the error messages as indication for user. Kind regards, Petr ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 9:03 ` Petr Vorel @ 2015-04-17 9:14 ` Arnout Vandecappelle 0 siblings, 0 replies; 13+ messages in thread From: Arnout Vandecappelle @ 2015-04-17 9:14 UTC (permalink / raw) To: buildroot On 17/04/15 11:03, Petr Vorel wrote: > Thanks for comments, I'll create new version tonight. > >> I would say that this package fits better in the linux extensions menu. Even if >> you just consider this package as a set of kernel modules, I think that from a >> users perspective it fits better together with the kernel. > Sounds reasonable, I'll do it. Well, Thomas disagrees, so I guess you shouldn't. Anyway, if it does become a Linux extension, the package will stay. One of the Kconfig options (the package or the linux extension) will be a blind option, and at that time we can still choose which one will be blind. [snip] >>> +# Checks to give errors that the user can understand >>> +ifeq ($(filter source,$(MAKECMDGOALS)),) >>> +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) >>> +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) >>> +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) >>> +endif >>> +endif >>> + >>> +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) >>> +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) >>> +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) >>> +endif >>> +endif >>> + >>> +endif > I'd keep the error messages as indication for user. If you use kconfig-package you should never get these messages because it already has that check, on line 70-74: # FOO_KCONFIG_FILE is required ifndef $(2)_KCONFIG_FILE $$(error Internal error: no value specified for $(2)_KCONFIG_FILE) endif Oh, now I see that Yann's patch to convert this to ifeq hasn't been applied yet... So yes in that case the custom check should stay. Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project @ 2015-04-17 9:33 Petr Vorel 2015-04-17 9:33 ` Petr Vorel 2015-04-17 19:44 ` Arnout Vandecappelle 0 siblings, 2 replies; 13+ messages in thread From: Petr Vorel @ 2015-04-17 9:33 UTC (permalink / raw) To: buildroot From: Petr Vorel <petr.vorel@gmail.com> I fixed things which were reported and keep it as a package. This is for first start. > # FOO_KCONFIG_FILE is required > ifndef $(2)_KCONFIG_FILE > $$(error Internal error: no value specified for $(2)_KCONFIG_FILE) > endif > Oh, now I see that Yann's patch to convert this to ifeq hasn't been applied > yet... So yes in that case the custom check should stay. Ok. Could you send me a link to the patch? > Anyway, if it does become a Linux extension, the package will stay. One of the > Kconfig options (the package or the linux extension) will be a blind option, and > at that time we can still choose which one will be blind. It's up to you folks to decide, if there could be both versions (package and extension). > I plan further improvements: > * Allow to use different versions > There are stable releases, snapshot based on current linux-next and some > archived versions based on linux-next. Although it's recommended to use the > latest stable version, some people prefer / need different version. > * Version check > For kernel versions older than 3.0 version backports-3.14 is needed, > kernels < 2.6.26 aren't supported. > * Custom patches > Ekvivalent of BR2_LINUX_KERNEL_PATCH. > * Custom repository version > Ekvivalent of BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION. Any comments? Kind regards, Petr ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 9:33 Petr Vorel @ 2015-04-17 9:33 ` Petr Vorel 2015-04-17 19:44 ` Arnout Vandecappelle 1 sibling, 0 replies; 13+ messages in thread From: Petr Vorel @ 2015-04-17 9:33 UTC (permalink / raw) To: buildroot From: Petr Vorel <petr.vorel@gmail.com> https://backports.wiki.kernel.org Signed-off-by: Petr Vorel <petr.vorel@gmail.com> --- package/Config.in | 1 + package/linux-backports/Config.in | 37 ++++++++++++++++++++++++++++ package/linux-backports/linux-backports.hash | 2 ++ package/linux-backports/linux-backports.mk | 35 ++++++++++++++++++++++++++ 4 files changed, 75 insertions(+) create mode 100644 package/linux-backports/Config.in create mode 100644 package/linux-backports/linux-backports.hash create mode 100644 package/linux-backports/linux-backports.mk diff --git a/package/Config.in b/package/Config.in index 34b6017..c8e24a7 100644 --- a/package/Config.in +++ b/package/Config.in @@ -365,6 +365,7 @@ endif source "package/iucode-tool/Config.in" source "package/kbd/Config.in" source "package/lcdproc/Config.in" + source "package/linux-backports/Config.in" source "package/lirc-tools/Config.in" source "package/lm-sensors/Config.in" source "package/lshw/Config.in" diff --git a/package/linux-backports/Config.in b/package/linux-backports/Config.in new file mode 100644 index 0000000..3e4e383 --- /dev/null +++ b/package/linux-backports/Config.in @@ -0,0 +1,37 @@ +config BR2_PACKAGE_LINUX_BACKPORTS + bool "Linux kernel driver backports" + depends on BR2_LINUX_KERNEL + help + The backports package includes many Linux drivers from recent + kernels, backported to older ones. + + https://backports.wiki.kernel.org + +if BR2_PACKAGE_LINUX_BACKPORTS + +choice + prompt "Linux kernel driver backports configuration" + default BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + bool "Using a defconfig" + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + bool "Using a custom config file" + +endchoice + +config BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG + string "Defconfig name" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + help + Name of the backports defconfig file to use. The defconfig is located + in defconfigs/ directory in the backports tree. + +config BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE + string "Configuration file path" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + help + Path to the backports configuration file + +endif diff --git a/package/linux-backports/linux-backports.hash b/package/linux-backports/linux-backports.hash new file mode 100644 index 0000000..42ea0b3 --- /dev/null +++ b/package/linux-backports/linux-backports.hash @@ -0,0 +1,2 @@ +# From: https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.18.1/sha256sums.asc +sha256 ff3d4d5192c4d57d7415dfcd60e02ea4fa21e0de224ae0ce2b5b9f2e9c815783 backports-3.18.1-1.tar.xz diff --git a/package/linux-backports/linux-backports.mk b/package/linux-backports/linux-backports.mk new file mode 100644 index 0000000..0d60354 --- /dev/null +++ b/package/linux-backports/linux-backports.mk @@ -0,0 +1,35 @@ +LINUX_BACKPORTS_VERSION = 3.18.1 +LINUX_BACKPORTS_REVISION = 1 +LINUX_BACKPORTS_SOURCE = backports-$(LINUX_BACKPORTS_VERSION)-$(LINUX_BACKPORTS_REVISION).tar.xz +LINUX_BACKPORTS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/projects/backports/stable/v$(LINUX_BACKPORTS_VERSION) +LINUX_BACKPORTS_DEPENDENCIES = linux + +LINUX_BACKPORTS_MAKE_OPTS = \ + $(TARGET_MAKE_ENV) \ + $(LINUX_MAKE_FLAGS) \ + KLIB_BUILD=$(LINUX_DIR) \ + KLIB=$(TARGET_DIR) + + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) +LINUX_BACKPORTS_KCONFIG_FILE = $(LINUX_BACKPORTS_DIR)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)) +else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +LINUX_BACKPORTS_KCONFIG_FILE = $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) +endif + +define LINUX_BACKPORTS_BUILD_CMDS + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ + -C $(@D) +endef + +define LINUX_BACKPORTS_INSTALL_TARGET_CMDS + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ + -C $(LINUX_DIR) M=$(@D) \ + INSTALL_MOD_DIR=backports \ + modules_install +endef + +LINUX_BACKPORTS_KCONFIG_EDITORS = menuconfig xconfig gconfig +LINUX_BACKPORTS_KCONFIG_OPTS = $(LINUX_BACKPORTS_MAKE_OPTS) + +$(eval $(kconfig-package)) -- 1.8.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 9:33 Petr Vorel 2015-04-17 9:33 ` Petr Vorel @ 2015-04-17 19:44 ` Arnout Vandecappelle 1 sibling, 0 replies; 13+ messages in thread From: Arnout Vandecappelle @ 2015-04-17 19:44 UTC (permalink / raw) To: buildroot On 17/04/15 11:33, Petr Vorel wrote: > From: Petr Vorel <petr.vorel@gmail.com> > > I fixed things which were reported and keep it as a package. This is for first start. > >> # FOO_KCONFIG_FILE is required >> ifndef $(2)_KCONFIG_FILE >> $$(error Internal error: no value specified for $(2)_KCONFIG_FILE) >> endif > >> Oh, now I see that Yann's patch to convert this to ifeq hasn't been applied >> yet... So yes in that case the custom check should stay. > Ok. Could you send me a link to the patch? http://patchwork.ozlabs.org/patch/459378/ [snip] >> I plan further improvements: >> * Allow to use different versions >> There are stable releases, snapshot based on current linux-next and some >> archived versions based on linux-next. Although it's recommended to use the >> latest stable version, some people prefer / need different version. I don't know if that is so important. If you really need that, you can still use OVERRIDE_SRCDIR or copy it to BR2_EXTERNAL under a different name or add a patch in BR2_GLOBAL_PATCH_DIR. > >> * Version check >> For kernel versions older than 3.0 version backports-3.14 is needed, >> kernels < 2.6.26 aren't supported. Ah, that is a reason to allow versions! But then I'd limit it to three versions, selectable with a choice: stable (default), next, and old (3.14). I don't think a check of the kernel version is needed. There are also dependencies in a bunch of other modules packages and those don't do a dependency check either. You can anyway only do that check while building (because you need to have the kernel source to extract the version), and usually the modules package already does a check itself. > >> * Custom patches >> Ekvivalent of BR2_LINUX_KERNEL_PATCH. That's kind of superseded by BR2_GLOBAL_PATCH_DIR. > >> * Custom repository version >> Ekvivalent of BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION. That one would be useful, so a fourth version in the choice. Regards, Arnout > Any comments? > > Kind regards, > Petr > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project @ 2015-04-17 9:40 Petr Vorel 2015-04-17 9:40 ` Petr Vorel 0 siblings, 1 reply; 13+ messages in thread From: Petr Vorel @ 2015-04-17 9:40 UTC (permalink / raw) To: buildroot From: Petr Vorel <petr.vorel@gmail.com> Just added missing custom checks. Kind regards, Petr ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 9:40 Petr Vorel @ 2015-04-17 9:40 ` Petr Vorel 2015-04-17 19:35 ` Arnout Vandecappelle 0 siblings, 1 reply; 13+ messages in thread From: Petr Vorel @ 2015-04-17 9:40 UTC (permalink / raw) To: buildroot From: Petr Vorel <petr.vorel@gmail.com> https://backports.wiki.kernel.org Signed-off-by: Petr Vorel <petr.vorel@gmail.com> --- package/Config.in | 1 + package/linux-backports/Config.in | 37 ++++++++++++++++++++ package/linux-backports/linux-backports.hash | 2 ++ package/linux-backports/linux-backports.mk | 51 ++++++++++++++++++++++++++++ 4 files changed, 91 insertions(+) create mode 100644 package/linux-backports/Config.in create mode 100644 package/linux-backports/linux-backports.hash create mode 100644 package/linux-backports/linux-backports.mk diff --git a/package/Config.in b/package/Config.in index 34b6017..c8e24a7 100644 --- a/package/Config.in +++ b/package/Config.in @@ -365,6 +365,7 @@ endif source "package/iucode-tool/Config.in" source "package/kbd/Config.in" source "package/lcdproc/Config.in" + source "package/linux-backports/Config.in" source "package/lirc-tools/Config.in" source "package/lm-sensors/Config.in" source "package/lshw/Config.in" diff --git a/package/linux-backports/Config.in b/package/linux-backports/Config.in new file mode 100644 index 0000000..3e4e383 --- /dev/null +++ b/package/linux-backports/Config.in @@ -0,0 +1,37 @@ +config BR2_PACKAGE_LINUX_BACKPORTS + bool "Linux kernel driver backports" + depends on BR2_LINUX_KERNEL + help + The backports package includes many Linux drivers from recent + kernels, backported to older ones. + + https://backports.wiki.kernel.org + +if BR2_PACKAGE_LINUX_BACKPORTS + +choice + prompt "Linux kernel driver backports configuration" + default BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + bool "Using a defconfig" + +config BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + bool "Using a custom config file" + +endchoice + +config BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG + string "Defconfig name" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG + help + Name of the backports defconfig file to use. The defconfig is located + in defconfigs/ directory in the backports tree. + +config BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE + string "Configuration file path" + depends on BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG + help + Path to the backports configuration file + +endif diff --git a/package/linux-backports/linux-backports.hash b/package/linux-backports/linux-backports.hash new file mode 100644 index 0000000..42ea0b3 --- /dev/null +++ b/package/linux-backports/linux-backports.hash @@ -0,0 +1,2 @@ +# From: https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.18.1/sha256sums.asc +sha256 ff3d4d5192c4d57d7415dfcd60e02ea4fa21e0de224ae0ce2b5b9f2e9c815783 backports-3.18.1-1.tar.xz diff --git a/package/linux-backports/linux-backports.mk b/package/linux-backports/linux-backports.mk new file mode 100644 index 0000000..b479b64 --- /dev/null +++ b/package/linux-backports/linux-backports.mk @@ -0,0 +1,51 @@ +LINUX_BACKPORTS_VERSION = 3.18.1 +LINUX_BACKPORTS_REVISION = 1 +LINUX_BACKPORTS_SOURCE = backports-$(LINUX_BACKPORTS_VERSION)-$(LINUX_BACKPORTS_REVISION).tar.xz +LINUX_BACKPORTS_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/projects/backports/stable/v$(LINUX_BACKPORTS_VERSION) +LINUX_BACKPORTS_DEPENDENCIES = linux + +LINUX_BACKPORTS_MAKE_OPTS = \ + $(TARGET_MAKE_ENV) \ + $(LINUX_MAKE_FLAGS) \ + KLIB_BUILD=$(LINUX_DIR) \ + KLIB=$(TARGET_DIR) + + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) +LINUX_BACKPORTS_KCONFIG_FILE = $(LINUX_BACKPORTS_DIR)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)) +else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +LINUX_BACKPORTS_KCONFIG_FILE = $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) +endif + +define LINUX_BACKPORTS_BUILD_CMDS + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ + -C $(@D) +endef + +define LINUX_BACKPORTS_INSTALL_TARGET_CMDS + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ + -C $(LINUX_DIR) M=$(@D) \ + INSTALL_MOD_DIR=backports \ + modules_install +endef + +LINUX_BACKPORTS_KCONFIG_EDITORS = menuconfig xconfig gconfig +LINUX_BACKPORTS_KCONFIG_OPTS = $(LINUX_BACKPORTS_MAKE_OPTS) + +$(eval $(kconfig-package)) + +# Checks to give errors that the user can understand +ifeq ($(filter source,$(MAKECMDGOALS)),) +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) +endif +endif + +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) +endif +endif + +endif -- 1.8.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 9:40 ` Petr Vorel @ 2015-04-17 19:35 ` Arnout Vandecappelle 2015-04-17 23:02 ` Petr Vorel 0 siblings, 1 reply; 13+ messages in thread From: Arnout Vandecappelle @ 2015-04-17 19:35 UTC (permalink / raw) To: buildroot On 17/04/15 11:40, Petr Vorel wrote: > From: Petr Vorel <petr.vorel@gmail.com> > > https://backports.wiki.kernel.org > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com> In the future, please give your patch a version number (by giving the argument -v3 or --subject-prefix='PATCH v3' to git send-email or format-patch). Also include a changelog below your SoB, separated by --- (you can do this while amending your commit). [snip] > +LINUX_BACKPORTS_MAKE_OPTS = \ > + $(TARGET_MAKE_ENV) \ This should be in LINUX_BACKPORTS_MAKE_ENV instead of _OPTS. Actually, kconfig-package should probably do a default assignment for LINUX_BACKPORTS_MAKE_ENV, but since it doesn't you have to do it explicitly. > + $(LINUX_MAKE_FLAGS) \ > + KLIB_BUILD=$(LINUX_DIR) \ > + KLIB=$(TARGET_DIR) > + > + > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) > +LINUX_BACKPORTS_KCONFIG_FILE = $(LINUX_BACKPORTS_DIR)/defconfigs/$(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)) > +else ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > +LINUX_BACKPORTS_KCONFIG_FILE = $(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE) > +endif > + > +define LINUX_BACKPORTS_BUILD_CMDS > + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ > + -C $(@D) This would fit on a single line. However, ince below you're calling modules_install directly, would it be possible/reasonable to do the build in the same way? It's always nice if the different CMDS definitions look the same. So $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ -C $(LINUX_DIR) M=$(@D) \ modules But if the backports build system does some extra magic (NOT kconfig stuff, but other magic), then of course you shouldn't do this. > +endef > + > +define LINUX_BACKPORTS_INSTALL_TARGET_CMDS > + $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ > + -C $(LINUX_DIR) M=$(@D) \ > + INSTALL_MOD_DIR=backports \ > + modules_install > +endef > + > +LINUX_BACKPORTS_KCONFIG_EDITORS = menuconfig xconfig gconfig No nconfig? Not that it matters much... Regards, Arnout > +LINUX_BACKPORTS_KCONFIG_OPTS = $(LINUX_BACKPORTS_MAKE_OPTS) > + > +$(eval $(kconfig-package)) > + > +# Checks to give errors that the user can understand > +ifeq ($(filter source,$(MAKECMDGOALS)),) > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y) > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),) > +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting) > +endif > +endif > + > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y) > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),) > +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting) > +endif > +endif > + > +endif > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH 1/1] Added linux drivers backports project 2015-04-17 19:35 ` Arnout Vandecappelle @ 2015-04-17 23:02 ` Petr Vorel 0 siblings, 0 replies; 13+ messages in thread From: Petr Vorel @ 2015-04-17 23:02 UTC (permalink / raw) To: buildroot > In the future, please give your patch a version number (by giving the argument > -v3 or --subject-prefix='PATCH v3' to git send-email or format-patch). Also > include a changelog below your SoB, separated by --- (you can do this while > amending your commit). Fixed, hope it's correct this time. Sent as -v4. > Actually, kconfig-package should probably do a default assignment for > LINUX_BACKPORTS_MAKE_ENV, but since it doesn't you have to do it explicitly. I need LINUX_BACKPORTS_MAKE_ENV, as KLIB and KLIB_BUILD aren't set. > However, ince below you're calling modules_install directly, would it be > possible/reasonable to do the build in the same way? It's always nice if the > different CMDS definitions look the same. So > $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \ > -C $(LINUX_DIR) M=$(@D) \ > modules > But if the backports build system does some extra magic (NOT kconfig stuff, but > other magic), then of course you shouldn't do this. Unfortunately it has to be build this way (or I haven't found any better). LINUX_BACKPORTS_BUILD_CMDS needs -C $(@D), otherwise there is infinite loop. I'm surprised, as $(@D) is backport directory (I'd expect to be add automatically) - suppose I have an error somewhere. LINUX_BACKPORTS_INSTALL_TARGET_CMDS needs -C $(LINUX_DIR) M=$(@D) => different commands. > No nconfig? Not that it matters much... Taken from busybox where it wasn't (sent as separate patch). Added... BTW: I'd expect to have one unique default variable for all of those. Kind regards, Petr ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-04-17 23:02 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-04-15 21:55 [Buildroot] [PATCH 0/1] Added linux drivers backports project Petr Vorel 2015-04-15 21:55 ` [Buildroot] [PATCH 1/1] " Petr Vorel 2015-04-16 20:29 ` Arnout Vandecappelle 2015-04-17 8:01 ` Thomas Petazzoni 2015-04-17 9:03 ` Petr Vorel 2015-04-17 9:14 ` Arnout Vandecappelle 2015-04-17 9:33 Petr Vorel 2015-04-17 9:33 ` Petr Vorel 2015-04-17 19:44 ` Arnout Vandecappelle 2015-04-17 9:40 Petr Vorel 2015-04-17 9:40 ` Petr Vorel 2015-04-17 19:35 ` Arnout Vandecappelle 2015-04-17 23:02 ` Petr Vorel
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.