From: Magnus Damm <magnus.damm@gmail.com> To: linux-sh@vger.kernel.org Cc: jason@lakedaemon.net, geert+renesas@glider.be, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms@verge.net.au, Magnus Damm <magnus.damm@gmail.com>, tglx@linutronix.de Subject: [PATCH/RFC 02/03] irqchip: renesas-irqc: Add fine grained Runtime PM code Date: Tue, 21 Apr 2015 15:01:37 +0000 [thread overview] Message-ID: <20150421150137.14288.45064.sendpatchset@little-apple> (raw) In-Reply-To: <20150421150115.14288.88519.sendpatchset@little-apple> From: Magnus Damm <damm+renesas@opensource.se> Convert Runtime PM support from coarse grained "always enabled" into more fine grained per-interrupt optional enablement. Signed-off-by: Magnus Damm <damm+renesas@opensource.se> --- drivers/irqchip/irq-renesas-irqc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) --- 0002/drivers/irqchip/irq-renesas-irqc.c +++ work/drivers/irqchip/irq-renesas-irqc.c 2015-04-21 23:16:17.686370138 +0900 @@ -96,12 +96,18 @@ static void irqc_irq_mask(struct irq_dat static void irqc_irq_enable(struct irq_data *d) { + struct irqc_priv *p = irq_data_get_irq_chip_data(d); + + pm_runtime_get_sync(&p->pdev->dev); irqc_irq_unmask(d); } static void irqc_irq_disable(struct irq_data *d) { + struct irqc_priv *p = irq_data_get_irq_chip_data(d); + irqc_irq_mask(d); + pm_runtime_put(&p->pdev->dev); } static unsigned char irqc_sense[IRQ_TYPE_SENSE_MASK + 1] = { @@ -124,10 +130,12 @@ static int irqc_irq_set_type(struct irq_ if (!value) return -EINVAL; + pm_runtime_get_sync(&p->pdev->dev); tmp = ioread32(p->iomem + IRQC_CONFIG(hw_irq)); tmp &= ~0x3f; tmp |= value; iowrite32(tmp, p->iomem + IRQC_CONFIG(hw_irq)); + pm_runtime_put(&p->pdev->dev); return 0; } @@ -215,7 +223,6 @@ static int irqc_probe(struct platform_de } pm_runtime_enable(&pdev->dev); - pm_runtime_get_sync(&pdev->dev); /* get hold of manadatory IOMEM */ io = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -300,7 +307,6 @@ err3: err2: iounmap(p->iomem); err1: - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); kfree(p); err0: @@ -317,7 +323,6 @@ static int irqc_remove(struct platform_d irq_domain_remove(p->irq_domain); iounmap(p->iomem); - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); kfree(p); return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com> To: linux-sh@vger.kernel.org Cc: jason@lakedaemon.net, geert+renesas@glider.be, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms@verge.net.au, Magnus Damm <magnus.damm@gmail.com>, tglx@linutronix.de Subject: [PATCH/RFC 02/03] irqchip: renesas-irqc: Add fine grained Runtime PM code Date: Wed, 22 Apr 2015 00:01:37 +0900 [thread overview] Message-ID: <20150421150137.14288.45064.sendpatchset@little-apple> (raw) In-Reply-To: <20150421150115.14288.88519.sendpatchset@little-apple> From: Magnus Damm <damm+renesas@opensource.se> Convert Runtime PM support from coarse grained "always enabled" into more fine grained per-interrupt optional enablement. Signed-off-by: Magnus Damm <damm+renesas@opensource.se> --- drivers/irqchip/irq-renesas-irqc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) --- 0002/drivers/irqchip/irq-renesas-irqc.c +++ work/drivers/irqchip/irq-renesas-irqc.c 2015-04-21 23:16:17.686370138 +0900 @@ -96,12 +96,18 @@ static void irqc_irq_mask(struct irq_dat static void irqc_irq_enable(struct irq_data *d) { + struct irqc_priv *p = irq_data_get_irq_chip_data(d); + + pm_runtime_get_sync(&p->pdev->dev); irqc_irq_unmask(d); } static void irqc_irq_disable(struct irq_data *d) { + struct irqc_priv *p = irq_data_get_irq_chip_data(d); + irqc_irq_mask(d); + pm_runtime_put(&p->pdev->dev); } static unsigned char irqc_sense[IRQ_TYPE_SENSE_MASK + 1] = { @@ -124,10 +130,12 @@ static int irqc_irq_set_type(struct irq_ if (!value) return -EINVAL; + pm_runtime_get_sync(&p->pdev->dev); tmp = ioread32(p->iomem + IRQC_CONFIG(hw_irq)); tmp &= ~0x3f; tmp |= value; iowrite32(tmp, p->iomem + IRQC_CONFIG(hw_irq)); + pm_runtime_put(&p->pdev->dev); return 0; } @@ -215,7 +223,6 @@ static int irqc_probe(struct platform_de } pm_runtime_enable(&pdev->dev); - pm_runtime_get_sync(&pdev->dev); /* get hold of manadatory IOMEM */ io = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -300,7 +307,6 @@ err3: err2: iounmap(p->iomem); err1: - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); kfree(p); err0: @@ -317,7 +323,6 @@ static int irqc_remove(struct platform_d irq_domain_remove(p->irq_domain); iounmap(p->iomem); - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); kfree(p); return 0;
next prev parent reply other threads:[~2015-04-21 15:01 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-21 14:59 [PATCH/RFC 00/03] irqchip: renesas-irqc: Fine grained Runtime PM support Magnus Damm 2015-04-21 15:01 ` Magnus Damm 2015-04-21 14:59 ` [PATCH/RFC 01/03] irqchip: renesas-irqc: Add irq_enable() and irq_disable() Magnus Damm 2015-04-21 15:01 ` Magnus Damm 2015-04-21 15:01 ` Magnus Damm [this message] 2015-04-21 15:01 ` [PATCH/RFC 02/03] irqchip: renesas-irqc: Add fine grained Runtime PM code Magnus Damm 2015-04-21 15:01 ` [PATCH/RFC 03/03] irqchip: renesas-irqc: Rely on Runtime PM for wakeup Magnus Damm 2015-04-21 15:01 ` Magnus Damm 2015-04-21 17:56 ` [PATCH/RFC 00/03] irqchip: renesas-irqc: Fine grained Runtime PM support Geert Uytterhoeven 2015-04-21 17:56 ` Geert Uytterhoeven 2015-04-23 8:10 ` Magnus Damm 2015-04-23 8:10 ` Magnus Damm 2015-04-23 9:51 ` Geert Uytterhoeven 2015-04-23 9:51 ` Geert Uytterhoeven 2015-04-23 14:44 ` Alan Stern 2015-04-23 14:44 ` Alan Stern 2015-04-23 17:49 ` Geert Uytterhoeven 2015-04-23 17:49 ` Geert Uytterhoeven 2015-05-08 20:26 ` Kevin Hilman 2015-05-08 20:26 ` Kevin Hilman 2015-05-08 20:26 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150421150137.14288.45064.sendpatchset@little-apple \ --to=magnus.damm@gmail.com \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.