All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] mosquitto: remove ipv6 depends
@ 2015-04-22 22:13 Gustavo Zacarias
  2015-04-22 22:20 ` Yann E. MORIN
  2015-04-23  7:48 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2015-04-22 22:13 UTC (permalink / raw)
  To: buildroot

The package was added after the last iteration of the non-ipv6
toolchain removal, so adjust it.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/mosquitto/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
index 8f579f8..50937d0 100644
--- a/package/mosquitto/Config.in
+++ b/package/mosquitto/Config.in
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_MOSQUITTO
 	bool "mosquitto"
 	depends on BR2_USE_MMU # fork()
-	depends on BR2_INET_IPV6
 	depends on !BR2_STATIC_LIBS # builds .so
 	help
 	  Mosquitto is an open source message broker that implements
@@ -14,6 +13,6 @@ config BR2_PACKAGE_MOSQUITTO
 
 	  http://mosquitto.org/
 
-comment "mosquitto needs a toolchain w/ IPv6, dynamic library"
+comment "mosquitto needs a toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_INET_IPV6 || BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS
-- 
2.0.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] mosquitto: remove ipv6 depends
  2015-04-22 22:13 [Buildroot] [PATCH] mosquitto: remove ipv6 depends Gustavo Zacarias
@ 2015-04-22 22:20 ` Yann E. MORIN
  2015-04-23  7:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-04-22 22:20 UTC (permalink / raw)
  To: buildroot

Gustavo, All,

On 2015-04-22 19:13 -0300, Gustavo Zacarias spake thusly:
> The package was added after the last iteration of the non-ipv6
> toolchain removal, so adjust it.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Now it occurs to me that we should probably have kep a hiden symbol,
like so:

    config BR2_INET_IPV6
        bool
        default y

so that existing out-of-tree packages (e.g. in some br2-external trees)
continue to work seamlessly...

But them users would probably never notice the breakage, so maybe better
break early...

Regards,
Yann E. MORIN.

> ---
>  package/mosquitto/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
> index 8f579f8..50937d0 100644
> --- a/package/mosquitto/Config.in
> +++ b/package/mosquitto/Config.in
> @@ -1,7 +1,6 @@
>  config BR2_PACKAGE_MOSQUITTO
>  	bool "mosquitto"
>  	depends on BR2_USE_MMU # fork()
> -	depends on BR2_INET_IPV6
>  	depends on !BR2_STATIC_LIBS # builds .so
>  	help
>  	  Mosquitto is an open source message broker that implements
> @@ -14,6 +13,6 @@ config BR2_PACKAGE_MOSQUITTO
>  
>  	  http://mosquitto.org/
>  
> -comment "mosquitto needs a toolchain w/ IPv6, dynamic library"
> +comment "mosquitto needs a toolchain w/ dynamic library"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_INET_IPV6 || BR2_STATIC_LIBS
> +	depends on BR2_STATIC_LIBS
> -- 
> 2.0.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] mosquitto: remove ipv6 depends
  2015-04-22 22:13 [Buildroot] [PATCH] mosquitto: remove ipv6 depends Gustavo Zacarias
  2015-04-22 22:20 ` Yann E. MORIN
@ 2015-04-23  7:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-04-23  7:48 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Wed, 22 Apr 2015 19:13:58 -0300, Gustavo Zacarias wrote:
> The package was added after the last iteration of the non-ipv6
> toolchain removal, so adjust it.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/mosquitto/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-23  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-22 22:13 [Buildroot] [PATCH] mosquitto: remove ipv6 depends Gustavo Zacarias
2015-04-22 22:20 ` Yann E. MORIN
2015-04-23  7:48 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.