All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-26 10:15 ` Richard Genoud
  0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2015-04-26 10:15 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel, Richard Genoud

The A10 has 8 uarts, only uart0 and uart1 where filled.
This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi |   84 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)

Based on V4.0
uart4_a tested on cubieboard A10

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index eebb785..e83fd2c 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -673,6 +673,90 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			uart2_pins_a: uart2@0 {
+				allwinner,pins = "PA2", "PA3";
+				allwinner,function = "uart2";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart2_pins_b: uart2@1 {
+				allwinner,pins = "PI18", "PI19";
+				allwinner,function = "uart2";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart3_pins_a: uart3@0 {
+				allwinner,pins = "PG6", "PG7";
+				allwinner,function = "uart3";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart3_pins_b: uart3@1 {
+				allwinner,pins = "PH0", "PH1";
+				allwinner,function = "uart3";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart4_pins_a: uart4@0 {
+				allwinner,pins = "PG10", "PG11";
+				allwinner,function = "uart4";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart4_pins_b: uart4@1 {
+				allwinner,pins = "PH4", "PH5";
+				allwinner,function = "uart4";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart5_pins_a: uart5@0 {
+				allwinner,pins = "PH6", "PH7";
+				allwinner,function = "uart5";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart5_pins_b: uart5@1 {
+				allwinner,pins = "PI10", "PI11";
+				allwinner,function = "uart5";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart6_pins_a: uart6@0 {
+				allwinner,pins = "PA12", "PA13";
+				allwinner,function = "uart6";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart6_pins_b: uart6@1 {
+				allwinner,pins = "PI12", "PI13";
+				allwinner,function = "uart6";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart7_pins_a: uart7@0 {
+				allwinner,pins = "PA14", "PA15";
+				allwinner,function = "uart7";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart7_pins_b: uart7@1 {
+				allwinner,pins = "PI20", "PI21";
+				allwinner,function = "uart7";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			i2c0_pins_a: i2c0@0 {
 				allwinner,pins = "PB0", "PB1";
 				allwinner,function = "i2c0";
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-26 10:15 ` Richard Genoud
  0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2015-04-26 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

The A10 has 8 uarts, only uart0 and uart1 where filled.
This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi |   84 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)

Based on V4.0
uart4_a tested on cubieboard A10

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index eebb785..e83fd2c 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -673,6 +673,90 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			uart2_pins_a: uart2 at 0 {
+				allwinner,pins = "PA2", "PA3";
+				allwinner,function = "uart2";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart2_pins_b: uart2 at 1 {
+				allwinner,pins = "PI18", "PI19";
+				allwinner,function = "uart2";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart3_pins_a: uart3 at 0 {
+				allwinner,pins = "PG6", "PG7";
+				allwinner,function = "uart3";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart3_pins_b: uart3 at 1 {
+				allwinner,pins = "PH0", "PH1";
+				allwinner,function = "uart3";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart4_pins_a: uart4 at 0 {
+				allwinner,pins = "PG10", "PG11";
+				allwinner,function = "uart4";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart4_pins_b: uart4 at 1 {
+				allwinner,pins = "PH4", "PH5";
+				allwinner,function = "uart4";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart5_pins_a: uart5 at 0 {
+				allwinner,pins = "PH6", "PH7";
+				allwinner,function = "uart5";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart5_pins_b: uart5 at 1 {
+				allwinner,pins = "PI10", "PI11";
+				allwinner,function = "uart5";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart6_pins_a: uart6 at 0 {
+				allwinner,pins = "PA12", "PA13";
+				allwinner,function = "uart6";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart6_pins_b: uart6 at 1 {
+				allwinner,pins = "PI12", "PI13";
+				allwinner,function = "uart6";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart7_pins_a: uart7 at 0 {
+				allwinner,pins = "PA14", "PA15";
+				allwinner,function = "uart7";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart7_pins_b: uart7 at 1 {
+				allwinner,pins = "PI20", "PI21";
+				allwinner,function = "uart7";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			i2c0_pins_a: i2c0 at 0 {
 				allwinner,pins = "PB0", "PB1";
 				allwinner,function = "i2c0";
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
  2015-04-26 10:15 ` Richard Genoud
@ 2015-04-26 16:11   ` Maxime Ripard
  -1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2015-04-26 16:11 UTC (permalink / raw)
  To: Richard Genoud; +Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Hi Richard,

On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
> The A10 has 8 uarts, only uart0 and uart1 where filled.
> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>

It's obviously correct, but I'd rather not add new pinctrl nodes that
don't have any users so that it doesn't bloat the DT without any
particular reason.

Feel free to resubmit this patch if one of these nodes become actually
useful.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-26 16:11   ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2015-04-26 16:11 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Richard,

On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
> The A10 has 8 uarts, only uart0 and uart1 where filled.
> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>

It's obviously correct, but I'd rather not add new pinctrl nodes that
don't have any users so that it doesn't bloat the DT without any
particular reason.

Feel free to resubmit this patch if one of these nodes become actually
useful.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150426/fa36aaa2/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
  2015-04-26 16:11   ` Maxime Ripard
  (?)
@ 2015-04-27  6:36     ` Richard Genoud
  -1 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2015-04-27  6:36 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel

2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Hi Richard,
>
> On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
>> The A10 has 8 uarts, only uart0 and uart1 where filled.
>> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
>
> It's obviously correct, but I'd rather not add new pinctrl nodes that
> don't have any users so that it doesn't bloat the DT without any
> particular reason.
>
> Feel free to resubmit this patch if one of these nodes become actually
> useful.

Ok, I'll resend-it with only the uarts accessible via the cubieboard
A10 expansion headers.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-27  6:36     ` Richard Genoud
  0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2015-04-27  6:36 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> Hi Richard,
>
> On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
>> The A10 has 8 uarts, only uart0 and uart1 where filled.
>> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
>>
>> Signed-off-by: Richard Genoud <richard.genoud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> It's obviously correct, but I'd rather not add new pinctrl nodes that
> don't have any users so that it doesn't bloat the DT without any
> particular reason.
>
> Feel free to resubmit this patch if one of these nodes become actually
> useful.

Ok, I'll resend-it with only the uarts accessible via the cubieboard
A10 expansion headers.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-27  6:36     ` Richard Genoud
  0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2015-04-27  6:36 UTC (permalink / raw)
  To: linux-arm-kernel

2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Hi Richard,
>
> On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
>> The A10 has 8 uarts, only uart0 and uart1 where filled.
>> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
>
> It's obviously correct, but I'd rather not add new pinctrl nodes that
> don't have any users so that it doesn't bloat the DT without any
> particular reason.
>
> Feel free to resubmit this patch if one of these nodes become actually
> useful.

Ok, I'll resend-it with only the uarts accessible via the cubieboard
A10 expansion headers.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
  2015-04-27  6:36     ` Richard Genoud
  (?)
@ 2015-04-27  9:52       ` Maxime Ripard
  -1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2015-04-27  9:52 UTC (permalink / raw)
  To: Richard Genoud; +Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Mon, Apr 27, 2015 at 08:36:02AM +0200, Richard Genoud wrote:
> 2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> > Hi Richard,
> >
> > On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
> >> The A10 has 8 uarts, only uart0 and uart1 where filled.
> >> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
> >>
> >> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> >
> > It's obviously correct, but I'd rather not add new pinctrl nodes that
> > don't have any users so that it doesn't bloat the DT without any
> > particular reason.
> >
> > Feel free to resubmit this patch if one of these nodes become actually
> > useful.
> 
> Ok, I'll resend-it with only the uarts accessible via the cubieboard
> A10 expansion headers.

If you're not going to add new users for these nodes either, don't
bother.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-27  9:52       ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2015-04-27  9:52 UTC (permalink / raw)
  To: Richard Genoud; +Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Mon, Apr 27, 2015 at 08:36:02AM +0200, Richard Genoud wrote:
> 2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> > Hi Richard,
> >
> > On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
> >> The A10 has 8 uarts, only uart0 and uart1 where filled.
> >> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
> >>
> >> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> >
> > It's obviously correct, but I'd rather not add new pinctrl nodes that
> > don't have any users so that it doesn't bloat the DT without any
> > particular reason.
> >
> > Feel free to resubmit this patch if one of these nodes become actually
> > useful.
> 
> Ok, I'll resend-it with only the uarts accessible via the cubieboard
> A10 expansion headers.

If you're not going to add new users for these nodes either, don't
bother.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options
@ 2015-04-27  9:52       ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2015-04-27  9:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 27, 2015 at 08:36:02AM +0200, Richard Genoud wrote:
> 2015-04-26 18:11 GMT+02:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> > Hi Richard,
> >
> > On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote:
> >> The A10 has 8 uarts, only uart0 and uart1 where filled.
> >> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi.
> >>
> >> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> >
> > It's obviously correct, but I'd rather not add new pinctrl nodes that
> > don't have any users so that it doesn't bloat the DT without any
> > particular reason.
> >
> > Feel free to resubmit this patch if one of these nodes become actually
> > useful.
> 
> Ok, I'll resend-it with only the uarts accessible via the cubieboard
> A10 expansion headers.

If you're not going to add new users for these nodes either, don't
bother.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150427/fee268e9/attachment.sig>

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-04-27  9:55 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-26 10:15 [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options Richard Genoud
2015-04-26 10:15 ` Richard Genoud
2015-04-26 16:11 ` Maxime Ripard
2015-04-26 16:11   ` Maxime Ripard
2015-04-27  6:36   ` Richard Genoud
2015-04-27  6:36     ` Richard Genoud
2015-04-27  6:36     ` Richard Genoud
2015-04-27  9:52     ` Maxime Ripard
2015-04-27  9:52       ` Maxime Ripard
2015-04-27  9:52       ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.