* [PATCH] net: fec: Fix RGMII-ID mode
@ 2015-04-30 15:07 ` Markus Pargmann
0 siblings, 0 replies; 4+ messages in thread
From: Markus Pargmann @ 2015-04-30 15:07 UTC (permalink / raw)
To: David S. Miller
Cc: Fabio Estevam, Nimrod Andy, netdev, linux-arm-kernel, kernel,
Markus Pargmann
RGMII-ID uses an internal delay within the transmitter or receiver. This
feature is phy specific. The rest of the communication is normal RGMII.
So the fec driver has to check for all RGMII modes, not only
'PHY_INTERFACE_MODE_RGMII'.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/net/ethernet/freescale/fec_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index f6a3a7abd468..66d47e448e4d 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -988,7 +988,10 @@ fec_restart(struct net_device *ndev)
rcntl |= 0x40000000 | 0x00000020;
/* RGMII, RMII or MII */
- if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII)
+ if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID)
rcntl |= (1 << 6);
else if (fep->phy_interface == PHY_INTERFACE_MODE_RMII)
rcntl |= (1 << 8);
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: fec: Fix RGMII-ID mode
@ 2015-04-30 15:07 ` Markus Pargmann
0 siblings, 0 replies; 4+ messages in thread
From: Markus Pargmann @ 2015-04-30 15:07 UTC (permalink / raw)
To: linux-arm-kernel
RGMII-ID uses an internal delay within the transmitter or receiver. This
feature is phy specific. The rest of the communication is normal RGMII.
So the fec driver has to check for all RGMII modes, not only
'PHY_INTERFACE_MODE_RGMII'.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/net/ethernet/freescale/fec_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index f6a3a7abd468..66d47e448e4d 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -988,7 +988,10 @@ fec_restart(struct net_device *ndev)
rcntl |= 0x40000000 | 0x00000020;
/* RGMII, RMII or MII */
- if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII)
+ if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
+ fep->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID)
rcntl |= (1 << 6);
else if (fep->phy_interface == PHY_INTERFACE_MODE_RMII)
rcntl |= (1 << 8);
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: fec: Fix RGMII-ID mode
2015-04-30 15:07 ` Markus Pargmann
@ 2015-04-30 20:49 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-04-30 20:49 UTC (permalink / raw)
To: mpa; +Cc: festevam, B38611, netdev, linux-arm-kernel, kernel
From: Markus Pargmann <mpa@pengutronix.de>
Date: Thu, 30 Apr 2015 17:07:50 +0200
> RGMII-ID uses an internal delay within the transmitter or receiver. This
> feature is phy specific. The rest of the communication is normal RGMII.
>
> So the fec driver has to check for all RGMII modes, not only
> 'PHY_INTERFACE_MODE_RGMII'.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net: fec: Fix RGMII-ID mode
@ 2015-04-30 20:49 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-04-30 20:49 UTC (permalink / raw)
To: linux-arm-kernel
From: Markus Pargmann <mpa@pengutronix.de>
Date: Thu, 30 Apr 2015 17:07:50 +0200
> RGMII-ID uses an internal delay within the transmitter or receiver. This
> feature is phy specific. The rest of the communication is normal RGMII.
>
> So the fec driver has to check for all RGMII modes, not only
> 'PHY_INTERFACE_MODE_RGMII'.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-30 20:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-30 15:07 [PATCH] net: fec: Fix RGMII-ID mode Markus Pargmann
2015-04-30 15:07 ` Markus Pargmann
2015-04-30 20:49 ` David Miller
2015-04-30 20:49 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.