Re: [PATCH] ss: Fix wrong filter behaviour

Re: [PATCH] ss: Fix wrong filter behaviour

[Mihai Moldovan]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On 28.04.2015 03:37 PM, Vadim Kochan wrote:
> On Tue, Apr 28, 2015 at 04:16:48PM +0300, Vadim Kochan wrote:
>> From: Vadim Kochan <vadim4j@gmail.com>
>>
>> Fixed applying family & socket type filters.
>> It was not possible to select UDP & UNIX sockets together.
>>
>> Now selected families are ORed.
>>
>> The problem was that filters were combined by AND.
>>
>> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
>> Reported-By: Mihai Moldovan <ionic@ionic.de>
>> ---
>>  misc/ss.c | 91 ++++++++++++++++++++++++++++++++++-----------------------------
>>  1 file changed, 49 insertions(+), 42 deletions(-)
>>
>> diff --git a/misc/ss.c b/misc/ss.c
>> index 954a30b..46dbb39 100644
>> [...]
> 
> Would you please respond if you received this patch ?
> I am just checking, in case if it was get into 'Spam' list.
> 
> Regards,

I finally came around to testing this, sorry it took me so long.

Using that patch, the output looks much better. It works for my use case.

What do we do with the "broken" versions, though? Even if that patch hits 4.1.0,
older versions like 4.0.0, 3.19.0 etc. will still be broken?



Mihai


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [PATCH] ss: Fix wrong filter behaviour

[Vadim Kochan]

On Wed, Apr 29, 2015 at 11:22:13PM +0200, Mihai Moldovan wrote:
> On 28.04.2015 03:37 PM, Vadim Kochan wrote:
> > On Tue, Apr 28, 2015 at 04:16:48PM +0300, Vadim Kochan wrote:
> >> From: Vadim Kochan <vadim4j@gmail.com>
> >>
> >> Fixed applying family & socket type filters.
> >> It was not possible to select UDP & UNIX sockets together.
> >>
> >> Now selected families are ORed.
> >>
> >> The problem was that filters were combined by AND.
> >>
> >> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> >> Reported-By: Mihai Moldovan <ionic@ionic.de>
> >> ---
> >>  misc/ss.c | 91 ++++++++++++++++++++++++++++++++++-----------------------------
> >>  1 file changed, 49 insertions(+), 42 deletions(-)
> >>
> >> diff --git a/misc/ss.c b/misc/ss.c
> >> index 954a30b..46dbb39 100644
> >> [...]
> > 
> > Would you please respond if you received this patch ?
> > I am just checking, in case if it was get into 'Spam' list.
> > 
> > Regards,
> 
> I finally came around to testing this, sorry it took me so long.
> 
> Using that patch, the output looks much better. It works for my use case.
> 
> What do we do with the "broken" versions, though? Even if that patch hits 4.1.0,
> older versions like 4.0.0, 3.19.0 etc. will still be broken?
> 
> 
> 
> Mihai
> 

Hi Mihai,

I think it depends on distro package maintainers, usually they track the
upstream fixes and uses them in their stable versions, may be I should
grep some maintainers emails (LARTC mailing list ?) and broadcast to them ?

Regards,

Re: [PATCH] ss: Fix wrong filter behaviour

[Mihai Moldovan]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On 30.04.2015 09:26 AM, Vadim Kochan wrote:
> I think it depends on distro package maintainers, usually they track the
> upstream fixes and uses them in their stable versions, may be I should
> grep some maintainers emails (LARTC mailing list ?) and broadcast to them ?

Well... that's strictly speaking not your responsibility. I can make them aware,
I guess?



Mihai


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [PATCH] ss: Fix wrong filter behaviour

[Stephen Hemminger]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

On Wed, 29 Apr 2015 23:22:13 +0200
Mihai Moldovan <ionic@ionic.de> wrote:

> On 28.04.2015 03:37 PM, Vadim Kochan wrote:
> > On Tue, Apr 28, 2015 at 04:16:48PM +0300, Vadim Kochan wrote:
> >> From: Vadim Kochan <vadim4j@gmail.com>
> >>
> >> Fixed applying family & socket type filters.
> >> It was not possible to select UDP & UNIX sockets together.
> >>
> >> Now selected families are ORed.
> >>
> >> The problem was that filters were combined by AND.
> >>
> >> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> >> Reported-By: Mihai Moldovan <ionic@ionic.de>
> >> ---
> >>  misc/ss.c | 91 ++++++++++++++++++++++++++++++++++-----------------------------
> >>  1 file changed, 49 insertions(+), 42 deletions(-)
> >>
> >> diff --git a/misc/ss.c b/misc/ss.c
> >> index 954a30b..46dbb39 100644
> >> [...]
> > 
> > Would you please respond if you received this patch ?
> > I am just checking, in case if it was get into 'Spam' list.
> > 
> > Regards,
> 
> I finally came around to testing this, sorry it took me so long.
> 
> Using that patch, the output looks much better. It works for my use case.
> 
> What do we do with the "broken" versions, though? Even if that patch hits 4.1.0,
> older versions like 4.0.0, 3.19.0 etc. will still be broken?

I could put out a 4.0.1 but usually reserve doing maintenance releases for serious bugs
like security problems.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]