* [Buildroot] [git commit] pkg-infra: assign BR_NO_CHECK_HASH_FOR so it is recursively-expanded
@ 2015-05-02 13:11 Thomas Petazzoni
0 siblings, 0 replies; only message in thread
From: Thomas Petazzoni @ 2015-05-02 13:11 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=9fa6209fd2150276c3be287399567e37dcbc862e
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Currently, assigning to BR_NO_CHECK_HASH_FOR but referencing variable
assigned to later, fails. Here's a failing test-case, which is the
reduced test-case of how we handle BR_NO_CHECK_HASH_FOR for now (warning
added for test-case):
export BR_NO_CHECK_HASH_FOR
BR_NO_CHECK_HASH_FOR += $(XENOMAI_SOURCE)
XENOMAI_VERSION = 2.6.4
XENOMAI_SOURCE = xenomai-$(XENOMAI_VERSION).tar.bz2
$(warning BR_NO_CHECK_HASH_FOR='$(BR_NO_CHECK_HASH_FOR)')
all:
Run it with simply make:
$ make
BR_NO_CHECK_HASH_FOR=' '
Now, change the first line to read:
export BR_NO_CHECK_HASH_FOR =
And we now get:
$ make
BR_NO_CHECK_HASH_FOR=' xenomai-2.6.4.tar.bz2'
This new behaviour will be needed later for Xenomai, which handles the
version string in an unusual way, so we can exclude its custom versions.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/pkg-download.mk | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index a38062e..f6ed8be 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -56,7 +56,9 @@ domainseparator = $(if $(1),$(1),/)
github = https://github.com/$(1)/$(2)/archive/$(3)
# Expressly do not check hashes for those files
-export BR_NO_CHECK_HASH_FOR
+# Exported variables default to immediately expanded in some versions of
+# make, but we need it to be recursively-epxanded, so explicitly assign it.
+export BR_NO_CHECK_HASH_FOR =
################################################################################
# The DOWNLOAD_* helpers are in charge of getting a working copy
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-02 13:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-02 13:11 [Buildroot] [git commit] pkg-infra: assign BR_NO_CHECK_HASH_FOR so it is recursively-expanded Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.