v4.1-rc1 & N900: annoying Nokia modem spam

v4.1-rc1 & N900: annoying Nokia modem spam

[Aaro Koskinen]

Hi,

With v4.1-rc1, after loading nokia_modem I get the following endless
log spam until I load cmt_speech (for whatever reason it does not get
modprobed automatically with busybox modprobe):

	[   41.626983] nokia-modem n900-modem: Missing cmt-speech driver
	[   41.804565] nokia-modem n900-modem: GPIO lookup for consumer (null)
	[   41.804626] nokia-modem n900-modem: using device tree for GPIO lookup
	[   41.804687] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[0]' - status (0)
	[   41.804718] no flags found for (null)
	[   41.805023] nokia-modem n900-modem: GPIO lookup for consumer (null)
	[   41.805023] nokia-modem n900-modem: using device tree for GPIO lookup
	[   41.805145] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[1]' - status (0)
	[   41.805145] no flags found for (null)
	[   41.805389] nokia-modem n900-modem: GPIO lookup for consumer (null)
	[   41.805419] nokia-modem n900-modem: using device tree for GPIO lookup
	[   41.805541] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[2]' - status (0)
	[   41.805572] no flags found for (null)
	[   41.805816] nokia-modem n900-modem: GPIO lookup for consumer (null)
	[   41.805816] nokia-modem n900-modem: using device tree for GPIO lookup
	[   41.805969] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[3]' - status (0)
	[   41.805999] no flags found for (null)

Not nice.

Also, I now realize there is a forced nokia_modem Kconfig dependency
to cmt_speech. Before I was able to use data connection only, so why
now force this dependency to cmt_speech?

A.

Re: v4.1-rc1 & N900: annoying Nokia modem spam

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

Hi,

On Sat, May 02, 2015 at 09:43:37PM +0300, Aaro Koskinen wrote:
> With v4.1-rc1, after loading nokia_modem I get the following endless
> log spam until I load cmt_speech (for whatever reason it does not get
> modprobed automatically with busybox modprobe):

So ssi-protocol is loaded automatically and cmt-speech is not?
That's strange, since they are requested the same way.

> 	[   41.626983] nokia-modem n900-modem: Missing cmt-speech driver
> 	[   41.804565] nokia-modem n900-modem: GPIO lookup for consumer (null)
> 	[   41.804626] nokia-modem n900-modem: using device tree for GPIO lookup
> 	[   41.804687] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[0]' - status (0)
> 	[   41.804718] no flags found for (null)
> 	[   41.805023] nokia-modem n900-modem: GPIO lookup for consumer (null)
> 	[   41.805023] nokia-modem n900-modem: using device tree for GPIO lookup
> 	[   41.805145] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[1]' - status (0)
> 	[   41.805145] no flags found for (null)
> 	[   41.805389] nokia-modem n900-modem: GPIO lookup for consumer (null)
> 	[   41.805419] nokia-modem n900-modem: using device tree for GPIO lookup
> 	[   41.805541] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[2]' - status (0)
> 	[   41.805572] no flags found for (null)
> 	[   41.805816] nokia-modem n900-modem: GPIO lookup for consumer (null)
> 	[   41.805816] nokia-modem n900-modem: using device tree for GPIO lookup
> 	[   41.805969] of_get_named_gpiod_flags: parsed 'gpios' property of node '/ocp/ssi-controller@48058000/ssi-port@4805a000/hsi-client[3]' - status (0)
> 	[   41.805999] no flags found for (null)
>
> Not nice.

Everything (except of the first line) is because you have
CONFIG_DEBUG_GPIO enabled and nokia-modem returns -EPROBE_DEFER
until all drivers are available, so GPIOs will be acquired again
the next time the drivers tries to probe.

> Also, I now realize there is a forced nokia_modem Kconfig dependency
> to cmt_speech. Before I was able to use data connection only, so why
> now force this dependency to cmt_speech?

I assumed, that there is no real usecase for not building cmt-speech
together with nokia-modem. I think CMT_SPEECH and SSI_PROTOCOL
should actually be hidden and autoselected by NOKIA_MODEM.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: v4.1-rc1 & N900: annoying Nokia modem spam

[Aaro Koskinen]

Hi,

On Sun, May 03, 2015 at 02:29:38AM +0200, Sebastian Reichel wrote:
> On Sat, May 02, 2015 at 09:43:37PM +0300, Aaro Koskinen wrote:
> > With v4.1-rc1, after loading nokia_modem I get the following endless
> > log spam until I load cmt_speech (for whatever reason it does not get
> > modprobed automatically with busybox modprobe):
> 
> So ssi-protocol is loaded automatically and cmt-speech is not?
> That's strange, since they are requested the same way.

Hmm, right. This seems to be issue in my initramfs setup.

> > 	[   41.626983] nokia-modem n900-modem: Missing cmt-speech driver
>
> Everything (except of the first line) is because you have
> CONFIG_DEBUG_GPIO enabled and nokia-modem returns -EPROBE_DEFER
> until all drivers are available, so GPIOs will be acquired again
> the next time the drivers tries to probe.

Actually only the first line (Missing cmt-speech driver) was the annoying
part - because it's an error log it reached the frame buffer and there
was so many of them that everything else scrolled off...

A.

[PATCH] HSI: nokia-modem: Reduce missing driver message to debug level

[Sebastian Reichel]

Reduce message priority from dev_err to dev_dbg for missing cmt-speech
or ssi-protocol drivers, since they will be probed again and it may
result in spamming the boot log.

Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/hsi/clients/nokia-modem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index bbb1923..f50d110 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -208,7 +208,7 @@ static int nokia_modem_probe(struct device *dev)
 
 	err = device_attach(&modem->ssi_protocol->device);
 	if (err == 0) {
-		dev_err(dev, "Missing ssi-protocol driver\n");
+		dev_dbg(dev, "Missing ssi-protocol driver\n");
 		err = -EPROBE_DEFER;
 		goto error3;
 	} else if (err < 0) {
@@ -231,7 +231,7 @@ static int nokia_modem_probe(struct device *dev)
 
 	err = device_attach(&modem->cmt_speech->device);
 	if (err == 0) {
-		dev_err(dev, "Missing cmt-speech driver\n");
+		dev_dbg(dev, "Missing cmt-speech driver\n");
 		err = -EPROBE_DEFER;
 		goto error4;
 	} else if (err < 0) {
-- 
2.1.4