From: Stephen Boyd <sboyd@codeaurora.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Mike Turquette <mturquette@linaro.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name
Date: Wed, 6 May 2015 00:45:18 -0700 [thread overview]
Message-ID: <20150506074518.GA11126@codeaurora.org> (raw)
In-Reply-To: <1430893716-1825-1-git-send-email-k.kozlowski@samsung.com>
On 05/06, Krzysztof Kozlowski wrote:
> In documentation the "assigned-clock-parents" name was used when
> describing the "assigned-clock-rates" property.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Looks right. The whole sentence could use some work though.
> Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> index 06fc6d541c89..bf5b0414dc17 100644
> --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
> +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
> @@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
> and clock frequencies. Such a configuration can be specified in a device tree
> node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
> properties. The assigned-clock-parents property should contain a list of parent
> -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
> +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
> property the list of assigned clock frequency values - corresponding to clocks
This half-sentence:
The assigned-clock-ratse property the list of assigned
clock frequency values
doesn't read correctly. Maybe the whole thing should be rewritten
as:
The assigned-clock-parents property should contain a list
of parent clocks in the form of a phandle and clock
specifier pair and the assigned-clock-rates property
should contain a list of frequencies in Hz. Both these
properties should correspond to the clocks listed in the
assigned-clocks property.
> listed in the assigned-clocks property.
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-06 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 6:28 [PATCH] clk: bindings: Fix assigned-clock-rates property name Krzysztof Kozlowski
2015-05-06 7:45 ` Stephen Boyd [this message]
2015-05-06 8:10 ` Krzysztof Kozlowski
2015-05-06 8:10 ` Krzysztof Kozlowski
2015-05-08 6:51 ` [PATCH] clk: bindings: Fix assigned-clock-rates description Stephen Boyd
2015-05-08 6:51 ` Stephen Boyd
2015-05-13 19:43 ` Stephen Boyd
2015-05-13 19:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506074518.GA11126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.