From: Dan Carpenter <dan.carpenter@oracle.com>
To: n-horiguchi@ah.jp.nec.com
Cc: linux-mm@kvack.org
Subject: Re: mm: memory-hotplug: enable memory hotplug to handle hugepage
Date: Mon, 11 May 2015 14:29:24 +0300 [thread overview]
Message-ID: <20150511112924.GM16501@mwanda> (raw)
In-Reply-To: <20150511111748.GA20660@mwanda>
On Mon, May 11, 2015 at 02:17:48PM +0300, Dan Carpenter wrote:
> Hello Naoya Horiguchi,
>
> The patch c8721bbbdd36: "mm: memory-hotplug: enable memory hotplug to
> handle hugepage" from Sep 11, 2013, leads to the following static
> checker warning:
>
> mm/hugetlb.c:1203 dissolve_free_huge_pages()
> warn: potential right shift more than type allows '9,18,64'
>
> mm/hugetlb.c
> 1189 void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn)
> 1190 {
> 1191 unsigned int order = 8 * sizeof(void *);
> ^^^^^^^^^^^^^^^^^^
> Let's say order is 64.
Actually, the 64 here is just chosen to be an impossibly high number
isn't it? It's a bit complicated to understand that at first glance.
regards,
dan carpenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-11 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 11:17 mm: memory-hotplug: enable memory hotplug to handle hugepage Dan Carpenter
2015-05-11 11:29 ` Dan Carpenter [this message]
2015-05-11 23:56 ` Naoya Horiguchi
2015-05-11 23:54 ` Naoya Horiguchi
2015-05-12 8:43 ` Dan Carpenter
2015-05-12 9:04 ` Naoya Horiguchi
2015-05-12 9:13 ` Dan Carpenter
2015-05-12 9:16 ` Naoya Horiguchi
2015-05-12 9:20 ` [PATCH] mm/hugetlb: initialize order with UINT_MAX in dissolve_free_huge_pages() Naoya Horiguchi
2015-05-12 23:15 ` Andrew Morton
2015-05-13 1:44 ` Naoya Horiguchi
2015-05-13 20:55 ` Andrew Morton
2015-05-14 6:15 ` [PATCH] mm/hugetlb: introduce minimum hugepage order Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511112924.GM16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.