From: Dan Carpenter <dan.carpenter@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: mm: memory-hotplug: enable memory hotplug to handle hugepage
Date: Tue, 12 May 2015 11:43:39 +0300 [thread overview]
Message-ID: <20150512084339.GN16501@mwanda> (raw)
In-Reply-To: <20150511235443.GA8513@hori1.linux.bs1.fc.nec.co.jp>
On Mon, May 11, 2015 at 11:54:44PM +0000, Naoya Horiguchi wrote:
> @@ -1086,7 +1086,8 @@ static void dissolve_free_huge_page(struct page *page)
> */
> void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn)
> {
> - unsigned int order = 8 * sizeof(void *);
> + /* Initialized to "high enough" value which is capped later */
> + unsigned int order = 8 * sizeof(void *) - 1;
Why not use UINT_MAX? It's more clear that it's not valid that way.
Otherwise doing a complicated calculation it makes it seem like we will
use the variable.
regards,
dan carpenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-12 8:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 11:17 mm: memory-hotplug: enable memory hotplug to handle hugepage Dan Carpenter
2015-05-11 11:29 ` Dan Carpenter
2015-05-11 23:56 ` Naoya Horiguchi
2015-05-11 23:54 ` Naoya Horiguchi
2015-05-12 8:43 ` Dan Carpenter [this message]
2015-05-12 9:04 ` Naoya Horiguchi
2015-05-12 9:13 ` Dan Carpenter
2015-05-12 9:16 ` Naoya Horiguchi
2015-05-12 9:20 ` [PATCH] mm/hugetlb: initialize order with UINT_MAX in dissolve_free_huge_pages() Naoya Horiguchi
2015-05-12 23:15 ` Andrew Morton
2015-05-13 1:44 ` Naoya Horiguchi
2015-05-13 20:55 ` Andrew Morton
2015-05-14 6:15 ` [PATCH] mm/hugetlb: introduce minimum hugepage order Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512084339.GN16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.