* [PATCH] clk: mediatek: Initialize clk flags
@ 2015-05-15 6:22 ` Ricky Liang
0 siblings, 0 replies; 6+ messages in thread
From: Ricky Liang @ 2015-05-15 6:22 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Ricky Liang, Matthias Brugger, James Liao, Sascha Hauer,
Henry Chen, open list:COMMON CLK FRAMEWORK, open list,
moderated list:ARM/Mediatek SoC...,
moderated list:ARM/Mediatek SoC...
The variable init (struct clk_init_data) is allocated on the stack.
We weren't initializing the .flags field, so it contains random junk,
which can cause all kinds of interesting issues when the flags are
parsed by clk_register.
The best solution seems to just pass on the flags passed in to our
clk_register wrappers.
Signed-off-by: Ricky Liang <jcliang@chromium.org>
---
drivers/clk/mediatek/clk-pll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
index 66154ca..72fe307 100644
--- a/drivers/clk/mediatek/clk-pll.c
+++ b/drivers/clk/mediatek/clk-pll.c
@@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
init.ops = &mtk_pll_ops;
init.parent_names = &parent_name;
init.num_parents = 1;
+ init.flags = data->flags;
clk = clk_register(NULL, &pll->hw);
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] clk: mediatek: Initialize clk flags
@ 2015-05-15 6:22 ` Ricky Liang
0 siblings, 0 replies; 6+ messages in thread
From: Ricky Liang @ 2015-05-15 6:22 UTC (permalink / raw)
To: linux-arm-kernel
The variable init (struct clk_init_data) is allocated on the stack.
We weren't initializing the .flags field, so it contains random junk,
which can cause all kinds of interesting issues when the flags are
parsed by clk_register.
The best solution seems to just pass on the flags passed in to our
clk_register wrappers.
Signed-off-by: Ricky Liang <jcliang@chromium.org>
---
drivers/clk/mediatek/clk-pll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
index 66154ca..72fe307 100644
--- a/drivers/clk/mediatek/clk-pll.c
+++ b/drivers/clk/mediatek/clk-pll.c
@@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
init.ops = &mtk_pll_ops;
init.parent_names = &parent_name;
init.num_parents = 1;
+ init.flags = data->flags;
clk = clk_register(NULL, &pll->hw);
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] clk: mediatek: Initialize clk flags
@ 2015-05-15 6:22 ` Ricky Liang
0 siblings, 0 replies; 6+ messages in thread
From: Ricky Liang @ 2015-05-15 6:22 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Ricky Liang, Matthias Brugger, James Liao, Sascha Hauer,
Henry Chen, open list:COMMON CLK FRAMEWORK, open list,
moderated list:ARM/Mediatek SoC...,
moderated list:ARM/Mediatek SoC...
The variable init (struct clk_init_data) is allocated on the stack.
We weren't initializing the .flags field, so it contains random junk,
which can cause all kinds of interesting issues when the flags are
parsed by clk_register.
The best solution seems to just pass on the flags passed in to our
clk_register wrappers.
Signed-off-by: Ricky Liang <jcliang@chromium.org>
---
drivers/clk/mediatek/clk-pll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
index 66154ca..72fe307 100644
--- a/drivers/clk/mediatek/clk-pll.c
+++ b/drivers/clk/mediatek/clk-pll.c
@@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
init.ops = &mtk_pll_ops;
init.parent_names = &parent_name;
init.num_parents = 1;
+ init.flags = data->flags;
clk = clk_register(NULL, &pll->hw);
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: mediatek: Initialize clk flags
2015-05-15 6:22 ` Ricky Liang
(?)
@ 2015-05-15 18:37 ` Stephen Boyd
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2015-05-15 18:37 UTC (permalink / raw)
To: Ricky Liang
Cc: Mike Turquette, Matthias Brugger, James Liao, Sascha Hauer,
Henry Chen, open list:COMMON CLK FRAMEWORK, open list,
moderated list:ARM/Mediatek SoC...,
moderated list:ARM/Mediatek SoC...
On 05/15, Ricky Liang wrote:
> diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
> index 66154ca..72fe307 100644
> --- a/drivers/clk/mediatek/clk-pll.c
> +++ b/drivers/clk/mediatek/clk-pll.c
> @@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
> init.ops = &mtk_pll_ops;
> init.parent_names = &parent_name;
> init.num_parents = 1;
> + init.flags = data->flags;
Wrong? It looks like plls[] in drivers/clk/mediatek/clk-mt8135.c
is putting mtk specific clock flags in this structure member.
How about initializing the structure to { } instead? That way if
we ever add more structure members we don't have to detect the
landmine laid here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: mediatek: Initialize clk flags
@ 2015-05-15 18:37 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2015-05-15 18:37 UTC (permalink / raw)
To: Ricky Liang
Cc: Mike Turquette, Matthias Brugger, James Liao, Sascha Hauer,
Henry Chen, open list:COMMON CLK FRAMEWORK, open list,
moderated list:ARM/Mediatek SoC...,
moderated list:ARM/Mediatek SoC...
On 05/15, Ricky Liang wrote:
> diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
> index 66154ca..72fe307 100644
> --- a/drivers/clk/mediatek/clk-pll.c
> +++ b/drivers/clk/mediatek/clk-pll.c
> @@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
> init.ops = &mtk_pll_ops;
> init.parent_names = &parent_name;
> init.num_parents = 1;
> + init.flags = data->flags;
Wrong? It looks like plls[] in drivers/clk/mediatek/clk-mt8135.c
is putting mtk specific clock flags in this structure member.
How about initializing the structure to { } instead? That way if
we ever add more structure members we don't have to detect the
landmine laid here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clk: mediatek: Initialize clk flags
@ 2015-05-15 18:37 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2015-05-15 18:37 UTC (permalink / raw)
To: linux-arm-kernel
On 05/15, Ricky Liang wrote:
> diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c
> index 66154ca..72fe307 100644
> --- a/drivers/clk/mediatek/clk-pll.c
> +++ b/drivers/clk/mediatek/clk-pll.c
> @@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data,
> init.ops = &mtk_pll_ops;
> init.parent_names = &parent_name;
> init.num_parents = 1;
> + init.flags = data->flags;
Wrong? It looks like plls[] in drivers/clk/mediatek/clk-mt8135.c
is putting mtk specific clock flags in this structure member.
How about initializing the structure to { } instead? That way if
we ever add more structure members we don't have to detect the
landmine laid here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-15 18:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 6:22 [PATCH] clk: mediatek: Initialize clk flags Ricky Liang
2015-05-15 6:22 ` Ricky Liang
2015-05-15 6:22 ` Ricky Liang
2015-05-15 18:37 ` Stephen Boyd
2015-05-15 18:37 ` Stephen Boyd
2015-05-15 18:37 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.