* Re: [PATCH 1/1] Fixed coding style issues
2015-05-16 0:11 [PATCH 1/1] Fixed coding style issues Pedro Marzo Perez
@ 2015-05-15 23:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-05-15 23:56 UTC (permalink / raw)
To: Pedro Marzo Perez
Cc: navyasri.tech, dilekuzulmez, joe, haticeerturk27,
senija.stanojevic, devel, linux-kernel
On Sat, May 16, 2015 at 02:11:06AM +0200, Pedro Marzo Perez wrote:
> From: pmarzo <marzo.pedro@gmail.com>
This line doesn't match your from: line in your email client, or the
line below in the signed-off-by part.
Also, please make your subject a bit more descriptive.
>
> This patch just fixes some errors reported by checkpatch.pl script
What "errors" were reported and fixed?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] Fixed coding style issues
@ 2015-05-16 0:11 Pedro Marzo Perez
2015-05-15 23:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Pedro Marzo Perez @ 2015-05-16 0:11 UTC (permalink / raw)
To: gregkh, navyasri.tech, dilekuzulmez, joe, haticeerturk27,
senija.stanojevic
Cc: devel, linux-kernel, pmarzo
From: pmarzo <marzo.pedro@gmail.com>
This patch just fixes some errors reported by checkpatch.pl script
Signed-off-by: Pedro Marzo Perez <marzo.pedro@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
index 0a17f84..33b7b4d 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
@@ -48,15 +48,13 @@ static void *prism2_wep_init(int keyidx)
priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->tx_tfm)) {
- pr_debug("ieee80211_crypt_wep: could not allocate "
- "crypto API arc4\n");
+ pr_debug("ieee80211_crypt_wep: could not allocate crypto API arc4\n");
priv->tx_tfm = NULL;
goto fail;
}
priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->rx_tfm)) {
- pr_debug("ieee80211_crypt_wep: could not allocate "
- "crypto API arc4\n");
+ pr_debug("ieee80211_crypt_wep: could not allocate crypto API arc4\n");
priv->rx_tfm = NULL;
goto fail;
}
@@ -142,9 +140,7 @@ static int prism2_wep_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
/* Copy rest of the WEP key (the secret part) */
memcpy(key + 3, wep->key, wep->key_len);
- if (!tcb_desc->bHwSec)
- {
-
+ if (!tcb_desc->bHwSec) {
/* Append little-endian CRC32 and encrypt it to produce ICV */
crc = ~crc32_le(~0, pos, len);
icv = skb_put(skb, 4);
@@ -201,8 +197,7 @@ static int prism2_wep_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
/* Apply RC4 to data and compute CRC32 over decrypted data */
plen = skb->len - hdr_len - 8;
- if (!tcb_desc->bHwSec)
- {
+ if (!tcb_desc->bHwSec) {
crypto_blkcipher_setkey(wep->rx_tfm, key, klen);
sg_init_one(&sg, pos, plen+4);
@@ -293,6 +288,5 @@ void __exit ieee80211_crypto_wep_exit(void)
void ieee80211_wep_null(void)
{
-// printk("============>%s()\n", __func__);
- return;
+ /*printk("============>%s()\n", __func__);*/
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-15 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-16 0:11 [PATCH 1/1] Fixed coding style issues Pedro Marzo Perez
2015-05-15 23:56 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.