All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: David Miller <davem@redhat.com>,
	alexander.h.duyck@redhat.com, netdev@vger.kernel.org,
	steffen.klassert@secunet.com, tgraf@suug.ch
Subject: Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path
Date: Sat, 16 May 2015 20:34:58 +0800	[thread overview]
Message-ID: <20150516123457.GB683@gondor.apana.org.au> (raw)
In-Reply-To: <555645A3.6010509@gmail.com>

On Fri, May 15, 2015 at 12:14:43PM -0700, Alexander Duyck wrote:
>
> >Yeah, this mark handling via tunnel->parms.o_key looks not so good.
> 
> So is there any recommendations for an alternative to make it so
> that the ipsec endpoint is identified as needing to be encrypted or
> decrypted?  If needed I could probably take a day or two to try and
> address it as I still have a few other minor things I want to try
> and fix such as the MTU configuration for vti/vti6.

I'd like to hear from Steffen as to whether there is anything
in userspace that relies on the mark being used in this way by
vti.  If not it should be easy to get rid of it and use some
field that's not exposed to user-space.  If there is then this
would be tricky to resolve.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2015-05-16 12:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  2:04 [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path Alexander Duyck
2015-05-14  3:28 ` Herbert Xu
2015-05-14  6:14   ` Alexander Duyck
2015-05-14  6:26     ` Herbert Xu
2015-05-15 16:37       ` David Miller
2015-05-15 19:14         ` Alexander Duyck
2015-05-16 12:34           ` Herbert Xu [this message]
2015-05-16 21:13             ` David Miller
2015-05-18  7:04               ` Steffen Klassert
2015-05-18  8:31                 ` Herbert Xu
2015-05-18  8:38                   ` Steffen Klassert
2015-05-18  8:59                     ` Herbert Xu
2015-05-18 10:30                       ` Steffen Klassert
2015-05-18 10:33                         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150516123457.GB683@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=davem@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.