From: Herbert Xu <herbert@gondor.apana.org.au>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David Miller <davem@davemloft.net>,
alexander.duyck@gmail.com, alexander.h.duyck@redhat.com,
netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path
Date: Mon, 18 May 2015 16:31:21 +0800 [thread overview]
Message-ID: <20150518083121.GA18195@gondor.apana.org.au> (raw)
In-Reply-To: <20150518070427.GC8928@secunet.com>
On Mon, May 18, 2015 at 09:04:27AM +0200, Steffen Klassert wrote:
>
> The policy and state mark must match the tunnels i_key/o_key
> on lookup. It is not required to set skb->mark, but we have
> to make sure to use the tunnels gre keys as the mark when we
> do a policy or state lookup.
So is it possible to restore the original mark after the lookups?
At least that way it is still possible to use the mark before and
after the encapsulation.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-05-18 8:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 2:04 [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path Alexander Duyck
2015-05-14 3:28 ` Herbert Xu
2015-05-14 6:14 ` Alexander Duyck
2015-05-14 6:26 ` Herbert Xu
2015-05-15 16:37 ` David Miller
2015-05-15 19:14 ` Alexander Duyck
2015-05-16 12:34 ` Herbert Xu
2015-05-16 21:13 ` David Miller
2015-05-18 7:04 ` Steffen Klassert
2015-05-18 8:31 ` Herbert Xu [this message]
2015-05-18 8:38 ` Steffen Klassert
2015-05-18 8:59 ` Herbert Xu
2015-05-18 10:30 ` Steffen Klassert
2015-05-18 10:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518083121.GA18195@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.