From: Viresh Kumar <viresh.kumar@linaro.org> To: Stephen Boyd <sboyd@codeaurora.org> Cc: Rafael Wysocki <rjw@rjwysocki.net>, rob.herring@linaro.org, arnd.bergmann@linaro.org, nm@ti.com, broonie@kernel.org, mike.turquette@linaro.org, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, grant.likely@linaro.org, olof@lixom.net, Sudeep.Holla@arm.com, devicetree@vger.kernel.org, viswanath.puttagunta@linaro.org, l.stach@pengutronix.de, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com, kesavan.abhilash@gmail.com, khilman@linaro.org, santosh.shilimkar@oracle.com Subject: Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Date: Wed, 20 May 2015 07:37:15 +0530 [thread overview] Message-ID: <20150520020715.GA6465@linux> (raw) In-Reply-To: <555BDA7C.7020506@codeaurora.org> On 19-05-15, 17:51, Stephen Boyd wrote: > This looks like it covers my usecases. I'm not sure if I'm going to put > all of this data in DT because of the philosophical question regarding > what should be in DT and the technical decisions that some platforms I'm > working on have made to encode parts of the OPPs in fuses, but at least > the binding looks to support all the scenarios I have today. Thanks. > > +Required properties: > > +- opp-khz: Frequency in kHz > > Can this be in Hz? I thought there were some problems with kHz and Hz > before where we wanted to make this into Hz so that rounding problems > don't arise? Yeah, good point. > Also I wonder if all properties should be optional? I don't have this > scenario today, but perhaps the frequencies could be encoded in fuses, > but the voltages wouldn't be and so we might want to read out the > frequencies for a fixed set of voltages. Of course, if there's nothing > in the OPP node at all, it's not very useful, so perhaps some statement > that at least one of the frequency/voltage/amperage properties should be > present. I am not sure. What we are trying to do (fill partially in DT and partially in platform), is a trick and not the right use of bindings. Ideally whatever is passed in DT should be complete by itself and doesn't require platform to tweak it (which it can't). For example, the cpufreq-dt driver will try to initialize OPPs from the DT directly and wouldn't know about the platform tweaks. That can work eventually as platform will add OPPs for the same bindings before cpufreq driver will try to do, but that's a trick. And then its all about frequency in the first place, and so marking that optional looks wrong. Probably not the right use of these bindings. > > + Entries for multiple regulators must be present in the same order as > > + regulators are specified in device's DT node. If few regulators don't provide > > + capability to configure current, then values for then should be marked as > > s/then/them/ Thanks. But this part is already re-written and doesn't have this issue anymore. > Please put some space between properties so they can be found quickly: Sure, thanks. -- viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Date: Wed, 20 May 2015 07:37:15 +0530 [thread overview] Message-ID: <20150520020715.GA6465@linux> (raw) In-Reply-To: <555BDA7C.7020506@codeaurora.org> On 19-05-15, 17:51, Stephen Boyd wrote: > This looks like it covers my usecases. I'm not sure if I'm going to put > all of this data in DT because of the philosophical question regarding > what should be in DT and the technical decisions that some platforms I'm > working on have made to encode parts of the OPPs in fuses, but at least > the binding looks to support all the scenarios I have today. Thanks. > > +Required properties: > > +- opp-khz: Frequency in kHz > > Can this be in Hz? I thought there were some problems with kHz and Hz > before where we wanted to make this into Hz so that rounding problems > don't arise? Yeah, good point. > Also I wonder if all properties should be optional? I don't have this > scenario today, but perhaps the frequencies could be encoded in fuses, > but the voltages wouldn't be and so we might want to read out the > frequencies for a fixed set of voltages. Of course, if there's nothing > in the OPP node at all, it's not very useful, so perhaps some statement > that at least one of the frequency/voltage/amperage properties should be > present. I am not sure. What we are trying to do (fill partially in DT and partially in platform), is a trick and not the right use of bindings. Ideally whatever is passed in DT should be complete by itself and doesn't require platform to tweak it (which it can't). For example, the cpufreq-dt driver will try to initialize OPPs from the DT directly and wouldn't know about the platform tweaks. That can work eventually as platform will add OPPs for the same bindings before cpufreq driver will try to do, but that's a trick. And then its all about frequency in the first place, and so marking that optional looks wrong. Probably not the right use of these bindings. > > + Entries for multiple regulators must be present in the same order as > > + regulators are specified in device's DT node. If few regulators don't provide > > + capability to configure current, then values for then should be marked as > > s/then/them/ Thanks. But this part is already re-written and doesn't have this issue anymore. > Please put some space between properties so they can be found quickly: Sure, thanks. -- viresh
next prev parent reply other threads:[~2015-05-20 2:07 UTC|newest] Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-30 12:07 [PATCH V4 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar 2015-04-30 12:07 ` Viresh Kumar [not found] ` <cover.1430394884.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-04-30 12:07 ` [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Viresh Kumar 2015-04-30 12:07 ` Viresh Kumar [not found] ` <d225e73f183e01fa0b71e4b9248b6a19a3f7d697.1430394884.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-05-04 12:12 ` Mark Brown 2015-05-04 12:12 ` Mark Brown 2015-05-05 10:48 ` Viresh Kumar 2015-05-05 10:48 ` Viresh Kumar 2015-05-05 10:57 ` Mark Brown 2015-05-05 10:57 ` Mark Brown [not found] ` <20150505105714.GA22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2015-05-05 11:43 ` Viresh Kumar 2015-05-05 11:43 ` Viresh Kumar 2015-05-05 17:12 ` Mark Brown 2015-05-05 17:12 ` Mark Brown 2015-05-06 6:53 ` Viresh Kumar 2015-05-06 6:53 ` Viresh Kumar 2015-05-07 5:52 ` Stephen Boyd 2015-05-07 5:52 ` Stephen Boyd 2015-05-07 11:02 ` Mark Brown 2015-05-07 11:02 ` Mark Brown 2015-05-07 21:18 ` Stephen Boyd 2015-05-07 21:18 ` Stephen Boyd 2015-05-07 22:18 ` Mark Brown 2015-05-07 22:18 ` Mark Brown [not found] ` <20150507221842.GW22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2015-05-08 6:47 ` Viresh Kumar 2015-05-08 6:47 ` Viresh Kumar 2015-05-08 10:58 ` Mark Brown 2015-05-08 10:58 ` Mark Brown 2015-05-08 11:01 ` Viresh Kumar 2015-05-08 11:01 ` Viresh Kumar 2015-05-11 1:07 ` Nishanth Menon 2015-05-11 1:07 ` Nishanth Menon 2015-05-12 5:20 ` Viresh Kumar 2015-05-12 5:20 ` Viresh Kumar 2015-05-12 19:01 ` Michael Turquette 2015-05-12 19:01 ` Michael Turquette 2015-05-12 19:14 ` Nishanth Menon 2015-05-12 19:14 ` Nishanth Menon 2015-05-12 19:41 ` Mark Brown 2015-05-12 19:41 ` Mark Brown 2015-05-12 19:57 ` Nishanth Menon 2015-05-12 19:57 ` Nishanth Menon 2015-05-13 11:54 ` Mark Brown 2015-05-13 11:54 ` Mark Brown [not found] ` <20150513115422.GQ3066-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2015-05-13 14:24 ` Nishanth Menon 2015-05-13 14:24 ` Nishanth Menon 2015-05-13 15:07 ` Mark Brown 2015-05-13 15:07 ` Mark Brown 2015-05-13 15:43 ` Nishanth Menon 2015-05-13 15:43 ` Nishanth Menon 2015-05-07 12:13 ` Viresh Kumar 2015-05-07 12:13 ` Viresh Kumar 2015-05-07 21:30 ` Stephen Boyd 2015-05-07 21:30 ` Stephen Boyd 2015-05-08 6:49 ` Viresh Kumar 2015-05-08 6:49 ` Viresh Kumar 2015-05-11 1:02 ` Nishanth Menon 2015-05-11 1:02 ` Nishanth Menon 2015-05-12 5:16 ` Viresh Kumar 2015-05-12 5:16 ` Viresh Kumar 2015-05-12 16:04 ` Nishanth Menon 2015-05-12 16:04 ` Nishanth Menon 2015-05-13 5:05 ` Viresh Kumar 2015-05-13 5:05 ` Viresh Kumar 2015-05-13 15:00 ` Nishanth Menon 2015-05-13 15:00 ` Nishanth Menon 2015-05-13 15:16 ` Mark Brown 2015-05-13 15:16 ` Mark Brown 2015-05-13 16:14 ` Nishanth Menon 2015-05-13 16:14 ` Nishanth Menon 2015-05-13 16:21 ` Mark Brown 2015-05-13 16:21 ` Mark Brown 2015-05-13 16:34 ` Nishanth Menon 2015-05-13 16:34 ` Nishanth Menon 2015-05-12 16:19 ` Felipe Balbi 2015-05-12 16:19 ` Felipe Balbi 2015-05-13 4:45 ` Viresh Kumar 2015-05-13 4:45 ` Viresh Kumar 2015-05-12 21:42 ` Michael Turquette 2015-05-12 21:42 ` Michael Turquette 2015-05-13 8:55 ` Viresh Kumar 2015-05-13 8:55 ` Viresh Kumar 2015-05-13 11:03 ` Mark Brown 2015-05-13 11:03 ` Mark Brown 2015-05-14 0:32 ` Michael Turquette 2015-05-14 0:32 ` Michael Turquette [not found] ` <CAKohpokeKtcJdrBcPZBBPR2zfJgpvuM_=wRaX5q1Uto2qx1oHQ@mail.gmail.com> 2015-05-15 14:15 ` Viresh Kumar 2015-05-15 14:15 ` Viresh Kumar 2015-05-15 15:43 ` Nishanth Menon 2015-05-15 15:43 ` Nishanth Menon 2015-05-15 17:27 ` Rob Herring 2015-05-15 17:27 ` Rob Herring 2015-05-21 6:02 ` Nishanth Menon 2015-05-21 6:02 ` Nishanth Menon 2015-05-22 14:04 ` Viresh Kumar 2015-05-22 14:04 ` Viresh Kumar 2015-05-22 16:04 ` Rob Herring 2015-05-22 16:04 ` Rob Herring 2015-05-22 17:42 ` Nishanth Menon 2015-05-22 17:42 ` Nishanth Menon 2015-05-26 5:25 ` Viresh Kumar 2015-05-26 5:25 ` Viresh Kumar 2015-05-20 0:51 ` Stephen Boyd 2015-05-20 0:51 ` Stephen Boyd 2015-05-20 2:07 ` Viresh Kumar [this message] 2015-05-20 2:07 ` Viresh Kumar 2015-05-20 19:39 ` Stephen Boyd 2015-05-20 19:39 ` Stephen Boyd 2015-05-21 4:33 ` Viresh Kumar 2015-05-21 4:33 ` Viresh Kumar 2015-05-25 11:59 ` Viresh Kumar 2015-05-25 11:59 ` Viresh Kumar 2015-04-30 12:08 ` [PATCH V4 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar 2015-04-30 12:08 ` Viresh Kumar 2015-05-12 16:09 ` Nishanth Menon 2015-05-12 16:09 ` Nishanth Menon 2015-05-13 4:41 ` Viresh Kumar 2015-05-13 4:41 ` Viresh Kumar 2015-05-20 0:52 ` Stephen Boyd 2015-05-20 0:52 ` Stephen Boyd 2015-04-30 12:08 ` [PATCH V4 3/3] OPP: Add 'opp-next' in operating-points-v2 bindings Viresh Kumar 2015-04-30 12:08 ` Viresh Kumar 2015-05-12 21:47 ` Michael Turquette 2015-05-12 21:47 ` Michael Turquette
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150520020715.GA6465@linux \ --to=viresh.kumar@linaro.org \ --cc=Sudeep.Holla@arm.com \ --cc=arnd.bergmann@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=kesavan.abhilash@gmail.com \ --cc=khilman@linaro.org \ --cc=l.stach@pengutronix.de \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mike.turquette@linaro.org \ --cc=nm@ti.com \ --cc=olof@lixom.net \ --cc=rjw@rjwysocki.net \ --cc=rob.herring@linaro.org \ --cc=santosh.shilimkar@oracle.com \ --cc=sboyd@codeaurora.org \ --cc=ta.omasab@gmail.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=viswanath.puttagunta@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.