All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org,
	Michal Simek <michal.simek@xilinx.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function
Date: Wed, 20 May 2015 07:23:58 -0700	[thread overview]
Message-ID: <20150520142358.GS31550@xsjsorenbubuntu> (raw)
In-Reply-To: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On Wed, 2015-05-20 at 05:42PM +0900, Masahiro Yamada wrote:
> 
> I sent the previous one to linux-serial by mistake.
> I am resending to linux-gpio, dropping linux-serial.
> Sorry for noise.
> 
> 
> 
> Masahiro Yamada (2):
>   pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro
>   pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL

For the series:
Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

I'm not sure how severe the impact of these bugs is. It looks like the
the current driver could corrupt the register for MIO pin0, am I right?
It may be a good ides to add
  Fixes: add958cee967 "pinctrl: Add driver for Zynq"
(I suspect that bug is there from the beginning) and ask Linus to
consider this for stable.

	Thanks,
	Sören

WARNING: multiple messages have this Message-ID (diff)
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: <linux-gpio@vger.kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function
Date: Wed, 20 May 2015 07:23:58 -0700	[thread overview]
Message-ID: <20150520142358.GS31550@xsjsorenbubuntu> (raw)
In-Reply-To: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On Wed, 2015-05-20 at 05:42PM +0900, Masahiro Yamada wrote:
> 
> I sent the previous one to linux-serial by mistake.
> I am resending to linux-gpio, dropping linux-serial.
> Sorry for noise.
> 
> 
> 
> Masahiro Yamada (2):
>   pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro
>   pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL

For the series:
Reviewed-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

I'm not sure how severe the impact of these bugs is. It looks like the
the current driver could corrupt the register for MIO pin0, am I right?
It may be a good ides to add
  Fixes: add958cee967 "pinctrl: Add driver for Zynq"
(I suspect that bug is there from the beginning) and ask Linus to
consider this for stable.

	Thanks,
	Sören

WARNING: multiple messages have this Message-ID (diff)
From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function
Date: Wed, 20 May 2015 07:23:58 -0700	[thread overview]
Message-ID: <20150520142358.GS31550@xsjsorenbubuntu> (raw)
In-Reply-To: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On Wed, 2015-05-20 at 05:42PM +0900, Masahiro Yamada wrote:
> 
> I sent the previous one to linux-serial by mistake.
> I am resending to linux-gpio, dropping linux-serial.
> Sorry for noise.
> 
> 
> 
> Masahiro Yamada (2):
>   pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro
>   pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL

For the series:
Reviewed-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>

I'm not sure how severe the impact of these bugs is. It looks like the
the current driver could corrupt the register for MIO pin0, am I right?
It may be a good ides to add
  Fixes: add958cee967 "pinctrl: Add driver for Zynq"
(I suspect that bug is there from the beginning) and ask Linus to
consider this for stable.

	Thanks,
	S?ren

  parent reply	other threads:[~2015-05-20 14:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  8:42 [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function Masahiro Yamada
2015-05-20  8:42 ` Masahiro Yamada
2015-05-20  8:42 ` [RESEND PATCH 1/2] pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro Masahiro Yamada
2015-05-20  8:42   ` Masahiro Yamada
2015-06-01 12:44   ` Linus Walleij
2015-06-01 12:44     ` Linus Walleij
2015-06-01 12:44     ` Linus Walleij
2015-05-20  8:42 ` [RESEND PATCH 2/2] pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL Masahiro Yamada
2015-05-20  8:42   ` [RESEND PATCH 2/2] pinctrl: zynq: fix offset address for {SD0, SD1}_WP_CD_SEL Masahiro Yamada
2015-06-01 12:44   ` [RESEND PATCH 2/2] pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL Linus Walleij
2015-06-01 12:44     ` [RESEND PATCH 2/2] pinctrl: zynq: fix offset address for {SD0, SD1}_WP_CD_SEL Linus Walleij
2015-06-01 12:44     ` [RESEND PATCH 2/2] pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL Linus Walleij
2015-05-20 14:23 ` Sören Brinkmann [this message]
2015-05-20 14:23   ` [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function Sören Brinkmann
2015-05-20 14:23   ` Sören Brinkmann
2015-05-21 14:31   ` Masahiro Yamada
2015-05-21 14:31     ` Masahiro Yamada
2015-05-21 14:31     ` Masahiro Yamada
2015-06-01 13:01   ` Linus Walleij
2015-06-01 13:01     ` Linus Walleij
2015-06-01 13:01     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520142358.GS31550@xsjsorenbubuntu \
    --to=soren.brinkmann@xilinx.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.