* [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK
@ 2015-05-13 7:37 Romain Izard
2015-05-20 16:52 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Romain Izard @ 2015-05-13 7:37 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren, linux-omap, devicetree; +Cc: Romain Izard
While Sitara AM335x SoCs are very close to OMAP SoCs, the 32-line GPIO
controllers are numbered from 0 on AM335x and from 1 on OMAP. But when
the configuration for the TI WLAN controllers was converted from
platform data to device tree, this detail was overlooked, as 10 boards
were using OMAP with the WL12xx and WL18xx controllers, and only one
was based on AM335x.
This invalid configuration prevents the WL1271 module on the AM335x
EVM-SK from notifying interrupts to the SoC, and breaks the wlan driver.
The DTS must be corrected to use the correct GPIO controller.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 87fc7a35e802..156d05efcb70 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -654,7 +654,7 @@
wlcore: wlcore@2 {
compatible = "ti,wl1271";
reg = <2>;
- interrupt-parent = <&gpio1>;
+ interrupt-parent = <&gpio0>;
interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */
ref-clock-frequency = <38400000>;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK
2015-05-13 7:37 [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK Romain Izard
@ 2015-05-20 16:52 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2015-05-20 16:52 UTC (permalink / raw)
To: Romain Izard; +Cc: Benoît Cousson, linux-omap, devicetree
* Romain Izard <romain.izard.pro@gmail.com> [150513 00:39]:
> While Sitara AM335x SoCs are very close to OMAP SoCs, the 32-line GPIO
> controllers are numbered from 0 on AM335x and from 1 on OMAP. But when
> the configuration for the TI WLAN controllers was converted from
> platform data to device tree, this detail was overlooked, as 10 boards
> were using OMAP with the WL12xx and WL18xx controllers, and only one
> was based on AM335x.
>
> This invalid configuration prevents the WL1271 module on the AM335x
> EVM-SK from notifying interrupts to the SoC, and breaks the wlan driver.
>
> The DTS must be corrected to use the correct GPIO controller.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index 87fc7a35e802..156d05efcb70 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -654,7 +654,7 @@
> wlcore: wlcore@2 {
> compatible = "ti,wl1271";
> reg = <2>;
> - interrupt-parent = <&gpio1>;
> + interrupt-parent = <&gpio0>;
> interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */
> ref-clock-frequency = <38400000>;
> };
Applying into omap-for-v4.1/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-20 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-13 7:37 [PATCH] ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK Romain Izard
2015-05-20 16:52 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.