All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Marek Vasut <marex@denx.de>,
	linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor"
Date: Wed, 20 May 2015 14:35:46 -0700	[thread overview]
Message-ID: <20150520213546.GN11598@ld-irv-0074> (raw)
In-Reply-To: <CACna6rzpxoXEJbeRyxaR0wiPpWc_MmgvnqoW-dSw4fF-=EMM_g@mail.gmail.com>

On Tue, May 19, 2015 at 09:27:50AM +0200, Rafał Miłecki wrote:
> On 19 May 2015 at 03:34, Brian Norris <computersforpeace@gmail.com> wrote:
> > So how about the following patch? It seems like we'll need to be able to
> > ignore useless 'modalias' values in cases like this:
> >
> >         // modalias = "shinynewdevice"
> >         compatible = "myvendor,shinynewdevice", "jedec,spi-nor";
> >
> > and also if somebody leaves off the entire shinynewdevice string:
> >
> >         // modalias = "spi-nor"
> >         compatible = "jedec,spi-nor";
> >
> > So we rework the spi-nor library to not reject "bad" names, and just
> > fall back to autodetection, and we add the .of_match_table to properly
> > catch all "jedec,spi-nor".
> 
> That's nice but what about platforms using platform data instead of
> DT? I would like to use some kind of "spi-nor" (with some prefix
> *maybe*) for them too.

For platform devices, you might as well just use the name of the driver,
which is 'm25p80'. Isn't that how most platform devices are matched with
drivers?

Or if you can propose other clean solutions, I'm all ears. I'm likely to
merge this patch for 4.2 unless a better solution comes up, though.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
	linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor"
Date: Wed, 20 May 2015 14:35:46 -0700	[thread overview]
Message-ID: <20150520213546.GN11598@ld-irv-0074> (raw)
In-Reply-To: <CACna6rzpxoXEJbeRyxaR0wiPpWc_MmgvnqoW-dSw4fF-=EMM_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, May 19, 2015 at 09:27:50AM +0200, Rafał Miłecki wrote:
> On 19 May 2015 at 03:34, Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > So how about the following patch? It seems like we'll need to be able to
> > ignore useless 'modalias' values in cases like this:
> >
> >         // modalias = "shinynewdevice"
> >         compatible = "myvendor,shinynewdevice", "jedec,spi-nor";
> >
> > and also if somebody leaves off the entire shinynewdevice string:
> >
> >         // modalias = "spi-nor"
> >         compatible = "jedec,spi-nor";
> >
> > So we rework the spi-nor library to not reject "bad" names, and just
> > fall back to autodetection, and we add the .of_match_table to properly
> > catch all "jedec,spi-nor".
> 
> That's nice but what about platforms using platform data instead of
> DT? I would like to use some kind of "spi-nor" (with some prefix
> *maybe*) for them too.

For platform devices, you might as well just use the name of the driver,
which is 'm25p80'. Isn't that how most platform devices are matched with
drivers?

Or if you can propose other clean solutions, I'm all ears. I'm likely to
merge this patch for 4.2 unless a better solution comes up, though.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Marek Vasut <marex@denx.de>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Stephen Warren <swarren@wwwdotorg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Kumar Gala <galak@codeaurora.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor"
Date: Wed, 20 May 2015 14:35:46 -0700	[thread overview]
Message-ID: <20150520213546.GN11598@ld-irv-0074> (raw)
In-Reply-To: <CACna6rzpxoXEJbeRyxaR0wiPpWc_MmgvnqoW-dSw4fF-=EMM_g@mail.gmail.com>

On Tue, May 19, 2015 at 09:27:50AM +0200, Rafał Miłecki wrote:
> On 19 May 2015 at 03:34, Brian Norris <computersforpeace@gmail.com> wrote:
> > So how about the following patch? It seems like we'll need to be able to
> > ignore useless 'modalias' values in cases like this:
> >
> >         // modalias = "shinynewdevice"
> >         compatible = "myvendor,shinynewdevice", "jedec,spi-nor";
> >
> > and also if somebody leaves off the entire shinynewdevice string:
> >
> >         // modalias = "spi-nor"
> >         compatible = "jedec,spi-nor";
> >
> > So we rework the spi-nor library to not reject "bad" names, and just
> > fall back to autodetection, and we add the .of_match_table to properly
> > catch all "jedec,spi-nor".
> 
> That's nice but what about platforms using platform data instead of
> DT? I would like to use some kind of "spi-nor" (with some prefix
> *maybe*) for them too.

For platform devices, you might as well just use the name of the driver,
which is 'm25p80'. Isn't that how most platform devices are matched with
drivers?

Or if you can propose other clean solutions, I'm all ears. I'm likely to
merge this patch for 4.2 unless a better solution comes up, though.

Brian

  reply	other threads:[~2015-05-20 21:35 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 17:32 [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Brian Norris
2015-05-14 17:32 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Brian Norris
2015-05-14 17:46 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Stephen Warren
2015-05-14 17:46   ` Stephen Warren
2015-05-14 17:46   ` Stephen Warren
2015-05-14 20:26   ` Geert Uytterhoeven
2015-05-14 20:26     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Geert Uytterhoeven
2015-05-15 20:02     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Brian Norris
2015-05-15 20:02       ` Brian Norris
2015-05-15 20:52       ` Rafał Miłecki
2015-05-15 20:52         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-15 20:52         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-18 14:42       ` Stephen Warren
2015-05-18 14:42         ` Stephen Warren
2015-05-18 14:42         ` Stephen Warren
2015-05-15 10:17 ` Mark Rutland
2015-05-15 10:17   ` Mark Rutland
2015-05-15 10:17   ` Mark Rutland
2015-05-15 19:55 ` Brian Norris
2015-05-15 19:55   ` Brian Norris
2015-05-18 10:45   ` Mark Rutland
2015-05-18 10:45     ` Mark Rutland
2015-05-18 10:45     ` Mark Rutland
2015-05-18 18:34     ` Brian Norris
2015-05-18 18:34       ` Brian Norris
2015-05-18 18:51       ` Geert Uytterhoeven
2015-05-18 18:51         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Geert Uytterhoeven
2015-05-18 18:51         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Geert Uytterhoeven
2015-05-19  1:34         ` Brian Norris
2015-05-19  1:34           ` Brian Norris
2015-05-19  7:27           ` Rafał Miłecki
2015-05-19  7:27             ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-20 21:35             ` Brian Norris [this message]
2015-05-20 21:35               ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Brian Norris
2015-05-20 21:35               ` Brian Norris
2015-05-21  7:12               ` Rafał Miłecki
2015-05-21  7:12                 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  7:12                 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  7:25                 ` Brian Norris
2015-05-21  7:25                   ` Brian Norris
2015-05-21  8:01                   ` Rafał Miłecki
2015-05-21  8:01                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  8:01                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  8:15                     ` Brian Norris
2015-05-21  8:15                       ` Brian Norris
2015-05-21  8:15                       ` Brian Norris
2015-05-21  8:25                       ` Rafał Miłecki
2015-05-21  8:25                         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  8:25                         ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  8:39                         ` Geert Uytterhoeven
2015-05-21  8:39                           ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Geert Uytterhoeven
2015-05-21  8:39                           ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Geert Uytterhoeven
2015-05-21  8:50                           ` Rafał Miłecki
2015-05-21  8:50                             ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  8:50                             ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  8:58                             ` Geert Uytterhoeven
2015-05-21  8:58                               ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Geert Uytterhoeven
2015-05-21  8:58                               ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Geert Uytterhoeven
2015-05-21  9:31                               ` Rafał Miłecki
2015-05-21  9:31                                 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  9:31                                 ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  9:39                                 ` Geert Uytterhoeven
2015-05-21  9:39                                   ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Geert Uytterhoeven
2015-05-21  9:47                                   ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  9:47                                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  9:47                                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-05-21  9:57                                   ` Rafał Miłecki
2015-05-21  9:57                                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor" Rafał Miłecki
2015-05-21  9:57                                     ` [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor" Rafał Miłecki
2015-07-21 16:57           ` Brian Norris
2015-07-21 16:57             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520213546.GN11598@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=Pawel.Moll@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.