* Compile errors with dell_rbtn_notifier_register
@ 2015-05-21 20:53 Valdis Kletnieks
2015-05-21 20:59 ` Pali Rohár
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Kletnieks @ 2015-05-21 20:53 UTC (permalink / raw)
To: Pali Rohar; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
commit 61104aa44529d59bd01a5d51df571ca2823a04b3
Author: Pali Rohár <pali.rohar@gmail.com>
Date: Thu May 14 12:54:27 2015 +0200
dell-laptop: Use dell-rbtn instead i8042 filter when possible
causes build errors:
LD init/built-in.o
drivers/built-in.o: In function `dell_init':
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:762: undefined reference to `dell_rbtn_notifier_register'
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2016: undefined reference to `dell_rbtn_notifier_unregister'
drivers/built-in.o: In function `dell_exit':
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2041: undefined reference to `dell_rbtn_notifier_unregister'
when built with:
CONFIG_DELL_LAPTOP=y
CONFIG_DELL_RBTN=m
because the builtin then references a symbol that's in a module.
Probably needs some Kconfig magic to ensure this case doesn't happen.
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Compile errors with dell_rbtn_notifier_register
2015-05-21 20:53 Compile errors with dell_rbtn_notifier_register Valdis Kletnieks
@ 2015-05-21 20:59 ` Pali Rohár
0 siblings, 0 replies; 2+ messages in thread
From: Pali Rohár @ 2015-05-21 20:59 UTC (permalink / raw)
To: Darren Hart; +Cc: Valdis Kletnieks, linux-kernel, platform-driver-x86
[-- Attachment #1: Type: Text/Plain, Size: 1191 bytes --]
On Thursday 21 May 2015 22:53:37 Valdis Kletnieks wrote:
> commit 61104aa44529d59bd01a5d51df571ca2823a04b3
> Author: Pali Rohár <pali.rohar@gmail.com>
> Date: Thu May 14 12:54:27 2015 +0200
>
> dell-laptop: Use dell-rbtn instead i8042 filter when possible
>
> causes build errors:
>
> LD init/built-in.o
> drivers/built-in.o: In function `dell_init':
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:762: undefined
> reference to `dell_rbtn_notifier_register'
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2016:
> undefined reference to `dell_rbtn_notifier_unregister'
> drivers/built-in.o: In function `dell_exit':
> /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2041:
> undefined reference to `dell_rbtn_notifier_unregister'
>
> when built with:
>
> CONFIG_DELL_LAPTOP=y
> CONFIG_DELL_RBTN=m
>
> because the builtin then references a symbol that's in a module.
>
> Probably needs some Kconfig magic to ensure this case doesn't happen.
Darren, what do you prefer as fix? Some Kconfig magic (maybe depends?)?
or other magic in dell_rbtn.h to inline empty functions?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-21 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-21 20:53 Compile errors with dell_rbtn_notifier_register Valdis Kletnieks
2015-05-21 20:59 ` Pali Rohár
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.