[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Paul Kocialkowski]

Since we're now using a dynamic controller index for fastboot too,
usb_gadget_handle_interrupts should be using it instead of 0 (despite the fact
that it's currently not being used at all in the musb-new implementation).

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 common/cmd_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
index 86fbddf..b9d1c8c 100644
--- a/common/cmd_fastboot.c
+++ b/common/cmd_fastboot.c
@@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 			break;
 		if (ctrlc())
 			break;
-		usb_gadget_handle_interrupts(0);
+		usb_gadget_handle_interrupts(controller_index);
 	}
 
 	ret = CMD_RET_SUCCESS;
-- 
1.9.1

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Lukasz Majewski]

Hi Paul,

> Since we're now using a dynamic controller index for fastboot too,
> usb_gadget_handle_interrupts should be using it instead of 0 (despite
> the fact that it's currently not being used at all in the musb-new
> implementation).
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  common/cmd_fastboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> index 86fbddf..b9d1c8c 100644
> --- a/common/cmd_fastboot.c
> +++ b/common/cmd_fastboot.c
> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
> int argc, char *const argv[]) break;
>  		if (ctrlc())
>  			break;
> -		usb_gadget_handle_interrupts(0);
> +		usb_gadget_handle_interrupts(controller_index);
>  	}
>  
>  	ret = CMD_RET_SUCCESS;

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Simon Glass]

On 25 May 2015 at 08:50, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Paul,
>
>> Since we're now using a dynamic controller index for fastboot too,
>> usb_gadget_handle_interrupts should be using it instead of 0 (despite
>> the fact that it's currently not being used at all in the musb-new
>> implementation).
>>
>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>> ---
>>  common/cmd_fastboot.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
>> index 86fbddf..b9d1c8c 100644
>> --- a/common/cmd_fastboot.c
>> +++ b/common/cmd_fastboot.c
>> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
>> int argc, char *const argv[]) break;
>>               if (ctrlc())
>>                       break;
>> -             usb_gadget_handle_interrupts(0);
>> +             usb_gadget_handle_interrupts(controller_index);
>>       }
>>
>>       ret = CMD_RET_SUCCESS;
>
> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

This is in my queue and looks like a fix, so I'm picking it up.

Applied to u-boot-x86, thanks!

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Lukasz Majewski]

On Sun, 7 Jun 2015 08:48:31 -0600
Simon Glass <sjg@chromium.org> wrote:

> On 25 May 2015 at 08:50, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > Hi Paul,
> >
> >> Since we're now using a dynamic controller index for fastboot too,
> >> usb_gadget_handle_interrupts should be using it instead of 0
> >> (despite the fact that it's currently not being used at all in the
> >> musb-new implementation).
> >>
> >> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >> ---
> >>  common/cmd_fastboot.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> >> index 86fbddf..b9d1c8c 100644
> >> --- a/common/cmd_fastboot.c
> >> +++ b/common/cmd_fastboot.c
> >> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
> >> flag, int argc, char *const argv[]) break;
> >>               if (ctrlc())
> >>                       break;
> >> -             usb_gadget_handle_interrupts(0);
> >> +             usb_gadget_handle_interrupts(controller_index);
> >>       }
> >>
> >>       ret = CMD_RET_SUCCESS;
> >
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> This is in my queue and looks like a fix, so I'm picking it up.
> 
> Applied to u-boot-x86, thanks!

One less to go ;-).

Thanks Simon.

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150607/78a54f3b/attachment.sig>

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Simon Glass]

Hi Paul,

On 7 June 2015 at 08:48, Simon Glass <sjg@chromium.org> wrote:
> On 25 May 2015 at 08:50, Lukasz Majewski <l.majewski@samsung.com> wrote:
>> Hi Paul,
>>
>>> Since we're now using a dynamic controller index for fastboot too,
>>> usb_gadget_handle_interrupts should be using it instead of 0 (despite
>>> the fact that it's currently not being used at all in the musb-new
>>> implementation).
>>>
>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>> ---
>>>  common/cmd_fastboot.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
>>> index 86fbddf..b9d1c8c 100644
>>> --- a/common/cmd_fastboot.c
>>> +++ b/common/cmd_fastboot.c
>>> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
>>> int argc, char *const argv[]) break;
>>>               if (ctrlc())
>>>                       break;
>>> -             usb_gadget_handle_interrupts(0);
>>> +             usb_gadget_handle_interrupts(controller_index);
>>>       }
>>>
>>>       ret = CMD_RET_SUCCESS;
>>
>> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
>
> This is in my queue and looks like a fix, so I'm picking it up.
>
> Applied to u-boot-x86, thanks!

Unfortunately in my final build test this breaks a number of boards, including:

am335x_boneblack_vboot

common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared
(first use in this function)
   usb_gadget_handle_interrupts(controller_index);

Can you please take a look and respin it?

For now I've dropped it from u-boot-x86.

Regards,
Simon

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Paul Kocialkowski]

[snip]

> >> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> >
> > This is in my queue and looks like a fix, so I'm picking it up.
> >
> > Applied to u-boot-x86, thanks!
> 
> Unfortunately in my final build test this breaks a number of boards, including:
> 
> am335x_boneblack_vboot
> 
> common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared
> (first use in this function)
>    usb_gadget_handle_interrupts(controller_index);
> 
> Can you please take a look and respin it?

Of course, this makes perfect sense. I didn't think about it until now,
but this patch goes on top of the four fastboot-related dfu patches that
I sent out (again) yesterday.

I think this should be picked up along with those patches.
Lukasz, could you do that?

Thanks

> For now I've dropped it from u-boot-x86.

Makes sense.

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150613/4e3a79c3/attachment.sig>

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Paul Kocialkowski]

Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :
> Hi Paul,
> 
> > Since we're now using a dynamic controller index for fastboot too,
> > usb_gadget_handle_interrupts should be using it instead of 0 (despite
> > the fact that it's currently not being used at all in the musb-new
> > implementation).
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  common/cmd_fastboot.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > index 86fbddf..b9d1c8c 100644
> > --- a/common/cmd_fastboot.c
> > +++ b/common/cmd_fastboot.c
> > @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
> > int argc, char *const argv[]) break;
> >  		if (ctrlc())
> >  			break;
> > -		usb_gadget_handle_interrupts(0);
> > +		usb_gadget_handle_interrupts(controller_index);
> >  	}
> >  
> >  	ret = CMD_RET_SUCCESS;
> 
> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>

Now that the other patches have been merged, this one could be as well.

Lukasz, is there anything else holding it back?

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150707/cefd31c1/attachment.sig>

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Paul Kocialkowski]

Le mardi 07 juillet 2015 ? 14:29 +0200, Paul Kocialkowski a ?crit :
> Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :
> > Hi Paul,
> > 
> > > Since we're now using a dynamic controller index for fastboot too,
> > > usb_gadget_handle_interrupts should be using it instead of 0 (despite
> > > the fact that it's currently not being used at all in the musb-new
> > > implementation).
> > > 
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > >  common/cmd_fastboot.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > > index 86fbddf..b9d1c8c 100644
> > > --- a/common/cmd_fastboot.c
> > > +++ b/common/cmd_fastboot.c
> > > @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag,
> > > int argc, char *const argv[]) break;
> > >  		if (ctrlc())
> > >  			break;
> > > -		usb_gadget_handle_interrupts(0);
> > > +		usb_gadget_handle_interrupts(controller_index);
> > >  	}
> > >  
> > >  	ret = CMD_RET_SUCCESS;
> > 
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> Now that the other patches have been merged, this one could be as well.
> 
> Lukasz, is there anything else holding it back?

It's been a week since I asked this. Any news?

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150714/62f4dcf9/attachment.sig>

[U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts

[Lukasz Majewski]

Hi Paul,

> Le mardi 07 juillet 2015 ? 14:29 +0200, Paul Kocialkowski a ?crit :
> > Le lundi 25 mai 2015 ? 16:50 +0200, Lukasz Majewski a ?crit :
> > > Hi Paul,
> > > 
> > > > Since we're now using a dynamic controller index for fastboot
> > > > too, usb_gadget_handle_interrupts should be using it instead of
> > > > 0 (despite the fact that it's currently not being used at all
> > > > in the musb-new implementation).
> > > > 
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > >  common/cmd_fastboot.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > > > index 86fbddf..b9d1c8c 100644
> > > > --- a/common/cmd_fastboot.c
> > > > +++ b/common/cmd_fastboot.c
> > > > @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
> > > > flag, int argc, char *const argv[]) break;
> > > >  		if (ctrlc())
> > > >  			break;
> > > > -		usb_gadget_handle_interrupts(0);
> > > > +		usb_gadget_handle_interrupts(controller_index);
> > > >  	}
> > > >  
> > > >  	ret = CMD_RET_SUCCESS;
> > > 
> > > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> > 
> > Now that the other patches have been merged, this one could be as
> > well.
> > 
> > Lukasz, is there anything else holding it back?
> 
> It's been a week since I asked this. Any news?

Applied to u-boot-dfu tree.

Thanks for the patch!

> 
> Thanks!



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group