Re: [PATCH 05/11] perf, tools, report: Add processing for cycle histograms

From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, namhyung@kernel.org, eranian@google.com,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 05/11] perf, tools, report: Add processing for cycle histograms
Date: Mon, 1 Jun 2015 16:10:46 +0200	[thread overview]
Message-ID: <20150601141046.GA14379@krava.redhat.com> (raw)
In-Reply-To: <1432749114-904-6-git-send-email-andi@firstfloor.org>

On Wed, May 27, 2015 at 10:51:48AM -0700, Andi Kleen wrote:

SNIP

> +void hist__account_cycles(struct branch_stack *bs, struct addr_location *al,
> +			  struct perf_sample *sample, bool nonany_branch_mode)
> +{
> +	struct branch_info *bi;
> +
> +	/* If we have branch cycles always annotate them. */
> +	if (bs && bs->nr && bs->entries[0].flags.cycles) {
> +		int i;
> +
> +		bi = sample__resolve_bstack(sample, al);
> +		if (bi) {
> +			struct addr_map_symbol *prev = NULL;
> +
> +			/*
> +			 * Ignore errors, still want to process the
> +			 * other entries.
> +			 *
> +			 * For non standard branch modes always
> +			 * force no IPC (prev == NULL)
> +			 *
> +			 * Note that perf stores branches reversed from
> +			 * program order!
> +			 */
> +			for (i = bs->nr - 1; i >= 0; i--) {
> +				addr_map_symbol__account_cycles(&bi[i].from,
> +					nonany_branch_mode ? NULL : prev,
> +					bi[i].flags.cycles);

it's only ERANGE you want to ignore here

jirka