From: Jouni Malinen <j@w1.fi>
To: Stephan Mueller <smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
Herbert Xu
<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
Linux Crypto Mailing List
<linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Steffen Klassert
<steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 7/7] mac80211: Switch to new AEAD interface
Date: Tue, 2 Jun 2015 12:15:43 +0300 [thread overview]
Message-ID: <20150602091543.GA3140@w1.fi> (raw)
In-Reply-To: <2613062.1qx4rgqk9F@tauon>
On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote:
> Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg:
> >IOW, I think something like this would make sense:
>
> That looks definitely cleaner :-)
Indeed.. That AAD length-in-the-buffer design came from the over ten
year old code that was optimized to cover the CCM construction with the
same buffer and that was not cleaned up when this was converted to use
cryptoapi couple of years ago.
> Though, my main concern was just to ensure that the aad length value is not
> zero.
It won't be in IEEE 802.11 use cases. The exact length depends on the
IEEE 802.11 frame type, but AAD is constructed in a way that it is
normally a bit over 20 octets while allowing CCM to fit the related
operations into two AES blocks.
--
Jouni Malinen PGP id EFC895FA
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <j@w1.fi>
To: Stephan Mueller <smueller@chronox.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Marcel Holtmann <marcel@holtmann.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 7/7] mac80211: Switch to new AEAD interface
Date: Tue, 2 Jun 2015 12:15:43 +0300 [thread overview]
Message-ID: <20150602091543.GA3140@w1.fi> (raw)
In-Reply-To: <2613062.1qx4rgqk9F@tauon>
On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote:
> Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg:
> >IOW, I think something like this would make sense:
>
> That looks definitely cleaner :-)
Indeed.. That AAD length-in-the-buffer design came from the over ten
year old code that was optimized to cover the CCM construction with the
same buffer and that was not cleaned up when this was converted to use
cryptoapi couple of years ago.
> Though, my main concern was just to ensure that the aad length value is not
> zero.
It won't be in IEEE 802.11 use cases. The exact length depends on the
IEEE 802.11 frame type, but AAD is constructed in a way that it is
normally a bit over 20 octets while allowing CCM to fit the related
operations into two AES blocks.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2015-06-02 9:15 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:39 [PATCH 0/7] crypto: Convert all AEAD users to new interface Herbert Xu
2015-05-21 10:43 ` [PATCH 1/7] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-05-21 10:43 ` [PATCH 2/7] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-21 10:43 ` [PATCH 3/7] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-21 10:43 ` [PATCH 4/7] esp4: Switch to new AEAD interface Herbert Xu
2015-05-21 10:44 ` [PATCH 5/7] esp6: " Herbert Xu
2015-05-22 6:40 ` Stephan Mueller
2015-05-22 6:45 ` Herbert Xu
2015-05-22 7:16 ` Stephan Mueller
2015-05-22 7:19 ` Herbert Xu
2015-05-26 6:39 ` Stephan Mueller
2015-05-26 7:02 ` Stephan Mueller
2015-05-26 7:21 ` Herbert Xu
2015-05-26 7:37 ` Stephan Mueller
2015-05-26 7:38 ` Herbert Xu
2015-05-26 7:40 ` Herbert Xu
2015-05-26 7:56 ` Stephan Mueller
2015-05-26 7:57 ` Herbert Xu
2015-05-26 8:15 ` Stephan Mueller
2015-05-26 8:18 ` Herbert Xu
2015-05-26 8:27 ` Stephan Mueller
2015-05-21 10:44 ` [PATCH 6/7] mac802154: " Herbert Xu
2015-05-21 10:44 ` [PATCH 7/7] mac80211: " Herbert Xu
2015-05-21 11:20 ` Johannes Berg
2015-05-21 11:50 ` Herbert Xu
2015-05-21 12:17 ` Johannes Berg
2015-05-22 4:11 ` Herbert Xu
2015-06-01 13:21 ` Stephan Mueller
2015-06-01 13:42 ` Johannes Berg
2015-06-01 13:49 ` Stephan Mueller
2015-06-01 14:05 ` Johannes Berg
2015-06-01 14:35 ` Johannes Berg
[not found] ` <1433169326.3505.12.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-06-01 15:36 ` Stephan Mueller
2015-06-01 15:36 ` Stephan Mueller
2015-06-02 9:15 ` Jouni Malinen [this message]
2015-06-02 9:15 ` Jouni Malinen
2015-05-22 7:32 ` Johannes Berg
2015-05-22 7:41 ` Herbert Xu
2015-05-22 7:43 ` Johannes Berg
2015-05-22 8:05 ` Herbert Xu
2015-05-22 8:18 ` Johannes Berg
2015-05-22 8:19 ` Herbert Xu
2015-05-21 12:29 ` [PATCH 0/7] crypto: Convert all AEAD users to new interface Stephan Mueller
2015-05-22 0:18 ` Herbert Xu
2015-05-21 16:03 ` David Miller
2015-05-22 0:21 ` Herbert Xu
2015-05-22 8:27 ` [v2 PATCH 0/13] " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 1/13] crypto: aead - Add crypto_aead_alg_ivsize/maxauthsize Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 2/13] crypto: seqiv - Use aead_register_instance Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 3/13] crypto: echainiv " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 4/13] crypto: aead - Do not set cra_type for new style instances Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-06-04 22:15 ` Tadeusz Struk
2015-06-05 3:57 ` Herbert Xu
2015-06-05 22:10 ` Tadeusz Struk
2015-06-07 7:06 ` Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 6/13] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 7/13] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 8/13] esp4: Switch to new AEAD interface Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 9/13] esp6: " Herbert Xu
2015-05-22 8:30 ` [v2 PATCH 10/13] mac802154: " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 11/13] mac80211: " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 12/13] crypto: tcrypt - " Herbert Xu
2015-05-22 8:31 ` [v2 PATCH 13/13] crypto: algif_aead " Herbert Xu
2015-05-22 20:59 ` Stephan Mueller
2015-05-22 21:04 ` Stephan Mueller
2015-05-22 21:54 ` [PATCH 0/2] crypto: Use tmpl->create when registering geniv Herbert Xu
2015-05-22 21:58 ` [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface Herbert Xu
2015-05-23 18:04 ` Stephan Mueller
2015-05-23 18:04 ` Stephan Mueller
2015-05-24 3:34 ` Herbert Xu
2015-05-24 10:52 ` Stephan Mueller
2015-05-25 10:20 ` Herbert Xu
2015-05-25 11:50 ` Stephan Mueller
2015-05-25 11:53 ` Herbert Xu
2015-05-26 6:24 ` Herbert Xu
2015-05-26 6:44 ` Stephan Mueller
2015-05-26 7:36 ` Herbert Xu
2015-05-26 7:57 ` Stephan Mueller
2015-05-26 7:58 ` Herbert Xu
2015-05-27 8:01 ` [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 1/8] crypto: testmgr - Switch to new AEAD interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 2/8] xfrm: Add IV generator information to xfrm_algo_desc Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 3/8] ipsec: Add IV generator information to xfrm_state Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 4/8] esp4: Switch to new AEAD interface Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 5/8] esp6: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 6/8] mac802154: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 7/8] mac80211: " Herbert Xu
2015-05-27 8:03 ` [v3 PATCH 8/8] crypto: tcrypt - " Herbert Xu
2015-05-27 8:15 ` [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface Johannes Berg
2015-05-27 8:39 ` Herbert Xu
2015-05-27 9:00 ` Johannes Berg
2015-05-27 9:07 ` Herbert Xu
2015-05-27 9:18 ` Johannes Berg
2015-05-27 9:25 ` Steffen Klassert
2015-05-27 9:29 ` Herbert Xu
2015-05-27 9:32 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602091543.GA3140@w1.fi \
--to=j@w1.fi \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org \
--cc=steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.