[Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

[Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

[Don Slutz]

Public bug reported:

On 06/04/15 11:04, Fabio Fantoni wrote:
> Today after trying xen-unstable build (tested many hours) of some days
> ago I tried update qemu to latest development version (from git master
> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
> a regression:
>> xl create /etc/xen/W7.cfg
>> Parsing config from /etc/xen/W7.cfg
>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>> error message from QMP server: QMP input object member 'id' is unexpected
>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>> to QMP
> 

This is caused by:

commit 65207c59d99f2260c5f1d3b9c491146616a522aa
Author: Markus Armbruster <armbru@redhat.com>
Date:   Thu Mar 5 14:35:26 2015 +0100

    monitor: Drop broken, unused asynchronous command interface


> DomU is working but operations that require QMP not (for example
> save/restore).
> 
> Thanks for any reply and sorry for my bad english.

** Affects: qemu
     Importance: Undecided
         Status: New

** Patch added: "0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch"
   https://bugs.launchpad.net/bugs/1462131/+attachment/4410103/+files/0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1462131

Title:
  qemu mainline regression with xen-unstable: unable to start QMP

Status in QEMU:
  New

Bug description:
  On 06/04/15 11:04, Fabio Fantoni wrote:
  > Today after trying xen-unstable build (tested many hours) of some days
  > ago I tried update qemu to latest development version (from git master
  > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
  > a regression:
  >> xl create /etc/xen/W7.cfg
  >> Parsing config from /etc/xen/W7.cfg
  >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
  >> error message from QMP server: QMP input object member 'id' is unexpected
  >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
  >> to QMP
  > 

  This is caused by:

  commit 65207c59d99f2260c5f1d3b9c491146616a522aa
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   Thu Mar 5 14:35:26 2015 +0100

      monitor: Drop broken, unused asynchronous command interface

  
  > DomU is working but operations that require QMP not (for example
  > save/restore).
  > 
  > Thanks for any reply and sorry for my bad english.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1462131/+subscriptions

[Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

[Don Slutz]

Subject: Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP
Date: Thu, 04 Jun 2015 16:10:34 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat, Inc.
To: Don Slutz <don.slutz@gmail.com>, Fabio Fantoni <fabio.fantoni@m2r.biz>, qemu-devel@nongnu.org <qemu-devel@nongnu.org>, xen-devel <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Markus Armbruster <armbru@redhat.com>

[adding Markus, as author of the regression]

On 06/04/2015 03:59 PM, Don Slutz wrote:
> On 06/04/15 11:04, Fabio Fantoni wrote:
>> Today after trying xen-unstable build (tested many hours) of some days
>> ago I tried update qemu to latest development version (from git master
>> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
>> a regression:
>>> xl create /etc/xen/W7.cfg
>>> Parsing config from /etc/xen/W7.cfg
>>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>>> error message from QMP server: QMP input object member 'id' is unexpected
>>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>>> to QMP
>>
> 
> This is caused by:
> 
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <armbru@redhat.com>
> Date:   Thu Mar 5 14:35:26 2015 +0100
> 
>     monitor: Drop broken, unused asynchronous command interface
> 

> The patch:
> 
>>From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001
> From: Don Slutz <dslutz@verizon.com>
> Date: Thu, 4 Jun 2015 17:04:42 -0400
> Subject: [PATCH 01/14] monitor: Allow Xen's (broken) usage of asynchronous
>  command interface.
> 
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <armbru@redhat.com>
> Date:   Thu Mar 5 14:35:26 2015 +0100
> 
>     monitor: Drop broken, unused asynchronous command interface
> 
> Breaks Xen.  Add a hack un unbreak it.

s/un /to /

> 
> Xen is only doing synchronous commands, but is including an id.

QMP also uses id, but apparently removes it up front before calling into
this function; so another fix would be having xen remove it up front.

> 
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>  monitor.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/monitor.c b/monitor.c
> index c7baa91..e9a0747 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject
> *input_obj, Error **errp)
>                            "arguments", "object");
>                  return NULL;
>              }
> +        } else if (!strcmp(arg_name, "id")) {
> +            /*
> +             * Fixup Xen's usage. Just ignore the "id". See point #5
> +             * above.  This was an attempt at an asynchronous
> +             * command interface.  However commit
> +             * 65207c59d99f2260c5f1d3b9c491146616a522aa is
> +             * wrong. Xen does not expect an error when it passes in
> +             * "id":1, so just continue to ignore it.
> +             */

The comment is a bit verbose, particularly since 'id' is a
well-established usage pattern in QMP.  Also, we don't need to call out
why it changed in the comment here, the commit message is sufficient for
that.

>          } else {
>              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
>              return NULL;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1462131

Title:
  qemu mainline regression with xen-unstable: unable to start QMP

Status in QEMU:
  New

Bug description:
  On 06/04/15 11:04, Fabio Fantoni wrote:
  > Today after trying xen-unstable build (tested many hours) of some days
  > ago I tried update qemu to latest development version (from git master
  > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
  > a regression:
  >> xl create /etc/xen/W7.cfg
  >> Parsing config from /etc/xen/W7.cfg
  >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
  >> error message from QMP server: QMP input object member 'id' is unexpected
  >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
  >> to QMP
  > 

  This is caused by:

  commit 65207c59d99f2260c5f1d3b9c491146616a522aa
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   Thu Mar 5 14:35:26 2015 +0100

      monitor: Drop broken, unused asynchronous command interface

  
  > DomU is working but operations that require QMP not (for example
  > save/restore).
  > 
  > Thanks for any reply and sorry for my bad english.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1462131/+subscriptions

[Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

[Fantu]

** Changed in: qemu
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1462131

Title:
  qemu mainline regression with xen-unstable: unable to start QMP

Status in QEMU:
  Confirmed

Bug description:
  On 06/04/15 11:04, Fabio Fantoni wrote:
  > Today after trying xen-unstable build (tested many hours) of some days
  > ago I tried update qemu to latest development version (from git master
  > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
  > a regression:
  >> xl create /etc/xen/W7.cfg
  >> Parsing config from /etc/xen/W7.cfg
  >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
  >> error message from QMP server: QMP input object member 'id' is unexpected
  >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
  >> to QMP
  > 

  This is caused by:

  commit 65207c59d99f2260c5f1d3b9c491146616a522aa
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   Thu Mar 5 14:35:26 2015 +0100

      monitor: Drop broken, unused asynchronous command interface

  
  > DomU is working but operations that require QMP not (for example
  > save/restore).
  > 
  > Thanks for any reply and sorry for my bad english.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1462131/+subscriptions

Re: [Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

[Wen Congyang]

On 06/05/2015 06:09 AM, Don Slutz wrote:
> Public bug reported:
> 
> On 06/04/15 11:04, Fabio Fantoni wrote:
>> Today after trying xen-unstable build (tested many hours) of some days
>> ago I tried update qemu to latest development version (from git master
>> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
>> a regression:
>>> xl create /etc/xen/W7.cfg
>>> Parsing config from /etc/xen/W7.cfg
>>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>>> error message from QMP server: QMP input object member 'id' is unexpected
>>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>>> to QMP
>>
> 
> This is caused by:
> 
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <armbru@redhat.com>
> Date:   Thu Mar 5 14:35:26 2015 +0100
> 
>     monitor: Drop broken, unused asynchronous command interface
> 
> 
>> DomU is working but operations that require QMP not (for example
>> save/restore).
>>
>> Thanks for any reply and sorry for my bad english.
> 
> ** Affects: qemu
>      Importance: Undecided
>          Status: New
> 
> ** Patch added: "0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch"
>    https://bugs.launchpad.net/bugs/1462131/+attachment/4410103/+files/0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch
> 

Please try this patch:

>From 061dc4ed1012726fc0b8e1c6d0a784476f5c6d48 Mon Sep 17 00:00:00 2001
From: Wen Congyang <wency@cn.fujitsu.com>
Date: Fri, 5 Jun 2015 16:17:18 +0800
Subject: [PATCH] monitor: Allow the "id" key

The management application still needs the "id" key.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 monitor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/monitor.c b/monitor.c
index c7baa91..307dc53 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, Error **errp)
                           "arguments", "object");
                 return NULL;
             }
+        } else if (!strcmp(arg_name, "id")) {
+            /* FIXME: check duplicated IDs for async commands */
         } else {
             error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
             return NULL;
-- 
2.4.2

Re: [Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

[Paolo Bonzini]

On 05/06/2015 00:15, Don Slutz wrote:
> QMP also uses id, but apparently removes it up front before calling into
> this function; so another fix would be having xen remove it up front.

No, we don't break users.

This patch fixes Xen but not virt-test, which relies on ids.  It greps
the QMP output for an ID in order to find the output of query-commands.

Paolo

>> > 
>> > Signed-off-by: Don Slutz <dslutz@verizon.com>
>> > ---
>> >  monitor.c | 9 +++++++++
>> >  1 file changed, 9 insertions(+)
>> > 
>> > diff --git a/monitor.c b/monitor.c
>> > index c7baa91..e9a0747 100644
>> > --- a/monitor.c
>> > +++ b/monitor.c
>> > @@ -4955,6 +4955,15 @@ static QDict *qmp_check_input_obj(QObject
>> > *input_obj, Error **errp)
>> >                            "arguments", "object");
>> >                  return NULL;
>> >              }
>> > +        } else if (!strcmp(arg_name, "id")) {
>> > +            /*
>> > +             * Fixup Xen's usage. Just ignore the "id". See point #5
>> > +             * above.  This was an attempt at an asynchronous
>> > +             * command interface.  However commit
>> > +             * 65207c59d99f2260c5f1d3b9c491146616a522aa is
>> > +             * wrong. Xen does not expect an error when it passes in
>> > +             * "id":1, so just continue to ignore it.
>> > +             */
> The comment is a bit verbose, particularly since 'id' is a
> well-established usage pattern in QMP.  Also, we don't need to call out
> why it changed in the comment here, the commit message is sufficient for
> that.
> 

Re: [Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

[Markus Armbruster]

Wen Congyang <wency@cn.fujitsu.com> writes:

> On 06/05/2015 06:09 AM, Don Slutz wrote:
>> Public bug reported:
>> 
>> On 06/04/15 11:04, Fabio Fantoni wrote:
>>> Today after trying xen-unstable build (tested many hours) of some days
>>> ago I tried update qemu to latest development version (from git master
>>> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
>>> a regression:
>>>> xl create /etc/xen/W7.cfg
>>>> Parsing config from /etc/xen/W7.cfg
>>>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>>>> error message from QMP server: QMP input object member 'id' is unexpected
>>>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>>>> to QMP
>>>
>> 
>> This is caused by:
>> 
>> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
>> Author: Markus Armbruster <armbru@redhat.com>
>> Date:   Thu Mar 5 14:35:26 2015 +0100
>> 
>>     monitor: Drop broken, unused asynchronous command interface
>> 
>> 
>>> DomU is working but operations that require QMP not (for example
>>> save/restore).
>>>
>>> Thanks for any reply and sorry for my bad english.
>> 
>> ** Affects: qemu
>>      Importance: Undecided
>>          Status: New
>> 
>> ** Patch added: "0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch"
>>    https://bugs.launchpad.net/bugs/1462131/+attachment/4410103/+files/0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch
>> 
>
> Please try this patch:
>
>>From 061dc4ed1012726fc0b8e1c6d0a784476f5c6d48 Mon Sep 17 00:00:00 2001
> From: Wen Congyang <wency@cn.fujitsu.com>
> Date: Fri, 5 Jun 2015 16:17:18 +0800
> Subject: [PATCH] monitor: Allow the "id" key
>
> The management application still needs the "id" key.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  monitor.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index c7baa91..307dc53 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, Error **errp)
>                            "arguments", "object");
>                  return NULL;
>              }
> +        } else if (!strcmp(arg_name, "id")) {
> +            /* FIXME: check duplicated IDs for async commands */
>          } else {
>              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
>              return NULL;

Commit 65207c5's removal of the code is wrong (and your patch fixes it),
but its removal of the comment is correct.  I'll post a revised patch
shortly.

Thanks!

[Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

[Don Slutz]

Fixed in:



commit 779cec4d20907cbccb26fbf5f5c19c6cdee33eff
Author: Markus Armbruster <armbru@redhat.com>
Date:   Mon Jun 8 10:44:30 2015 +0200

    monitor: Fix QMP ABI breakage around "id"


** Changed in: qemu
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1462131

Title:
  qemu mainline regression with xen-unstable: unable to start QMP

Status in QEMU:
  Fix Released

Bug description:
  On 06/04/15 11:04, Fabio Fantoni wrote:
  > Today after trying xen-unstable build (tested many hours) of some days
  > ago I tried update qemu to latest development version (from git master
  > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
  > a regression:
  >> xl create /etc/xen/W7.cfg
  >> Parsing config from /etc/xen/W7.cfg
  >> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
  >> error message from QMP server: QMP input object member 'id' is unexpected
  >> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
  >> to QMP
  > 

  This is caused by:

  commit 65207c59d99f2260c5f1d3b9c491146616a522aa
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   Thu Mar 5 14:35:26 2015 +0100

      monitor: Drop broken, unused asynchronous command interface

  
  > DomU is working but operations that require QMP not (for example
  > save/restore).
  > 
  > Thanks for any reply and sorry for my bad english.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1462131/+subscriptions