From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: "Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Dmitry Eremin-Solenikov" <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "David Woodhouse" <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, "Kishon Vijay Abraham I" <kishon-l0cyMroinI0@public.gmane.org>, "Felipe Balbi" <balbi-l0cyMroinI0@public.gmane.org>, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, "Bruno Prémont" <bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org>, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Subject: Re: [PATCH 2/8] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Date: Wed, 10 Jun 2015 08:35:14 +0100 [thread overview] Message-ID: <20150610073514.GW2982@x1> (raw) In-Reply-To: <1433885881-19809-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> On Tue, 09 Jun 2015, Hans de Goede wrote: > Add a cell for the usb power_supply part of the axp20x PMICs. > > Note that this cell is only for the usb power_supply part and not the > ac-power / battery-charger / rtc-backup-bat-charger bits. > > Depending on the board each of those must be enabled / disabled separately > in devicetree as most boards do not use all 4. So in dt each one needs its > own child-node of the axp20x node. Another reason for using separate child > nodes for each is so that other devicetree nodes can have a power-supply > property with a phandle referencing a node representing a single > power-supply. > > The decision to use a separate devicetree node for each is reflected on > the kernel side by each getting its own mfd-cell / platform_device and > platform-driver. > > Cc: Bruno Prémont <bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org> > Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > --- > drivers/mfd/axp20x.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 6ffbc11..47ce233 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -113,6 +113,30 @@ static struct resource axp20x_pek_resources[] = { > }, > }; > > +static struct resource axp20x_usb_power_supply_resources[] = { > + { > + .name = "VBUS_PLUGIN", > + .start = AXP20X_IRQ_VBUS_PLUGIN, > + .end = AXP20X_IRQ_VBUS_PLUGIN, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_REMOVAL", > + .start = AXP20X_IRQ_VBUS_REMOVAL, > + .end = AXP20X_IRQ_VBUS_REMOVAL, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_VALID", > + .start = AXP20X_IRQ_VBUS_VALID, > + .end = AXP20X_IRQ_VBUS_VALID, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_NOT_VALID", > + .start = AXP20X_IRQ_VBUS_NOT_VALID, > + .end = AXP20X_IRQ_VBUS_NOT_VALID, > + .flags = IORESOURCE_IRQ, > + }, > +}; Can you take a look at the DEFINE_RES_* macros in include/linux/ioport.h please? > static struct resource axp22x_pek_resources[] = { > { > .name = "PEK_DBR", > @@ -165,7 +189,7 @@ static const struct regmap_config axp20x_regmap_config = { > .val_bits = 8, > .wr_table = &axp20x_writeable_table, > .volatile_table = &axp20x_volatile_table, > - .max_register = AXP20X_FG_RES, > + .max_register = AXP20X_OCV(15), > .cache_type = REGCACHE_RBTREE, > }; > > @@ -368,6 +392,12 @@ static struct mfd_cell axp20x_cells[] = { > .resources = axp20x_pek_resources, > }, { > .name = "axp20x-regulator", > + }, { > + .name = "axp20x-usb-power-supply", > + .of_compatible = "x-powers,axp202-usb-power-supply", > + .num_resources = > + ARRAY_SIZE(axp20x_usb_power_supply_resources), This wrap is only necessary due to the extreme tabbing used to line up the '='. Please do something about that instead. > + .resources = axp20x_usb_power_supply_resources, > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/8] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Date: Wed, 10 Jun 2015 08:35:14 +0100 [thread overview] Message-ID: <20150610073514.GW2982@x1> (raw) In-Reply-To: <1433885881-19809-3-git-send-email-hdegoede@redhat.com> On Tue, 09 Jun 2015, Hans de Goede wrote: > Add a cell for the usb power_supply part of the axp20x PMICs. > > Note that this cell is only for the usb power_supply part and not the > ac-power / battery-charger / rtc-backup-bat-charger bits. > > Depending on the board each of those must be enabled / disabled separately > in devicetree as most boards do not use all 4. So in dt each one needs its > own child-node of the axp20x node. Another reason for using separate child > nodes for each is so that other devicetree nodes can have a power-supply > property with a phandle referencing a node representing a single > power-supply. > > The decision to use a separate devicetree node for each is reflected on > the kernel side by each getting its own mfd-cell / platform_device and > platform-driver. > > Cc: Bruno Pr?mont <bonbons@linux-vserver.org> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/mfd/axp20x.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 6ffbc11..47ce233 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -113,6 +113,30 @@ static struct resource axp20x_pek_resources[] = { > }, > }; > > +static struct resource axp20x_usb_power_supply_resources[] = { > + { > + .name = "VBUS_PLUGIN", > + .start = AXP20X_IRQ_VBUS_PLUGIN, > + .end = AXP20X_IRQ_VBUS_PLUGIN, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_REMOVAL", > + .start = AXP20X_IRQ_VBUS_REMOVAL, > + .end = AXP20X_IRQ_VBUS_REMOVAL, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_VALID", > + .start = AXP20X_IRQ_VBUS_VALID, > + .end = AXP20X_IRQ_VBUS_VALID, > + .flags = IORESOURCE_IRQ, > + }, { > + .name = "VBUS_NOT_VALID", > + .start = AXP20X_IRQ_VBUS_NOT_VALID, > + .end = AXP20X_IRQ_VBUS_NOT_VALID, > + .flags = IORESOURCE_IRQ, > + }, > +}; Can you take a look at the DEFINE_RES_* macros in include/linux/ioport.h please? > static struct resource axp22x_pek_resources[] = { > { > .name = "PEK_DBR", > @@ -165,7 +189,7 @@ static const struct regmap_config axp20x_regmap_config = { > .val_bits = 8, > .wr_table = &axp20x_writeable_table, > .volatile_table = &axp20x_volatile_table, > - .max_register = AXP20X_FG_RES, > + .max_register = AXP20X_OCV(15), > .cache_type = REGCACHE_RBTREE, > }; > > @@ -368,6 +392,12 @@ static struct mfd_cell axp20x_cells[] = { > .resources = axp20x_pek_resources, > }, { > .name = "axp20x-regulator", > + }, { > + .name = "axp20x-usb-power-supply", > + .of_compatible = "x-powers,axp202-usb-power-supply", > + .num_resources = > + ARRAY_SIZE(axp20x_usb_power_supply_resources), This wrap is only necessary due to the extreme tabbing used to line up the '='. Please do something about that instead. > + .resources = axp20x_usb_power_supply_resources, > }, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-06-10 7:35 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-09 21:37 [PATCH 0/8] mfd/power/phy: Add support for otg vbus detection via axp pmic Hans de Goede 2015-06-09 21:37 ` Hans de Goede 2015-06-09 21:37 ` [PATCH 1/8] mfd: axp20x: Add missing registers, and mark more registers volatile Hans de Goede 2015-06-09 21:37 ` Hans de Goede [not found] ` <1433885881-19809-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-10 7:36 ` Lee Jones 2015-06-10 7:36 ` Lee Jones 2015-06-09 21:37 ` [PATCH 3/8] power: Add devm_power_supply_get_by_phandle() helper function Hans de Goede 2015-06-09 21:37 ` Hans de Goede 2015-06-10 14:49 ` Sebastian Reichel 2015-06-10 14:49 ` Sebastian Reichel 2015-06-09 21:38 ` [PATCH 8/8] ARM: dts: sun7i: Enable USB DRC on Bananapi Hans de Goede 2015-06-09 21:38 ` Hans de Goede [not found] ` <1433885881-19809-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-09 21:37 ` [PATCH 2/8] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Hans de Goede 2015-06-09 21:37 ` Hans de Goede [not found] ` <1433885881-19809-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-10 1:19 ` Chen-Yu Tsai 2015-06-10 1:19 ` [linux-sunxi] " Chen-Yu Tsai [not found] ` <CAGb2v652W+i6L1k5-CnHtXZXdJjFswkcyFGromhWSYaXtitW_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-06-10 7:57 ` Hans de Goede 2015-06-10 7:57 ` [linux-sunxi] " Hans de Goede [not found] ` <5577EDD9.8020900-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-13 13:50 ` Maxime Ripard 2015-06-13 13:50 ` [linux-sunxi] " Maxime Ripard 2015-06-24 12:18 ` Michal Suchanek 2015-06-24 12:18 ` [linux-sunxi] " Michal Suchanek 2015-06-10 7:35 ` Lee Jones [this message] 2015-06-10 7:35 ` Lee Jones 2015-06-10 7:36 ` Lee Jones 2015-06-10 7:36 ` Lee Jones 2015-06-09 21:37 ` [PATCH 4/8] power: Add an axp20x-usb-power driver Hans de Goede 2015-06-09 21:37 ` Hans de Goede 2015-06-10 7:29 ` Lee Jones 2015-06-10 7:29 ` Lee Jones 2015-06-10 9:22 ` Hans de Goede 2015-06-10 9:22 ` Hans de Goede [not found] ` <557801B8.5040804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-10 9:34 ` Lee Jones 2015-06-10 9:34 ` Lee Jones 2015-06-09 21:37 ` [PATCH 5/8] phy-sun4i-usb: Add support for monitoring vbus via a power-supply Hans de Goede 2015-06-09 21:37 ` Hans de Goede 2015-06-09 21:37 ` [PATCH 6/8] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node Hans de Goede 2015-06-09 21:37 ` Hans de Goede [not found] ` <1433885881-19809-7-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-07-31 5:31 ` Chen-Yu Tsai 2015-07-31 5:31 ` [linux-sunxi] " Chen-Yu Tsai [not found] ` <CAGb2v66X79dK84hG8NVTho-kPPMNcKXQspvT2pCM8Zbmnme53A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-31 5:51 ` Bruno Prémont 2015-07-31 5:51 ` [linux-sunxi] " Bruno Prémont 2015-07-31 6:14 ` Chen-Yu Tsai 2015-07-31 6:14 ` Chen-Yu Tsai [not found] ` <CAGb2v67nM7pauyjyhBdfgX7p_Rud6TEsNqphB+gx4ROekVqtbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-31 6:35 ` Bruno Prémont 2015-07-31 6:35 ` [linux-sunxi] " Bruno Prémont 2015-07-31 7:57 ` Maxime Ripard 2015-07-31 7:57 ` Maxime Ripard [not found] ` <20150731083541.5f2c683a-I2t2yFIzmohO7ya8xxV06g@public.gmane.org> 2015-07-31 8:31 ` Hans de Goede 2015-07-31 8:31 ` Hans de Goede [not found] ` <55BB3262.5000403-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-07-31 9:00 ` Chen-Yu Tsai 2015-07-31 9:00 ` [linux-sunxi] " Chen-Yu Tsai [not found] ` <CAGb2v66+CZe0v=CuYOLfnNwkX70kwPOP28Nya2Y8xw8yrg4-8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-31 9:11 ` Hans de Goede 2015-07-31 9:11 ` Hans de Goede [not found] ` <55BB3BCB.6080608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-07-31 10:06 ` Chen-Yu Tsai 2015-07-31 10:06 ` [linux-sunxi] " Chen-Yu Tsai 2015-07-31 9:14 ` Hans de Goede 2015-07-31 9:14 ` Hans de Goede 2015-06-09 21:38 ` [PATCH 7/8] ARM: dts: sun7i: Add regulator configuration to the bananapi dts file Hans de Goede 2015-06-09 21:38 ` Hans de Goede 2015-06-10 6:15 ` [PATCH 0/8] mfd/power/phy: Add support for otg vbus detection via axp pmic Priit Laes 2015-06-10 6:15 ` [linux-sunxi] " Priit Laes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150610073514.GW2982@x1 \ --to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \ --cc=balbi-l0cyMroinI0@public.gmane.org \ --cc=bonbons-ud5FBsm0p/xEiooADzr8i9i2O/JbrIOy@public.gmane.org \ --cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=kishon-l0cyMroinI0@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.