* re: drm/tilcdc: Add support for external tda998x encoder
@ 2015-06-11 15:11 Dan Carpenter
2015-06-11 19:01 ` Jyri Sarha
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-06-11 15:11 UTC (permalink / raw)
To: jsarha; +Cc: dri-devel
Hello Jyri Sarha,
This is a semi-automatic email about new static checker warnings.
The patch 103cd8bc1c80: "drm/tilcdc: Add support for external tda998x
encoder" from Feb 10, 2015, leads to the following Smatch complaint:
drivers/gpu/drm/tilcdc/tilcdc_external.c:153 tilcdc_get_external_components()
error: we previously assumed 'node' could be null (see line 148)
drivers/gpu/drm/tilcdc/tilcdc_external.c
147 node = of_graph_get_remote_port_parent(ep);
148 if (!node && !of_device_is_available(node)) {
^^^^
This test is probably reversed?
149 of_node_put(node);
^^^^
NULL.
150 continue;
151 }
152
153 dev_dbg(dev, "Subdevice node '%s' found\n", node->name);
^^^^^^^^^^^
Unchecked dereference.
154 if (match)
155 component_match_add(dev, match, dev_match_of, node);
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drm/tilcdc: Add support for external tda998x encoder
2015-06-11 15:11 drm/tilcdc: Add support for external tda998x encoder Dan Carpenter
@ 2015-06-11 19:01 ` Jyri Sarha
0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2015-06-11 19:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Valkeinen, Tomi, dri-devel
On 06/11/15 18:11, Dan Carpenter wrote:
> Hello Jyri Sarha,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 103cd8bc1c80: "drm/tilcdc: Add support for external tda998x
> encoder" from Feb 10, 2015, leads to the following Smatch complaint:
>
> drivers/gpu/drm/tilcdc/tilcdc_external.c:153 tilcdc_get_external_components()
> error: we previously assumed 'node' could be null (see line 148)
>
> drivers/gpu/drm/tilcdc/tilcdc_external.c
> 147 node = of_graph_get_remote_port_parent(ep);
> 148 if (!node && !of_device_is_available(node)) {
> ^^^^
>
> This test is probably reversed?
>
Not reversed, but the && should be ||. Then we always hit the
"continue", if node == NULL.
I'll make a fix for this tomorrow.
Thanks,
Jyri
> 149 of_node_put(node);
> ^^^^
> NULL.
>
> 150 continue;
> 151 }
> 152
> 153 dev_dbg(dev, "Subdevice node '%s' found\n", node->name);
> ^^^^^^^^^^^
> Unchecked dereference.
>
> 154 if (match)
> 155 component_match_add(dev, match, dev_match_of, node);
>
> regards,
> dan carpenter
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-11 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-11 15:11 drm/tilcdc: Add support for external tda998x encoder Dan Carpenter
2015-06-11 19:01 ` Jyri Sarha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.