[PATCH] selftests/kdbus: handle cap_get_proc() error properly

[PATCH] selftests/kdbus: handle cap_get_proc() error properly

[Sergei Zviagintsev]

Fix typo in checking error value of cap_get_proc(): cap -> caps

Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
---
 tools/testing/selftests/kdbus/kdbus-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kdbus/kdbus-util.c b/tools/testing/selftests/kdbus/kdbus-util.c
index 1e267d585a14..a3e49b04f3a7 100644
--- a/tools/testing/selftests/kdbus/kdbus-util.c
+++ b/tools/testing/selftests/kdbus/kdbus-util.c
@@ -1547,7 +1547,7 @@ int test_is_capable(int cap, ...)
 	cap_t caps;
 
 	caps = cap_get_proc();
-	if (!cap) {
+	if (!caps) {
 		ret = -errno;
 		kdbus_printf("error cap_get_proc(): %d (%m)\n", ret);
 		return ret;
-- 
1.8.3.1

Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly

[Greg Kroah-Hartman]

On Wed, Jun 17, 2015 at 05:18:13PM +0300, Sergei Zviagintsev wrote:
> Fix typo in checking error value of cap_get_proc(): cap -> caps
> 
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
>  tools/testing/selftests/kdbus/kdbus-util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You sent 5 patches, yet no hints as to what order they should be applied
in :(

Please resend in a patch series that is properly threaded so we can
handle this correctly.

thanks,

greg k-h

Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly

[Greg Kroah-Hartman]

On Wed, Jun 17, 2015 at 05:18:13PM +0300, Sergei Zviagintsev wrote:
> Fix typo in checking error value of cap_get_proc(): cap -> caps
> 
> Signed-off-by: Sergei Zviagintsev <sergei-E844GTqJAzo@public.gmane.org>
> ---
>  tools/testing/selftests/kdbus/kdbus-util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You sent 5 patches, yet no hints as to what order they should be applied
in :(

Please resend in a patch series that is properly threaded so we can
handle this correctly.

thanks,

greg k-h

Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly

[Sergei Zviagintsev]

Hi Greg,

On Wed, Jun 17, 2015 at 07:37:20AM -0700, Greg Kroah-Hartman wrote:
> You sent 5 patches, yet no hints as to what order they should be applied
> in :(
> 
> Please resend in a patch series that is properly threaded so we can
> handle this correctly.

Thank you for feedback! I've resent series threaded:
http://lkml.kernel.org/g/1434558808-16129-1-git-send-email-sergei@s15v.net

It was unclear for me whether to use threaded layout and whether not,
but now it seems that I got it. Though those applied fine in any order
and had no chances to piss of a kernel maintainer :)

Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly

[Sergei Zviagintsev]

Hi Greg,

On Wed, Jun 17, 2015 at 07:37:20AM -0700, Greg Kroah-Hartman wrote:
> You sent 5 patches, yet no hints as to what order they should be applied
> in :(
> 
> Please resend in a patch series that is properly threaded so we can
> handle this correctly.

Thank you for feedback! I've resent series threaded:
http://lkml.kernel.org/g/1434558808-16129-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org

It was unclear for me whether to use threaded layout and whether not,
but now it seems that I got it. Though those applied fine in any order
and had no chances to piss of a kernel maintainer :)