* [U-Boot] [PATCH] Fix default env includes to fix sandbox build
@ 2015-06-17 15:58 Peter Robinson
2015-06-18 2:04 ` Masahiro Yamada
2015-06-18 22:46 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Peter Robinson @ 2015-06-17 15:58 UTC (permalink / raw)
To: u-boot
defconfig and sandbox fails to build due to a with with the following error:
error: expected '}' before 'BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX'
CONFIG_EXTRA_ENV_SETTINGS
Based on the responaes below to the thread add linux/kconfig.h higher in th includes
and drop the now unneeded autoconf.h lower down to ensure the default environment is
included correctly
http://lists.denx.de/pipermail/u-boot/2015-June/216849.html
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
tools/env/fw_env.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
index d6faf34..60c0517 100644
--- a/tools/env/fw_env.h
+++ b/tools/env/fw_env.h
@@ -6,6 +6,8 @@
*/
/* Pull in the current config to define the default environment */
+#include <linux/kconfig.h>
+
#ifndef __ASSEMBLY__
#define __ASSEMBLY__ /* get only #defines from config.h */
#include <config.h>
@@ -13,7 +15,6 @@
#else
#include <config.h>
#endif
-#include <generated/autoconf.h>
/*
* To build the utility with the static configuration
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Fix default env includes to fix sandbox build
2015-06-17 15:58 [U-Boot] [PATCH] Fix default env includes to fix sandbox build Peter Robinson
@ 2015-06-18 2:04 ` Masahiro Yamada
2015-06-18 11:51 ` Tom Rini
2015-06-18 22:46 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2015-06-18 2:04 UTC (permalink / raw)
To: u-boot
Hi Peter,
The subject "Fix default env includes to fix sandbox build" sounds
confusing to me.
I can currently build sandbox because tools/env is not built by default.
We hit this problem when we do "make env" or "make tools-all".
2015-06-18 0:58 GMT+09:00 Peter Robinson <pbrobinson@gmail.com>:
> defconfig and sandbox fails to build due to a with with the following error:
>
> error: expected '}' before 'BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX'
> CONFIG_EXTRA_ENV_SETTINGS
>
> Based on the responaes below to the thread add linux/kconfig.h higher in th includes
> and drop the now unneeded autoconf.h lower down to ensure the default environment is
> included correctly
>
> http://lists.denx.de/pipermail/u-boot/2015-June/216849.html
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> tools/env/fw_env.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
> index d6faf34..60c0517 100644
> --- a/tools/env/fw_env.h
> +++ b/tools/env/fw_env.h
> @@ -6,6 +6,8 @@
> */
>
> /* Pull in the current config to define the default environment */
> +#include <linux/kconfig.h>
> +
> #ifndef __ASSEMBLY__
> #define __ASSEMBLY__ /* get only #defines from config.h */
> #include <config.h>
> @@ -13,7 +15,6 @@
> #else
> #include <config.h>
> #endif
> -#include <generated/autoconf.h>
>
> /*
> * To build the utility with the static configuration
> --
> 2.4.3
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Fix default env includes to fix sandbox build
2015-06-18 2:04 ` Masahiro Yamada
@ 2015-06-18 11:51 ` Tom Rini
2015-06-18 12:35 ` Peter Robinson
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2015-06-18 11:51 UTC (permalink / raw)
To: u-boot
On Thu, Jun 18, 2015 at 11:04:59AM +0900, Masahiro Yamada wrote:
> Hi Peter,
>
>
> The subject "Fix default env includes to fix sandbox build" sounds
> confusing to me.
>
> I can currently build sandbox because tools/env is not built by default.
>
> We hit this problem when we do "make env" or "make tools-all".
Yes, I'll re-word slightly when pushing.
>
>
>
>
> 2015-06-18 0:58 GMT+09:00 Peter Robinson <pbrobinson@gmail.com>:
> > defconfig and sandbox fails to build due to a with with the following error:
> >
> > error: expected '}' before 'BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX'
> > CONFIG_EXTRA_ENV_SETTINGS
> >
> > Based on the responaes below to the thread add linux/kconfig.h higher in th includes
> > and drop the now unneeded autoconf.h lower down to ensure the default environment is
> > included correctly
> >
> > http://lists.denx.de/pipermail/u-boot/2015-June/216849.html
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> > tools/env/fw_env.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
> > index d6faf34..60c0517 100644
> > --- a/tools/env/fw_env.h
> > +++ b/tools/env/fw_env.h
> > @@ -6,6 +6,8 @@
> > */
> >
> > /* Pull in the current config to define the default environment */
> > +#include <linux/kconfig.h>
> > +
> > #ifndef __ASSEMBLY__
> > #define __ASSEMBLY__ /* get only #defines from config.h */
> > #include <config.h>
> > @@ -13,7 +15,6 @@
> > #else
> > #include <config.h>
> > #endif
> > -#include <generated/autoconf.h>
> >
> > /*
> > * To build the utility with the static configuration
> > --
> > 2.4.3
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150618/bef5828c/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Fix default env includes to fix sandbox build
2015-06-18 11:51 ` Tom Rini
@ 2015-06-18 12:35 ` Peter Robinson
0 siblings, 0 replies; 5+ messages in thread
From: Peter Robinson @ 2015-06-18 12:35 UTC (permalink / raw)
To: u-boot
On Thu, Jun 18, 2015 at 12:51 PM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Jun 18, 2015 at 11:04:59AM +0900, Masahiro Yamada wrote:
>
>> Hi Peter,
>>
>>
>> The subject "Fix default env includes to fix sandbox build" sounds
>> confusing to me.
>>
>> I can currently build sandbox because tools/env is not built by default.
>>
>> We hit this problem when we do "make env" or "make tools-all".
>
> Yes, I'll re-word slightly when pushing.
Great, thanks,
Peter
>>
>>
>>
>>
>> 2015-06-18 0:58 GMT+09:00 Peter Robinson <pbrobinson@gmail.com>:
>> > defconfig and sandbox fails to build due to a with with the following error:
>> >
>> > error: expected '}' before 'BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX'
>> > CONFIG_EXTRA_ENV_SETTINGS
>> >
>> > Based on the responaes below to the thread add linux/kconfig.h higher in th includes
>> > and drop the now unneeded autoconf.h lower down to ensure the default environment is
>> > included correctly
>> >
>> > http://lists.denx.de/pipermail/u-boot/2015-June/216849.html
>> >
>> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> > ---
>> > tools/env/fw_env.h | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
>> > index d6faf34..60c0517 100644
>> > --- a/tools/env/fw_env.h
>> > +++ b/tools/env/fw_env.h
>> > @@ -6,6 +6,8 @@
>> > */
>> >
>> > /* Pull in the current config to define the default environment */
>> > +#include <linux/kconfig.h>
>> > +
>> > #ifndef __ASSEMBLY__
>> > #define __ASSEMBLY__ /* get only #defines from config.h */
>> > #include <config.h>
>> > @@ -13,7 +15,6 @@
>> > #else
>> > #include <config.h>
>> > #endif
>> > -#include <generated/autoconf.h>
>> >
>> > /*
>> > * To build the utility with the static configuration
>> > --
>> > 2.4.3
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> --
> Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] Fix default env includes to fix sandbox build
2015-06-17 15:58 [U-Boot] [PATCH] Fix default env includes to fix sandbox build Peter Robinson
2015-06-18 2:04 ` Masahiro Yamada
@ 2015-06-18 22:46 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2015-06-18 22:46 UTC (permalink / raw)
To: u-boot
On Wed, Jun 17, 2015 at 04:58:32PM +0100, Peter Robinson wrote:
> defconfig and sandbox fails to build due to a with with the following error:
>
> error: expected '}' before 'BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX'
> CONFIG_EXTRA_ENV_SETTINGS
>
> Based on the responaes below to the thread add linux/kconfig.h higher in th includes
> and drop the now unneeded autoconf.h lower down to ensure the default environment is
> included correctly
>
> http://lists.denx.de/pipermail/u-boot/2015-June/216849.html
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Reworded the commit message and applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150618/344a41a9/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-18 22:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-17 15:58 [U-Boot] [PATCH] Fix default env includes to fix sandbox build Peter Robinson
2015-06-18 2:04 ` Masahiro Yamada
2015-06-18 11:51 ` Tom Rini
2015-06-18 12:35 ` Peter Robinson
2015-06-18 22:46 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.