Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

[Alexandre Belloni]

On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote :
> This simplifies the error checking of the function,at91sam9261_udc_init
> by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary
> if statement to check the return value of a call to the function,
> syscon_regmap_lookup_by_phandle by checking with a call to the function,
> IS_ERR and returning a error pointer if there is one for the function,
> at91sam9261_udc_init. Furthermore this was found by running coccinelle
> against the lastest kernel tree.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

[Alexandre Belloni]

On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote :
> On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote :
> > This simplifies the error checking of the function,at91sam9261_udc_init
> > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary
> > if statement to check the return value of a call to the function,
> > syscon_regmap_lookup_by_phandle by checking with a call to the function,
> > IS_ERR and returning a error pointer if there is one for the function,
> > at91sam9261_udc_init. Furthermore this was found by running coccinelle
> > against the lastest kernel tree.
> > 
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 

OK, it seems the original patch got ignored by all the mailing lists. To
bad, that one was actually applicable :)

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

[Greg KH]

On Thu, Jun 18, 2015 at 09:04:52PM +0200, Alexandre Belloni wrote:
> On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote :
> > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote :
> > > This simplifies the error checking of the function,at91sam9261_udc_init
> > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary
> > > if statement to check the return value of a call to the function,
> > > syscon_regmap_lookup_by_phandle by checking with a call to the function,
> > > IS_ERR and returning a error pointer if there is one for the function,
> > > at91sam9261_udc_init. Furthermore this was found by running coccinelle
> > > against the lastest kernel tree.
> > > 
> > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > 
> 
> OK, it seems the original patch got ignored by all the mailing lists. To
> bad, that one was actually applicable :)

Nick is banned from vger.kernel.org, so that is why his patches will not
ever show up.  I recommend that you do the same if possible.

greg k-h