All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kukjin Kim <kgene@kernel.org>,
	linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] pinctrl: samsung: don't truncate the last char of "-grp"
Date: Fri, 19 Jun 2015 11:52:03 +0300	[thread overview]
Message-ID: <20150619085203.GO28762@mwanda> (raw)
In-Reply-To: <CAJKOXPe8Pv5t9tLdFZAV+9CSiM302GTVt6_j3vKHkeFOK8U=Lw@mail.gmail.com>

On Mon, Jun 15, 2015 at 01:17:36PM +0900, Krzysztof Kozlowski wrote:
> I would prefer splitting this into two patches: one for fixing
> truncated name (by usage of kasprintf) and second for ENOMEM message.
> The second patch can get rid of ENOMEM message in other places as
> well.
> 
> As for the first issue I think that function suffix would also be
> truncated in the same way.

Sorry for the delayed response, I've been offline for a few days.

Yeah, you're right.

Let me resend.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kukjin Kim <kgene@kernel.org>,
	linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] pinctrl: samsung: don't truncate the last char of "-grp"
Date: Fri, 19 Jun 2015 08:52:03 +0000	[thread overview]
Message-ID: <20150619085203.GO28762@mwanda> (raw)
In-Reply-To: <CAJKOXPe8Pv5t9tLdFZAV+9CSiM302GTVt6_j3vKHkeFOK8U=Lw@mail.gmail.com>

On Mon, Jun 15, 2015 at 01:17:36PM +0900, Krzysztof Kozlowski wrote:
> I would prefer splitting this into two patches: one for fixing
> truncated name (by usage of kasprintf) and second for ENOMEM message.
> The second patch can get rid of ENOMEM message in other places as
> well.
> 
> As for the first issue I think that function suffix would also be
> truncated in the same way.

Sorry for the delayed response, I've been offline for a few days.

Yeah, you're right.

Let me resend.

regards,
dan carpenter


  reply	other threads:[~2015-06-19  8:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 15:46 [patch] pinctrl: samsung: don't truncate the last char of "-grp" Dan Carpenter
2015-06-11 15:46 ` Dan Carpenter
2015-06-15  4:17 ` Krzysztof Kozlowski
2015-06-15  4:17   ` Krzysztof Kozlowski
2015-06-19  8:52   ` Dan Carpenter [this message]
2015-06-19  8:52     ` Dan Carpenter
2015-06-22 15:12     ` [patch v2 1/2] pinctrl: samsung: don't truncate the last char Dan Carpenter
2015-06-22 15:12       ` Dan Carpenter
2015-06-22 15:12       ` Dan Carpenter
2015-06-22 15:12       ` Dan Carpenter
2015-06-22 23:51       ` Krzysztof Kozlowski
2015-06-22 23:51         ` Krzysztof Kozlowski
2015-06-22 23:51         ` Krzysztof Kozlowski
2015-06-22 23:51         ` Krzysztof Kozlowski
2015-07-16  8:21       ` Linus Walleij
2015-07-16  8:21         ` Linus Walleij
2015-07-16  8:21         ` Linus Walleij
2015-07-16  8:21         ` Linus Walleij
2015-06-22 15:13     ` [patch v2 2/2] pinctrl: samsung: remove "out of memory" messages Dan Carpenter
2015-06-22 15:13       ` Dan Carpenter
2015-06-22 15:13       ` Dan Carpenter
2015-06-22 15:13       ` Dan Carpenter
2015-06-22 23:53       ` Krzysztof Kozlowski
2015-06-22 23:53         ` Krzysztof Kozlowski
2015-06-22 23:53         ` Krzysztof Kozlowski
2015-06-22 23:53         ` Krzysztof Kozlowski
2015-07-16  8:22       ` Linus Walleij
2015-07-16  8:22         ` Linus Walleij
2015-07-16  8:22         ` Linus Walleij
2015-07-16  8:22         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619085203.GO28762@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thomas.abraham@linaro.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.