Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device

From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org
Subject: Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device
Date: Mon, 22 Jun 2015 13:55:41 -0400	[thread overview]
Message-ID: <20150622175541.GB2965@redhat.com> (raw)
In-Reply-To: <20150622175255.GB3710@mtj.duckdns.org>

On Mon, Jun 22, 2015 at 01:52:55PM -0400, Tejun Heo wrote:
> Hello,
> 
> On Mon, Jun 22, 2015 at 01:46:48PM -0400, Vivek Goyal wrote:
> > Subject: fs/block_dev.c: Warn on inode writeback failure instead of WARN_ON()
> > 
> > If a block device is hot removed and later last reference to devices
> > is put, we try to writeback the dirty inode. But device is gone and
> > that writeback fails.
> > 
> > Currently we do a WARN_ON() which does not seem to be the right thing.
> > Convert it to a ratelimited kernel warning.
> 
> Yeah, looks good to me.  Just one nit.
> 
> ...
> > +		if (write_inode_now(inode, true)) {
> > +			char name[BDEVNAME_SIZE] = "";
> > +			pr_warn_ratelimited("VFS: Dirty inode writeback failed for block device %s.\n", bdevname(bdev, name));
> 
> This wasn't reported before either but maybe we wanna report the errno
> too?  Also, don't we usually break the line for parameters?
> 
> 	pr_..("long format string going over 80 col...\n",
> 	      param0, param1, ...);

Hi Tejun, 

Will do. I have been doing some go programming in docker recently and this
has been a side effect of that. :-) Will format it correctly.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/