* [PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.
@ 2015-06-18 22:46 Ralf Baechle
2015-06-23 10:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2015-06-18 22:46 UTC (permalink / raw)
To: David S. Miller, netdev, linux-hams, stable
A ROSE socket doesn't necessarily always have a neighbour pointer so check
if the neighbour pointer is valid before dereferencing it.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Tested-by: Bernard Pidoux <f6bvp@free.fr>
Cc: stable@vger.kernel.org #2.6.11+
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index 8ae6030..dd304bc 100644
--- a/net/rose/af_rose.c
+++ b/net/rose/af_rose.c
@@ -192,7 +192,8 @@ static void rose_kill_by_device(struct net_device *dev)
if (rose->device == dev) {
rose_disconnect(s, ENETUNREACH, ROSE_OUT_OF_ORDER, 0);
- rose->neighbour->use--;
+ if (rose->neighbour)
+ rose->neighbour->use--;
rose->device = NULL;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.
2015-06-18 22:46 [PATCH] NET: ROSE: Don't dereference NULL neighbour pointer Ralf Baechle
@ 2015-06-23 10:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-23 10:26 UTC (permalink / raw)
To: ralf; +Cc: netdev, linux-hams, stable
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 19 Jun 2015 00:46:53 +0200
> A ROSE socket doesn't necessarily always have a neighbour pointer so check
> if the neighbour pointer is valid before dereferencing it.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> Tested-by: Bernard Pidoux <f6bvp@free.fr>
> Cc: stable@vger.kernel.org #2.6.11+
Applied, thanks Ralf.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-23 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-18 22:46 [PATCH] NET: ROSE: Don't dereference NULL neighbour pointer Ralf Baechle
2015-06-23 10:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.