All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave P Martin <Dave.Martin@arm.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Robin Murphy" <Robin.Murphy@arm.com>,
	"popcorn mix" <popcornmix@gmail.com>,
	"Jakub Kiciński" <moorray3@wp.pl>,
	"Andrew Jackson" <Andrew.Jackson@arm.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Graeme Gregory" <gg@slimlogic.co.uk>,
	"Andre Przywara" <Andre.Przywara@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Jorge Ramirez-Ortiz" <jorge.ramirez-ortiz@linaro.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH] serial/amba-pl011: Disable interrupts around TX softirq
Date: Tue, 23 Jun 2015 12:13:10 +0100	[thread overview]
Message-ID: <20150623111310.GB3645@e103592.cambridge.arm.com> (raw)
In-Reply-To: <416658426.177742.1434791378036.JavaMail.open-xchange@oxbsltgw09.schlund.de>

On Sat, Jun 20, 2015 at 10:09:37AM +0100, Stefan Wahren wrote:
> 
> > Dave Martin <Dave.Martin@arm.com> hat am 18. Juni 2015 um 15:54 geschrieben:
> >
> >
> > pl011_tx_softirq() currently uses spin_{,un}lock(), which are not
> > sufficient to inhibit pl011_int() from being triggered by a local
> > IRQ and trying to re-take the same lock. This can lead to
> > deadlocks.
> >
> > This patch uses the _irq() locking variants instead to ensure that
> > pl011_int() handling for a given port is deferred until any
> > pl011_tx_softirq() work for that port is complete.
> >
> > Fixes: 734745caeb9f serial/amba-pl011: Activate TX IRQ passively
> > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> > Tested-by: Robin Murphy <robin.murphy@arm.com>
> > Cc: stable <stable@vger.kernel.org> # 4.1
> >
> 
> I also get info messages about inconsistent lock state on my mx28 board,
> after applying the patch the messages disappeared.
> 
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks for the confirmation.

Cheers
---Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave.Martin@arm.com (Dave P Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/amba-pl011: Disable interrupts around TX softirq
Date: Tue, 23 Jun 2015 12:13:10 +0100	[thread overview]
Message-ID: <20150623111310.GB3645@e103592.cambridge.arm.com> (raw)
In-Reply-To: <416658426.177742.1434791378036.JavaMail.open-xchange@oxbsltgw09.schlund.de>

On Sat, Jun 20, 2015 at 10:09:37AM +0100, Stefan Wahren wrote:
> 
> > Dave Martin <Dave.Martin@arm.com> hat am 18. Juni 2015 um 15:54 geschrieben:
> >
> >
> > pl011_tx_softirq() currently uses spin_{,un}lock(), which are not
> > sufficient to inhibit pl011_int() from being triggered by a local
> > IRQ and trying to re-take the same lock. This can lead to
> > deadlocks.
> >
> > This patch uses the _irq() locking variants instead to ensure that
> > pl011_int() handling for a given port is deferred until any
> > pl011_tx_softirq() work for that port is complete.
> >
> > Fixes: 734745caeb9f serial/amba-pl011: Activate TX IRQ passively
> > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> > Tested-by: Robin Murphy <robin.murphy@arm.com>
> > Cc: stable <stable@vger.kernel.org> # 4.1
> >
> 
> I also get info messages about inconsistent lock state on my mx28 board,
> after applying the patch the messages disappeared.
> 
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks for the confirmation.

Cheers
---Dave

  reply	other threads:[~2015-06-23 11:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 13:54 [PATCH] serial/amba-pl011: Disable interrupts around TX softirq Dave Martin
2015-06-18 13:54 ` Dave Martin
2015-06-20  9:09 ` Stefan Wahren
2015-06-20  9:09   ` Stefan Wahren
2015-06-20  9:09   ` Stefan Wahren
2015-06-23 11:13   ` Dave P Martin [this message]
2015-06-23 11:13     ` Dave P Martin
  -- strict thread matches above, loose matches on Subject: below --
2015-07-09 10:57 Dave Martin
2015-07-09 10:57 ` Dave Martin
2015-07-23 22:05 ` Greg Kroah-Hartman
2015-07-23 22:05   ` Greg Kroah-Hartman
2015-07-24  9:56   ` Dave Martin
2015-07-24  9:56     ` Dave Martin
2015-07-24 15:15     ` Greg Kroah-Hartman
2015-07-24 15:15       ` Greg Kroah-Hartman
2015-07-24 16:46       ` Dave Martin
2015-07-24 16:46         ` Dave Martin
2015-06-05 14:07 Dave Martin
2015-06-05 14:07 ` Dave Martin
2015-06-05 18:03 ` Robin Murphy
2015-06-05 18:03   ` Robin Murphy
2015-06-08 10:34   ` Robin Murphy
2015-06-08 10:34     ` Robin Murphy
2015-06-08 11:34     ` Dave P Martin
2015-06-08 11:34       ` Dave P Martin
2015-06-13  0:39 ` Greg Kroah-Hartman
2015-06-13  0:39   ` Greg Kroah-Hartman
2015-06-15 10:53   ` Dave P Martin
2015-06-15 10:53     ` Dave P Martin
2015-06-15 11:09   ` Andre Przywara
2015-06-15 11:09     ` Andre Przywara
2015-06-15 14:03     ` Dave Martin
2015-06-15 14:03       ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623111310.GB3645@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=Andre.Przywara@arm.com \
    --cc=Andrew.Jackson@arm.com \
    --cc=Robin.Murphy@arm.com \
    --cc=gg@slimlogic.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=moorray3@wp.pl \
    --cc=popcornmix@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.