From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] Revert "libxl: fix "xl mem-set" regression from 0c029c4da2"
Date: Tue, 23 Jun 2015 15:52:08 +0100 [thread overview]
Message-ID: <20150623145208.GC28647@zion.uk.xensource.com> (raw)
In-Reply-To: <55898D1A0200007800088660@mail.emea.novell.com>
On Tue, Jun 23, 2015 at 03:45:14PM +0100, Jan Beulich wrote:
> >>> On 23.06.15 at 16:16, <wei.liu2@citrix.com> wrote:
> > This reverts commit f5b43e95facdc17f925cb56a8963cd4531074034.
>
> Even if the patch having introduced the regression this fixed is
> being reverted, it's not clear to me why this change needs to be
> reverted too - it seems correct to me to use 64-bit types for the
> calculations. Or are you planning to do a more comprehensive
> adjustments to all of the types later on?
>
I was thinking more about giving Ian (who is looking at making things
consistent) a clean state to start with. He may end up touching those
types.
This patch itself looks correct to me.
Ian, I think I will send a patch to revert the only offending commit and
fix up conflicts. Are you OK with that.
Wei.
next prev parent reply other threads:[~2015-06-23 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 14:16 [PATCH 0/2] Revert changes to libxl_set_memory_target, unblock 4.6 Wei Liu
2015-06-23 14:16 ` [PATCH 1/2] Revert "libxl: fix "xl mem-set" regression from 0c029c4da2" Wei Liu
2015-06-23 14:24 ` Konrad Rzeszutek Wilk
2015-06-23 14:45 ` Jan Beulich
2015-06-23 14:52 ` Wei Liu [this message]
2015-06-23 15:00 ` Ian Campbell
2015-06-23 14:16 ` [PATCH 2/2] Revert "libxl_set_memory_target: retain the same maxmem offset on top of the current target" Wei Liu
2015-06-23 14:19 ` [PATCH 0/2] Revert changes to libxl_set_memory_target, unblock 4.6 Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623145208.GC28647@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.