[PATCH 1/2] ASoC: gtm601: Fix modalias

[PATCH 1/2] ASoC: gtm601: Fix modalias

[Axel Lin]

The MODULE_ALIAS needs to match the driver name to make module auto-loading
work. Also move MODULE_ALIAS close to other MODULE_* macro.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/gtm601.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/gtm601.c b/sound/soc/codecs/gtm601.c
index 1b77ff2..a696e3e 100644
--- a/sound/soc/codecs/gtm601.c
+++ b/sound/soc/codecs/gtm601.c
@@ -70,8 +70,6 @@ static int gtm601_platform_remove(struct platform_device *pdev)
 	return 0;
 }
 
-MODULE_ALIAS("platform:gtm601_codec_audio");
-
 #if defined(CONFIG_OF)
 static const struct of_device_id gtm601_codec_of_match[] = {
 	{ .compatible = "option,gtm601", },
@@ -96,3 +94,4 @@ module_platform_driver(gtm601_codec_driver);
 MODULE_DESCRIPTION("ASoC gtm601 driver");
 MODULE_AUTHOR("Marek Belisko <marek@goldelico.com>");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:gtm601");
-- 
2.1.0

[PATCH 2/2] ASoC: gtm601: Remove .owner field from platform driver

[Axel Lin]

Remove .owner field because the core will set it.
Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601
const.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/gtm601.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/gtm601.c b/sound/soc/codecs/gtm601.c
index a696e3e..a652f19 100644
--- a/sound/soc/codecs/gtm601.c
+++ b/sound/soc/codecs/gtm601.c
@@ -51,7 +51,7 @@ struct snd_soc_dai_driver gtm601_dai = {
 	},
 };
 
-static struct snd_soc_codec_driver soc_codec_dev_gtm601 = {
+static const struct snd_soc_codec_driver soc_codec_dev_gtm601 = {
 	.dapm_widgets = gtm601_dapm_widgets,
 	.num_dapm_widgets = ARRAY_SIZE(gtm601_dapm_widgets),
 	.dapm_routes = gtm601_dapm_routes,
@@ -80,11 +80,9 @@ MODULE_DEVICE_TABLE(of, gtm601_codec_of_match);
 
 static struct platform_driver gtm601_codec_driver = {
 	.driver = {
-			.name = "gtm601",
-			.owner = THIS_MODULE,
-			.of_match_table = of_match_ptr(gtm601_codec_of_match),
+		.name = "gtm601",
+		.of_match_table = of_match_ptr(gtm601_codec_of_match),
 	},
-
 	.probe = gtm601_platform_probe,
 	.remove = gtm601_platform_remove,
 };
-- 
2.1.0

Re: [PATCH 1/2] ASoC: gtm601: Fix modalias

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 216 bytes --]

On Wed, Jun 24, 2015 at 10:55:24AM +0800, Axel Lin wrote:
> The MODULE_ALIAS needs to match the driver name to make module auto-loading
> work. Also move MODULE_ALIAS close to other MODULE_* macro.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 2/2] ASoC: gtm601: Remove .owner field from platform driver

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 261 bytes --]

On Wed, Jun 24, 2015 at 10:56:31AM +0800, Axel Lin wrote:
> Remove .owner field because the core will set it.
> Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601
> const.

This doesn't apply against current code, please check and resend.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 2/2] ASoC: gtm601: Remove .owner field from platform driver

[Axel Lin]

2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>:
> On Wed, Jun 24, 2015 at 10:56:31AM +0800, Axel Lin wrote:
>> Remove .owner field because the core will set it.
>> Also clean up the code a bit to fix indent and make soc_codec_dev_gtm601
>> const.
>
> This doesn't apply against current code, please check and resend.
It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601.

Re: [PATCH 2/2] ASoC: gtm601: Remove .owner field from platform driver

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 368 bytes --]

On Wed, Jun 24, 2015 at 07:46:49PM +0800, Axel Lin wrote:
> 2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>:

> > This doesn't apply against current code, please check and resend.

> It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601.

The main bit is but it looked like you had some other changes which are
probably still worthwhile?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 2/2] ASoC: gtm601: Remove .owner field from platform driver

[Axel Lin]

2015-06-24 19:50 GMT+08:00 Mark Brown <broonie@kernel.org>:
> On Wed, Jun 24, 2015 at 07:46:49PM +0800, Axel Lin wrote:
>> 2015-06-24 18:23 GMT+08:00 Mark Brown <broonie@kernel.org>:
>
>> > This doesn't apply against current code, please check and resend.
>
>> It's fixed by kbuild test robot <fengguang.wu@intel.com> in topic/gtm601.
>
> The main bit is but it looked like you had some other changes which are
> probably still worthwhile?

The sound/soc/codecs/gtm601.c does not exist in today's linux-next tree.
I'll check the code again once it appears on linux-next.