All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] leds: aat1290: Add 'static' modifier to init_mm_current_scale
@ 2015-06-19  7:32 Jacek Anaszewski
  2015-06-24 11:22 ` Sakari Ailus
  0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2015-06-19  7:32 UTC (permalink / raw)
  To: linux-leds, linux-media
  Cc: pavel, cooloney, rpurdie, sakari.ailus, s.nawrocki, Jacek Anaszewski

Fix sparse warning by adding static modifier to the function
init_mm_current_scale.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
 drivers/leds/leds-aat1290.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index 8635404..b055882 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -308,7 +308,7 @@ static void aat1290_led_validate_mm_current(struct aat1290_led *led,
 	cfg->max_brightness = b + 1;
 }
 
-int init_mm_current_scale(struct aat1290_led *led,
+static int init_mm_current_scale(struct aat1290_led *led,
 			struct aat1290_led_config_data *cfg)
 {
 	int max_mm_current_percent[] = { 20, 22, 25, 28, 32, 36, 40, 45, 50, 56,
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] leds: aat1290: Add 'static' modifier to init_mm_current_scale
  2015-06-19  7:32 [PATCH] leds: aat1290: Add 'static' modifier to init_mm_current_scale Jacek Anaszewski
@ 2015-06-24 11:22 ` Sakari Ailus
  0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2015-06-24 11:22 UTC (permalink / raw)
  To: Jacek Anaszewski
  Cc: linux-leds, linux-media, pavel, cooloney, rpurdie, s.nawrocki

On Fri, Jun 19, 2015 at 09:32:44AM +0200, Jacek Anaszewski wrote:
> Fix sparse warning by adding static modifier to the function
> init_mm_current_scale.
> 
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] leds: aat1290: add 'static' modifier to init_mm_current_scale
@ 2015-09-04 11:54 Jacek Anaszewski
  0 siblings, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2015-09-04 11:54 UTC (permalink / raw)
  To: linux-leds; +Cc: Jacek Anaszewski

Function init_mm_current_scale is used only locally. Make it static then.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
 drivers/leds/leds-aat1290.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index 8ceb471..ac77d36 100644
--- a/drivers/leds/leds-aat1290.c
+++ b/drivers/leds/leds-aat1290.c
@@ -331,7 +331,7 @@ static void aat1290_led_validate_mm_current(struct aat1290_led *led,
 	cfg->max_brightness = b + 1;
 }
 
-int init_mm_current_scale(struct aat1290_led *led,
+static int init_mm_current_scale(struct aat1290_led *led,
 			struct aat1290_led_config_data *cfg)
 {
 	int max_mm_current_percent[] = { 20, 22, 25, 28, 32, 36, 40, 45, 50, 56,
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-04 11:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-19  7:32 [PATCH] leds: aat1290: Add 'static' modifier to init_mm_current_scale Jacek Anaszewski
2015-06-24 11:22 ` Sakari Ailus
2015-09-04 11:54 [PATCH] leds: aat1290: add " Jacek Anaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.