[PATCH] staging: sm750fb: convert pr_err to pr_info

[PATCH] staging: sm750fb: convert pr_err to pr_info

[Gujulan Elango, Hari Prasath (H.)]

From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>

This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category.

Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
---
 drivers/staging/sm750fb/sm750.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 6b642d7..3f30bc0 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -338,7 +338,7 @@ static int lynxfb_ops_set_par(struct fb_info *info)
 	line_length = var->xres_virtual * var->bits_per_pixel / 8;
 	line_length = PADDING(crtc->line_pad, line_length);
 	fix->line_length = line_length;
-	pr_err("fix->line_length = %d\n", fix->line_length);
+	pr_info("fix->line_length = %d\n", fix->line_length);
 
 	/* var->red,green,blue,transp are need to be set by driver
 	 * and these data should be set before setcolreg routine
@@ -1021,8 +1021,8 @@ static void sm750fb_setup(struct lynx_share *share, char *src)
 	}
 
 	while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
-		pr_err("opt=%s\n", opt);
-		pr_err("src=%s\n", src);
+		pr_info("opt=%s\n", opt);
+		pr_info("src=%s\n", src);
 
 		if (!strncmp(opt, "swap", strlen("swap")))
 			swap = 1;
-- 
1.9.1

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

[Dan Carpenter]

On Thu, Jun 18, 2015 at 12:56:54PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
> 
> This patch modifies few debug prints from pr_err() to pr_info() as they
> fall under that category.
> 

They should be dbg or removed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

[Gujulan Elango, Hari Prasath (H.)]

On Monday 22 June 2015 08:46 PM, Dan Carpenter wrote:
> On Thu, Jun 18, 2015 at 12:56:54PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
>> From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
>>
>> This patch modifies few debug prints from pr_err() to pr_info() as they
>> fall under that category.
>>
> 
> They should be dbg or removed.
> 
> regards,
> dan carpenter
> 
> 


Thanks Dan.I shall send a v2 addressing the same.

-- 
thanks & regards,
Hari Prasath

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

[Gujulan Elango, Hari Prasath (H.)]

On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote:
> On Thu, Jun 18, 2015 at 12:56:54PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
> > 
> > This patch modifies few debug prints from pr_err() to pr_info() as they
> > fall under that category.
> > 
> 
> They should be dbg or removed.
> 
> regards,
> dan carpenter
> 

Dan,Greg has already merged this patch.Should I now send another patch
to convert this from pr_info() to pr_dbg() ?

Regards
Hari Prasath

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

[Dan Carpenter]

On Wed, Jun 24, 2015 at 04:32:38PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote:
> > On Thu, Jun 18, 2015 at 12:56:54PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > > From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
> > > 
> > > This patch modifies few debug prints from pr_err() to pr_info() as they
> > > fall under that category.
> > > 
> > 
> > They should be dbg or removed.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Dan,Greg has already merged this patch.Should I now send another patch
> to convert this from pr_info() to pr_dbg() ?

Nah.  Don't worry about it until someone complains.

Eventually all the debug output in this driver needs to be redone.

regards,
dan carpenter