From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: Unconditionally do fb tracking invalidate in set_domain
Date: Fri, 26 Jun 2015 18:35:21 +0100 [thread overview]
Message-ID: <20150626173521.GF14226@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1435340116-29538-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, Jun 26, 2015 at 07:35:16PM +0200, Daniel Vetter wrote:
> We can't elide the fb tracking invalidate if the buffer is already in
> the right domain since that would lead to missed screen updates. I'm
> pretty sure I've written this already before but must have gotten lost
> unfortunately :(
>
> v2: Chris observed that all internal set_domain users already
> correctly do the fb invalidate on their own, hence we can move this
> just into the set_domain ioctl instead.
>
> v3: I screwed up setting the invalidate ORIGIN_* correctly (Chris).
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-26 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 21:47 [PATCH 1/2] drm/i915: Unconditionally do fb tracking invalidate in set_domain Daniel Vetter
2015-06-25 21:47 ` [PATCH 2/2] drm/i915: Unique frontbuffer_bits for sprites Daniel Vetter
2015-06-29 11:32 ` shuang.he
2015-06-26 7:29 ` [PATCH 1/2] drm/i915: Unconditionally do fb tracking invalidate in set_domain Chris Wilson
2015-06-26 8:15 ` [PATCH] " Daniel Vetter
2015-06-26 9:52 ` Chris Wilson
2015-06-26 17:35 ` Daniel Vetter
2015-06-26 17:35 ` Chris Wilson [this message]
2015-06-26 20:02 ` Paulo Zanoni
2015-06-29 6:56 ` Daniel Vetter
2015-06-27 23:38 ` shuang.he
2015-06-28 18:59 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626173521.GF14226@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.