All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: Unconditionally do fb tracking invalidate in set_domain
Date: Mon, 29 Jun 2015 08:56:24 +0200	[thread overview]
Message-ID: <20150629065624.GQ30960@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGQ704wMC=z2oOdejJfQtryLFsvmEyPjTTp9zbR6CWQwLA@mail.gmail.com>

On Fri, Jun 26, 2015 at 05:02:49PM -0300, Paulo Zanoni wrote:
> 2015-06-26 14:35 GMT-03:00 Chris Wilson <chris@chris-wilson.co.uk>:
> > On Fri, Jun 26, 2015 at 07:35:16PM +0200, Daniel Vetter wrote:
> >> We can't elide the fb tracking invalidate if the buffer is already in
> >> the right domain since that would lead to missed screen updates. I'm
> >> pretty sure I've written this already before but must have gotten lost
> >> unfortunately :(
> >>
> >> v2: Chris observed that all internal set_domain users already
> >> correctly do the fb invalidate on their own, hence we can move this
> >> just into the set_domain ioctl instead.
> >>
> >> v3: I screwed up setting the invalidate ORIGIN_* correctly (Chris).
> >>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > -Chris
> 
> If you run:
> sudo ./kms_frontbuffer_tracking --psr-only --1p-only --use-small-modes
> 
> Without the patch, you get 9 failures:
> Subtest psr-1p-pri-sfb-multidraw-mmap-gtt: FAIL (10.979s)
> Subtest psr-1p-pri-sfb-multidraw-mmap-wc: FAIL (10.982s)
> Subtest psr-1p-pri-sfb-multidraw-pwrite: FAIL (9.448s)
> Subtest psr-1p-cur-sfb-multidraw-mmap-gtt: FAIL (11.208s)
> Subtest psr-1p-cur-sfb-multidraw-mmap-wc: FAIL (11.171s)
> Subtest psr-1p-cur-sfb-multidraw-pwrite: FAIL (8.966s)
> Subtest psr-1p-spr-sfb-multidraw-mmap-gtt: FAIL (11.536s)
> Subtest psr-1p-spr-sfb-multidraw-mmap-wc: FAIL (11.439s)
> Subtest psr-1p-spr-sfb-multidraw-pwrite: FAIL (10.043s)
> 
> With this patch, you get 0 failures \o/.
> 
> The "multidraw" subtest alternates between drawing types. So
> multidraw-mmap-gtt will alternate between mmap-gtt and mmap-cpu, then
> mmap-gtt and mmap-wc, then mmap-gtt and pwrite, then mmap-gtt and blt,
> then mmap-gtt and render.
> 
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Thanks for testing&review, patch applied to dinq.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-06-29  6:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 21:47 [PATCH 1/2] drm/i915: Unconditionally do fb tracking invalidate in set_domain Daniel Vetter
2015-06-25 21:47 ` [PATCH 2/2] drm/i915: Unique frontbuffer_bits for sprites Daniel Vetter
2015-06-29 11:32   ` shuang.he
2015-06-26  7:29 ` [PATCH 1/2] drm/i915: Unconditionally do fb tracking invalidate in set_domain Chris Wilson
2015-06-26  8:15 ` [PATCH] " Daniel Vetter
2015-06-26  9:52   ` Chris Wilson
2015-06-26 17:35   ` Daniel Vetter
2015-06-26 17:35     ` Chris Wilson
2015-06-26 20:02       ` Paulo Zanoni
2015-06-29  6:56         ` Daniel Vetter [this message]
2015-06-27 23:38     ` shuang.he
2015-06-28 18:59   ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629065624.GQ30960@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=przanoni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.