[PATCH v2] x86/Kconfig.debug: make X86_VERBOSE_BOOTUP depends on EARLY_PRINTK

[PATCH v2] x86/Kconfig.debug: make X86_VERBOSE_BOOTUP depends on EARLY_PRINTK

[Alexander Kuleshov]

The X86_VERBOSE_BOOTUP enables informational output during the
decompression stage with the earlyprintk. If CONFIG_EARLY_PRINTK
is not set, there are no reasons to make CONFIG_X86_VERBOSE_BOOTUP
possible for the configuration.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
Changes since v1:
 * style fixes;
---
arch/x86/Kconfig.debug | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index a15893d..71438bf 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -22,14 +22,6 @@ config STRICT_DEVMEM
 
 	  If in doubt, say Y.
 
-config X86_VERBOSE_BOOTUP
-	bool "Enable verbose x86 bootup info messages"
-	default y
-	---help---
-	  Enables the informational output from the decompression stage
-	  (e.g. bzImage) of the boot. If you disable this you will still
-	  see errors. Disable this if you want silent bootup.
-
 config EARLY_PRINTK
 	bool "Early printk" if EXPERT
 	default y
@@ -43,6 +35,15 @@ config EARLY_PRINTK
 	  with klogd/syslogd or the X server. You should normally N here,
 	  unless you want to debug such a crash.
 
+config X86_VERBOSE_BOOTUP
+	bool "Enable verbose x86 bootup info messages"
+	default y
+	depends on EARLY_PRINTK
+	---help---
+	  Enables the informational output from the decompression stage
+	  (e.g. bzImage) of the boot. If you disable this you will still
+	  see errors. Disable this if you want silent bootup.
+
 config EARLY_PRINTK_DBGP
 	bool "Early printk via EHCI debug port"
 	depends on EARLY_PRINTK && PCI
--
2.4.4.410.gc71d752

Re: [PATCH v2] x86/Kconfig.debug: make X86_VERBOSE_BOOTUP depends on EARLY_PRINTK

[Ingo Molnar]

* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> The X86_VERBOSE_BOOTUP enables informational output during the
> decompression stage with the earlyprintk. If CONFIG_EARLY_PRINTK
> is not set, there are no reasons to make CONFIG_X86_VERBOSE_BOOTUP
> possible for the configuration.

So exactly where does the code triggered by CONFIG_X86_VERBOSE_BOOTUP
depend on earlyprintk? I don't see the current kernel doing that anywhere.

Thanks,

	Ingo