From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Subject: Re: Re: [PATCH 2/3] ARM: dts: axp152: Add a dtsi file for the axp152 pmic Date: Mon, 6 Jul 2015 10:57:13 +0200 [thread overview] Message-ID: <20150706085713.GE3269@lukather> (raw) In-Reply-To: <558D0BC2.10004-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 1523 bytes --] Hi, On Fri, Jun 26, 2015 at 10:22:26AM +0200, Hans de Goede wrote: > Hi, > > On 25-06-15 19:40, Maxime Ripard wrote: > >Hi, > > > >On Tue, Jun 23, 2015 at 09:41:42PM +0200, Hans de Goede wrote: > >>From: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > >>Add a dtsi file for the axp152 pmic, this mirrors the way things are > >>handled for the axp202 pmic. > >> > >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > >>--- > >> arch/arm/boot/dts/axp152.dtsi | 49 +++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 49 insertions(+) > >> create mode 100644 arch/arm/boot/dts/axp152.dtsi > > > >Unfortunately, Mark expressed clearly that he didn't want such files. > > That is not how I remember the discussion, he said that he did not consider > them useful, we explained why we do consider them useful for the sunxi > case and then things went quiet. > > And we do already have an axp209.dtsi, and I find having that useful > for enabling the regulators on axp209 using boards. Hmmm, reading this discussion again, it indeed looks like I misremembered what he was saying. > Ultimately it is your call, but I really think we should be consistent > and add an axp152.dtsi to mirror how we do things with the axp209. Was there any other comments on this serie (and are you going to send a v2?) or should I apply this patch? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard) To: linux-arm-kernel@lists.infradead.org Subject: [linux-sunxi] Re: [PATCH 2/3] ARM: dts: axp152: Add a dtsi file for the axp152 pmic Date: Mon, 6 Jul 2015 10:57:13 +0200 [thread overview] Message-ID: <20150706085713.GE3269@lukather> (raw) In-Reply-To: <558D0BC2.10004@redhat.com> Hi, On Fri, Jun 26, 2015 at 10:22:26AM +0200, Hans de Goede wrote: > Hi, > > On 25-06-15 19:40, Maxime Ripard wrote: > >Hi, > > > >On Tue, Jun 23, 2015 at 09:41:42PM +0200, Hans de Goede wrote: > >>From: Michal Suchanek <hramrach@gmail.com> > >> > >>Add a dtsi file for the axp152 pmic, this mirrors the way things are > >>handled for the axp202 pmic. > >> > >>Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >>--- > >> arch/arm/boot/dts/axp152.dtsi | 49 +++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 49 insertions(+) > >> create mode 100644 arch/arm/boot/dts/axp152.dtsi > > > >Unfortunately, Mark expressed clearly that he didn't want such files. > > That is not how I remember the discussion, he said that he did not consider > them useful, we explained why we do consider them useful for the sunxi > case and then things went quiet. > > And we do already have an axp209.dtsi, and I find having that useful > for enabling the regulators on axp209 using boards. Hmmm, reading this discussion again, it indeed looks like I misremembered what he was saying. > Ultimately it is your call, but I really think we should be consistent > and add an axp152.dtsi to mirror how we do things with the axp209. Was there any other comments on this serie (and are you going to send a v2?) or should I apply this patch? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150706/92db4319/attachment.sig>
next prev parent reply other threads:[~2015-07-06 8:57 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-23 19:41 [PATCH 0/3] mfd: ax20x: Add axp152 support Hans de Goede 2015-06-23 19:41 ` Hans de Goede [not found] ` <1435088503-20776-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-23 19:41 ` [PATCH 1/3] " Hans de Goede 2015-06-23 19:41 ` Hans de Goede [not found] ` <1435088503-20776-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-24 12:21 ` Michal Suchanek 2015-06-24 12:21 ` Michal Suchanek 2015-06-25 10:11 ` Lee Jones 2015-06-25 10:11 ` Lee Jones 2015-06-23 19:41 ` [PATCH 2/3] ARM: dts: axp152: Add a dtsi file for the axp152 pmic Hans de Goede 2015-06-23 19:41 ` Hans de Goede [not found] ` <1435088503-20776-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-25 17:40 ` Maxime Ripard 2015-06-25 17:40 ` Maxime Ripard 2015-06-26 8:22 ` Hans de Goede 2015-06-26 8:22 ` [linux-sunxi] " Hans de Goede [not found] ` <558D0BC2.10004-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-07-06 8:57 ` Maxime Ripard [this message] 2015-07-06 8:57 ` Maxime Ripard 2015-07-06 12:12 ` Hans de Goede 2015-07-06 12:12 ` Hans de Goede [not found] ` <559A70B6.3010101-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-07-09 8:10 ` Maxime Ripard 2015-07-09 8:10 ` [linux-sunxi] " Maxime Ripard 2015-06-23 19:41 ` [PATCH 3/3] ARM: dts: A10s-OLinuxIno: Add a node for " Hans de Goede 2015-06-23 19:41 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150706085713.GE3269@lukather \ --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.