All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
	linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/asm/entry/64: Clean up entry_64.S
Date: Mon, 6 Jul 2015 18:43:30 +0200	[thread overview]
Message-ID: <20150706164330.GA24890@gmail.com> (raw)
In-Reply-To: <559AAE8F.1050408@oracle.com>


* Sasha Levin <sasha.levin@oracle.com> wrote:

> On 07/06/2015 12:23 PM, Ingo Molnar wrote:
> > 
> > * Sasha Levin <sasha.levin@oracle.com> wrote:
> > 
> >> On 07/06/2015 12:07 PM, Ingo Molnar wrote:
> >>>
> >>> * Sasha Levin <sasha.levin@oracle.com> wrote:
> >>>
> >>>> Hey Ingo,
> >>>>
> >>>> I've started seeing the fuzzer hitting the BUG() at arch/x86/kernel/nmi.c:533. git
> >>>> blame pointed to this patch. I know that you didn't see any changes in the compiled
> >>>> file in your testcase, but I do see changes in mine.
> >>>
> >>> Hm, weird - could you send me your .config please?
> >>
> >> Attached.
> > 
> > It's still weird: I copied your config to 4d7321381e5c and made 'make oldconfig' - 
> > and it asked a couple of questions, which suggests that your config does not come 
> > from 4d7321381e5c?
> 
> Right, sorry, this is my base config for -next. I just did 'yes "" | make oldconfig'
> for the build test.
> 
> I've attached it.
> 
> > Furthermore, building 4d7321381e5c and 4d7321381e5c^1 gives me:
> > 
> >   # arch/x86/entry/entry_64.o:
> > 
> >    text    data     bss     dec     hex filename
> >   11530       0       0   11530    2d0a entry_64.o.before
> >   11530       0       0   11530    2d0a entry_64.o.after
> > 
> > md5:
> >    1430e793250d5d8572bc2df2997d3929  entry_64.o.before.asm
> >    1430e793250d5d8572bc2df2997d3929  entry_64.o.after.asm
> > 
> > i.e. I have trouble reproducing the discrepancy you are seeing. (I also tried 
> > allmodconfig/allyesconfig again for good measure - no luck.)
> 
> With allyesconfig I don't actually see a change. Only with the config I've attached.

So I still cannot reproduce it even with your latest config:

  # arch/x86/entry/entry_64.o:

   text    data     bss     dec     hex filename
  11530       0       0   11530    2d0a entry_64.o.before
  11530       0       0   11530    2d0a entry_64.o.after

md5:
   1430e793250d5d8572bc2df2997d3929  entry_64.o.before.asm
   1430e793250d5d8572bc2df2997d3929  entry_64.o.after.asm

but I saw this during the build:

  scripts/Makefile.kasan:23: CONFIG_KASAN: compiler does not support all options. Trying minimal configuration

is your KASAN build more fully enabled, and does the problem reproduce with 
CONFIG_KASAN turned off?

Thanks,

	Ingo

  reply	other threads:[~2015-07-06 16:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08  8:34 [PATCH 0/4] x86: Untangle and standardize x86 system call entry point names Ingo Molnar
2015-06-08  8:34 ` [PATCH 1/4] x86/asm/entry: Rename compat syscall entry points Ingo Molnar
2015-06-08  8:47   ` Borislav Petkov
2015-06-08  8:34 ` [PATCH 2/4] x86/asm/entry: Untangle 'ia32_sysenter_target' into two entry points: entry_SYSENTER_32 and entry_SYSENTER_compat Ingo Molnar
2015-06-09  0:13   ` Andy Lutomirski
2015-06-09  9:33     ` Ingo Molnar
2015-06-09 16:33       ` Andy Lutomirski
2015-06-08  8:35 ` [PATCH 3/4] x86/asm/entry: Untangle 'system_call' into two entry points: entry_SYSCALL_64 and entry_INT80_32 Ingo Molnar
2015-06-08  8:35 ` [PATCH 4/4] x86/asm/entry/32: Clean up entry_32.S Ingo Molnar
2015-06-08 13:14   ` Denys Vlasenko
2015-06-08 18:51     ` [PATCH] x86/asm/entry/64: Clean up entry_64.S Ingo Molnar
2015-07-06 15:00       ` Sasha Levin
2015-07-06 16:07         ` Ingo Molnar
2015-07-06 16:19           ` Sasha Levin
2015-07-06 16:23             ` Ingo Molnar
2015-07-06 16:36               ` Sasha Levin
2015-07-06 16:43                 ` Ingo Molnar [this message]
2015-07-06 17:02                   ` Sasha Levin
2015-07-06 17:20         ` Andy Lutomirski
2015-07-06 17:34           ` Sasha Levin
2015-07-06 17:41             ` Ingo Molnar
2015-07-06 18:35               ` Andy Lutomirski
2015-07-06 18:39                 ` Andy Lutomirski
2015-07-08 15:39                   ` Sasha Levin
2015-07-07  7:01                 ` Ingo Molnar
2015-07-09  0:59         ` Andy Lutomirski
2015-07-10 13:27           ` Sasha Levin
2015-07-10 15:26           ` Andrey Ryabinin
2015-07-10 15:36             ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150706164330.GA24890@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sasha.levin@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.