From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>,
kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: imx1-core: Fix debug output pin array index
Date: Thu, 9 Jul 2015 20:06:52 +0200 [thread overview]
Message-ID: <20150709180652.GJ1426@pengutronix.de> (raw)
In-Reply-To: <20150709133036.GK7573@pengutronix.de>
Hi,
On Thu, Jul 09, 2015 at 03:30:36PM +0200, Markus Pargmann wrote:
> > b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > index 5ac59fb..8408bd8 100644
> > --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > @@ -403,14 +403,16 @@ static int imx1_pinconf_set(struct pinctrl_dev *pctldev,
> > unsigned num_configs)
> > {
> > struct imx1_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
> > - const struct imx1_pinctrl_soc_info *info = ipctl->info;
> > + struct pin_desc *desc;
> > int i;
> >
> > + desc = pin_desc_get(pctldev, pin_id);
>
> For the rest of this function pin_desc_get() is not necessary. This is
> not a simple function call but a radix tree lookup as far as I can see.
> I am not sure how important this debugging information is and how
> expensive this function call is?!
If it's moved into the call to pr_debug it should be optimized away when
debugging is off. That together with a merge of Chris' and mine commit
log and I'm happy.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K�nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: imx1-core: Fix debug output pin array index
Date: Thu, 9 Jul 2015 20:06:52 +0200 [thread overview]
Message-ID: <20150709180652.GJ1426@pengutronix.de> (raw)
In-Reply-To: <20150709133036.GK7573@pengutronix.de>
Hi,
On Thu, Jul 09, 2015 at 03:30:36PM +0200, Markus Pargmann wrote:
> > b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > index 5ac59fb..8408bd8 100644
> > --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > @@ -403,14 +403,16 @@ static int imx1_pinconf_set(struct pinctrl_dev *pctldev,
> > unsigned num_configs)
> > {
> > struct imx1_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
> > - const struct imx1_pinctrl_soc_info *info = ipctl->info;
> > + struct pin_desc *desc;
> > int i;
> >
> > + desc = pin_desc_get(pctldev, pin_id);
>
> For the rest of this function pin_desc_get() is not necessary. This is
> not a simple function call but a radix tree lookup as far as I can see.
> I am not sure how important this debugging information is and how
> expensive this function call is?!
If it's moved into the call to pr_debug it should be optimized away when
debugging is off. That together with a merge of Chris' and mine commit
log and I'm happy.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-07-09 18:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 14:16 [PATCH] pinctrl: imx1-core: Fix debug output pin array index Markus Pargmann
2015-07-08 14:16 ` Markus Pargmann
2015-07-09 7:12 ` Uwe Kleine-König
2015-07-09 7:12 ` Uwe Kleine-König
2015-07-09 8:28 ` Chris Ruehl
2015-07-09 8:28 ` Chris Ruehl
2015-07-09 13:30 ` Markus Pargmann
2015-07-09 13:30 ` Markus Pargmann
2015-07-09 18:06 ` Uwe Kleine-König [this message]
2015-07-09 18:06 ` Uwe Kleine-König
2015-07-10 10:02 ` Markus Pargmann
2015-07-10 10:02 ` Markus Pargmann
2015-07-10 1:24 ` Chris Ruehl
2015-07-10 1:24 ` Chris Ruehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709180652.GJ1426@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=chris.ruehl@gtsys.com.hk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.