All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 1/1] C6X/meagmod-pic: Consolidate chained IRQ handler install/remove
@ 2015-07-13 20:38 Thomas Gleixner
  2015-07-27 15:55 ` [tip:irq/core] " tip-bot for Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2015-07-13 20:38 UTC (permalink / raw)
  To: LKML
  Cc: Mark Salter, Aurelien Jacquiot, linux-c6x-dev, Russell King,
	Julia Lawall

[-- Attachment #1: C6X-meagmod-pic-Consolidate-chained-IRQ-handler-inst.patch --]
[-- Type: text/plain, Size: 1144 bytes --]

Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle.

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Mark Salter <msalter@redhat.com>
Cc: Aurelien Jacquiot <a-jacquiot@ti.com>
Cc: linux-c6x-dev@linux-c6x.org
---
 arch/c6x/platforms/megamod-pic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: tip/arch/c6x/platforms/megamod-pic.c
===================================================================
--- tip.orig/arch/c6x/platforms/megamod-pic.c
+++ tip/arch/c6x/platforms/megamod-pic.c
@@ -282,8 +282,8 @@ static struct megamod_pic * __init init_
 		soc_writel(~0, &pic->regs->evtmask[i]);
 		soc_writel(~0, &pic->regs->evtclr[i]);
 
-		irq_set_handler_data(irq, &cascade_data[i]);
-		irq_set_chained_handler(irq, megamod_irq_cascade);
+		irq_set_chained_handler_and_data(irq, megamod_irq_cascade,
+						 &cascade_data[i]);
 	}
 
 	/* Finally, set up the MUX registers */



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:irq/core] C6X/meagmod-pic: Consolidate chained IRQ handler install/remove
  2015-07-13 20:38 [patch 1/1] C6X/meagmod-pic: Consolidate chained IRQ handler install/remove Thomas Gleixner
@ 2015-07-27 15:55 ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Thomas Gleixner @ 2015-07-27 15:55 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: mingo, a-jacquiot, rmk+kernel, hpa, Julia.Lawall, msalter,
	linux-kernel, tglx

Commit-ID:  bdf76e36765970c64624d32150b656dc6669ddc2
Gitweb:     http://git.kernel.org/tip/bdf76e36765970c64624d32150b656dc6669ddc2
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Mon, 13 Jul 2015 20:38:38 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 27 Jul 2015 13:36:37 +0200

C6X/meagmod-pic: Consolidate chained IRQ handler install/remove

Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle.

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Mark Salter <msalter@redhat.com>
Cc: Aurelien Jacquiot <a-jacquiot@ti.com>
Cc: linux-c6x-dev@linux-c6x.org
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Link: http://lkml.kernel.org/r/20150713130429.697731509@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/c6x/platforms/megamod-pic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/c6x/platforms/megamod-pic.c b/arch/c6x/platforms/megamod-pic.c
index 74e3371..349bc01 100644
--- a/arch/c6x/platforms/megamod-pic.c
+++ b/arch/c6x/platforms/megamod-pic.c
@@ -282,8 +282,8 @@ static struct megamod_pic * __init init_megamod_pic(struct device_node *np)
 		soc_writel(~0, &pic->regs->evtmask[i]);
 		soc_writel(~0, &pic->regs->evtclr[i]);
 
-		irq_set_handler_data(irq, &cascade_data[i]);
-		irq_set_chained_handler(irq, megamod_irq_cascade);
+		irq_set_chained_handler_and_data(irq, megamod_irq_cascade,
+						 &cascade_data[i]);
 	}
 
 	/* Finally, set up the MUX registers */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-27 15:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-13 20:38 [patch 1/1] C6X/meagmod-pic: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-27 15:55 ` [tip:irq/core] " tip-bot for Thomas Gleixner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.