From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>, Christoph Lameter <cl@gentwo.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Steve Capper <steve.capper@linaro.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.cz>, Jerome Marchand <jmarchan@redhat.com>, Sasha Levin <sasha.levin@oracle.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: RE: [PATCH 13/36] mm: drop tail page refcounting Date: Tue, 14 Jul 2015 17:01:35 +0300 (EEST) [thread overview] Message-ID: <20150714140135.81C368B@black.fi.intel.com> (raw) In-Reply-To: <1436550130-112636-14-git-send-email-kirill.shutemov@linux.intel.com> Kirill A. Shutemov wrote: > Tail page refcounting is utterly complicated and painful to support. > > It uses ->_mapcount on tail pages to store how many times this page is > pinned. get_page() bumps ->_mapcount on tail page in addition to > ->_count on head. This information is required by split_huge_page() to > be able to distribute pins from head of compound page to tails during > the split. > > We will need ->_mapcount to account PTE mappings of subpages of the > compound page. We eliminate need in current meaning of ->_mapcount in > tail pages by forbidding split entirely if the page is pinned. > > The only user of tail page refcounting is THP which is marked BROKEN for > now. > > Let's drop all this mess. It makes get_page() and put_page() much > simpler. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Tested-by: Sasha Levin <sasha.levin@oracle.com> > Acked-by: Vlastimil Babka <vbabka@suse.cz> checkpatch fixlet: diff --git a/include/linux/mm.h b/include/linux/mm.h index 57fcb78a3cef..681997bccc52 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -493,7 +493,7 @@ static inline void init_page_count(struct page *page) atomic_set(&page->_count, 1); } -void __put_page(struct page* page); +void __put_page(struct page *page); static inline void put_page(struct page *page) {
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>, Christoph Lameter <cl@gentwo.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Steve Capper <steve.capper@linaro.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.cz>, Jerome Marchand <jmarchan@redhat.com>, Sasha Levin <sasha.levin@oracle.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: RE: [PATCH 13/36] mm: drop tail page refcounting Date: Tue, 14 Jul 2015 17:01:35 +0300 (EEST) [thread overview] Message-ID: <20150714140135.81C368B@black.fi.intel.com> (raw) In-Reply-To: <1436550130-112636-14-git-send-email-kirill.shutemov@linux.intel.com> Kirill A. Shutemov wrote: > Tail page refcounting is utterly complicated and painful to support. > > It uses ->_mapcount on tail pages to store how many times this page is > pinned. get_page() bumps ->_mapcount on tail page in addition to > ->_count on head. This information is required by split_huge_page() to > be able to distribute pins from head of compound page to tails during > the split. > > We will need ->_mapcount to account PTE mappings of subpages of the > compound page. We eliminate need in current meaning of ->_mapcount in > tail pages by forbidding split entirely if the page is pinned. > > The only user of tail page refcounting is THP which is marked BROKEN for > now. > > Let's drop all this mess. It makes get_page() and put_page() much > simpler. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Tested-by: Sasha Levin <sasha.levin@oracle.com> > Acked-by: Vlastimil Babka <vbabka@suse.cz> checkpatch fixlet: diff --git a/include/linux/mm.h b/include/linux/mm.h index 57fcb78a3cef..681997bccc52 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -493,7 +493,7 @@ static inline void init_page_count(struct page *page) atomic_set(&page->_count, 1); } -void __put_page(struct page* page); +void __put_page(struct page *page); static inline void put_page(struct page *page) { -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-14 14:01 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-10 17:41 [PATCH 00/36] THP refcounting redesign Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 01/36] mm, proc: adjust PSS calculation Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 02/36] rmap: add argument to charge compound page Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 03/36] memcg: adjust to support new THP refcounting Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-14 13:58 ` Kirill A. Shutemov 2015-07-14 13:58 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 04/36] mm, thp: adjust conditions when we can reuse the page on WP fault Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 05/36] mm: adjust FOLL_SPLIT for new refcounting Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 06/36] mm: handle PTE-mapped tail pages in gerneric fast gup implementaiton Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 07/36] thp, mlock: do not allow huge pages in mlocked area Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 08/36] khugepaged: ignore pmd tables with THP mapped with ptes Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 09/36] thp: rename split_huge_page_pmd() to split_huge_pmd() Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 10/36] mm, vmstats: new THP splitting event Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 11/36] mm: temporally mark THP broken Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 12/36] thp: drop all split_huge_page()-related code Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 13/36] mm: drop tail page refcounting Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-14 14:01 ` Kirill A. Shutemov [this message] 2015-07-14 14:01 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 14/36] futex, thp: remove special case for THP in get_futex_key Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 15/36] ksm: prepare to new THP semantics Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 16/36] mm, thp: remove compound_lock Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-14 14:02 ` Kirill A. Shutemov 2015-07-14 14:02 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 17/36] arm64, thp: remove infrastructure for handling splitting PMDs Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-15 15:23 ` Suzuki K. Poulose 2015-07-15 15:23 ` Suzuki K. Poulose 2015-07-10 17:41 ` [PATCH 18/36] arm, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 19/36] mips, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 20/36] powerpc, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-15 11:31 ` Aneesh Kumar K.V 2015-07-15 11:31 ` Aneesh Kumar K.V 2015-07-10 17:41 ` [PATCH 21/36] s390, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 22/36] sparc, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 23/36] tile, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 24/36] x86, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:41 ` [PATCH 25/36] mm, " Kirill A. Shutemov 2015-07-10 17:41 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 26/36] mm: rework mapcount accounting to enable 4k mapping of THPs Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-12 19:13 ` Kirill A. Shutemov 2015-07-12 19:13 ` Kirill A. Shutemov 2015-07-14 14:04 ` Kirill A. Shutemov 2015-07-14 14:04 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 27/36] mm: differentiate page_mapped() from page_mapcount() for compound pages Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 28/36] mm, numa: skip PTE-mapped THP on numa fault Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 29/36] thp: implement split_huge_pmd() Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 30/36] thp: add option to setup migration entiries during PMD split Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 31/36] thp, mm: split_huge_page(): caller need to lock page Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 32/36] thp: reintroduce split_huge_page() Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-14 14:04 ` Kirill A. Shutemov 2015-07-14 14:04 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 33/36] migrate_pages: try to split pages on qeueuing Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 34/36] thp: introduce deferred_split_huge_page() Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 35/36] mm: re-enable THP Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-10 17:42 ` [PATCH 36/36] thp: update documentation Kirill A. Shutemov 2015-07-10 17:42 ` Kirill A. Shutemov 2015-07-14 14:05 ` Kirill A. Shutemov 2015-07-14 14:05 ` Kirill A. Shutemov 2015-07-14 9:06 ` [PATCH 00/36] THP refcounting redesign Jerome Marchand 2015-07-14 15:29 ` Kirill A. Shutemov 2015-07-14 15:29 ` Kirill A. Shutemov 2015-07-15 11:30 ` Aneesh Kumar K.V 2015-07-15 11:30 ` Aneesh Kumar K.V
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150714140135.81C368B@black.fi.intel.com \ --to=kirill.shutemov@linux.intel.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.vnet.ibm.com \ --cc=cl@gentwo.org \ --cc=dave.hansen@intel.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=jmarchan@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=riel@redhat.com \ --cc=sasha.levin@oracle.com \ --cc=steve.capper@linaro.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.