* [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal
@ 2015-07-16 13:36 Paul Kocialkowski
2015-07-16 13:40 ` Tom Rini
2015-07-28 14:59 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Paul Kocialkowski @ 2015-07-16 13:36 UTC (permalink / raw)
To: u-boot
All am33xx device tree are using device-tree, so get_board_rev is never actually
called. Thus, we can get rid of it to make the code easier to maintain.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
arch/arm/cpu/armv7/am33xx/sys_info.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/arch/arm/cpu/armv7/am33xx/sys_info.c b/arch/arm/cpu/armv7/am33xx/sys_info.c
index 781d83f..52a6824 100644
--- a/arch/arm/cpu/armv7/am33xx/sys_info.c
+++ b/arch/arm/cpu/armv7/am33xx/sys_info.c
@@ -51,15 +51,6 @@ u32 get_cpu_type(void)
}
/**
- * get_board_rev() - setup to pass kernel board revision information
- * returns: 0 for the ATAG REVISION tag value.
- */
-u32 __weak get_board_rev(void)
-{
- return 0;
-}
-
-/**
* get_device_type(): tell if GP/HS/EMU/TST
*/
u32 get_device_type(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal
2015-07-16 13:36 [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal Paul Kocialkowski
@ 2015-07-16 13:40 ` Tom Rini
2015-07-26 16:31 ` Paul Kocialkowski
2015-07-28 14:59 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Tom Rini @ 2015-07-16 13:40 UTC (permalink / raw)
To: u-boot
On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote:
> All am33xx device tree are using device-tree, so get_board_rev is never actually
> called. Thus, we can get rid of it to make the code easier to maintain.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150716/bcf0fe26/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal
2015-07-16 13:40 ` Tom Rini
@ 2015-07-26 16:31 ` Paul Kocialkowski
0 siblings, 0 replies; 4+ messages in thread
From: Paul Kocialkowski @ 2015-07-26 16:31 UTC (permalink / raw)
To: u-boot
Le jeudi 16 juillet 2015 ? 09:40 -0400, Tom Rini a ?crit :
> On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote:
>
> > All am33xx device tree are using device-tree, so get_board_rev is never actually
> > called. Thus, we can get rid of it to make the code easier to maintain.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
What about merging this patch? It's been more than a week since we last
discussed it.
Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150726/b19c4d5b/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] am33xx: Unused get_board_rev function removal
2015-07-16 13:36 [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal Paul Kocialkowski
2015-07-16 13:40 ` Tom Rini
@ 2015-07-28 14:59 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2015-07-28 14:59 UTC (permalink / raw)
To: u-boot
On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote:
> All am33xx device tree are using device-tree, so get_board_rev is never actually
> called. Thus, we can get rid of it to make the code easier to maintain.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150728/e0a9c41f/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-28 14:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-16 13:36 [U-Boot] [PATCH] am33xx: Unused get_board_rev function removal Paul Kocialkowski
2015-07-16 13:40 ` Tom Rini
2015-07-26 16:31 ` Paul Kocialkowski
2015-07-28 14:59 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.