From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chris Zhong" <zyw@rock-chips.com>,
"Sascha Hauer" <kernel@pengutronix.de>
Subject: Re: [PATCH] regulator: rk808: make better use of the gpiod API
Date: Tue, 21 Jul 2015 12:04:15 +0100 [thread overview]
Message-ID: <20150721110415.GS11162@sirena.org.uk> (raw)
In-Reply-To: <CACRpkda5DrDx77514uBT+3-8svcRWQ9vONA6Dg39F5ZNPHz3rA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote:
> On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König
> > The gpiod functions include variants for managed gpiod resources. Use it
> > to simplify the remove function.
> > As the driver handles a device node without a specification of dvs gpios
> > just fine, additionally use the variant of gpiod_get exactly for this
> > use case. This makes error checking more strict.
> > As a third benefit this patch makes the driver use the flags parameter
> > of gpiod_get* which will not be optional any more after 4.2 and so
> > prevents a build failure when the respective gpiod commit is merged.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Mark, please apply this.
...and reverted since it doesn't build as it's adding a use of a new API
which doesn't actually exist in Linus' tree yet (hopefully it's in
-next). I need a tag to pull if I'm going to use this patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-21 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 3:29 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2015-07-21 6:59 ` [PATCH] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-21 9:56 ` Linus Walleij
2015-07-21 11:04 ` Mark Brown [this message]
2015-07-21 14:21 ` Uwe Kleine-König
2015-07-21 14:46 ` [PATCH 1/2] regulator: rk808: add #include for gpiod functions Uwe Kleine-König
2015-07-21 14:46 ` [PATCH v2 2/2] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-22 2:21 ` Krzysztof Kozlowski
2015-07-21 13:09 ` [PATCH] " Krzysztof Kozlowski
2015-07-21 14:35 ` Uwe Kleine-König
2015-07-21 14:41 ` Mark Brown
2015-07-21 15:08 ` [PATCH] base/platform: assert that dev_pm_domain callbacks are called unconditionally Uwe Kleine-König
2015-08-06 0:06 ` Greg Kroah-Hartman
2015-07-22 0:13 ` [PATCH] regulator: rk808: make better use of the gpiod API Krzysztof Kozlowski
2015-07-22 7:13 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721110415.GS11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.