From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Zhong <zyw@rock-chips.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] regulator: rk808: make better use of the gpiod API
Date: Tue, 21 Jul 2015 15:41:00 +0100 [thread overview]
Message-ID: <20150721144100.GU11162@sirena.org.uk> (raw)
In-Reply-To: <20150721143524.GD9981@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Tue, Jul 21, 2015 at 04:35:24PM +0200, Uwe Kleine-König wrote:
> On Tue, Jul 21, 2015 at 10:09:32PM +0900, Krzysztof Kozlowski wrote:
> > The function looks empty so it can be removed entirely.
> I assumed that not having a remove function makes the device not
> detachable. Not sure about that.
No, of course not - the remove function is completely optional.
> Looking at the code I found that not having a remove function can yield
> surprises, though. If your driver has a probe but no remove function the
> platform bus glue calls
> dev_pm_domain_attach(_dev, true);
> at probe time, but not
> dev_pm_domain_detach(_dev, true);
> at remove. I admit I don't know about that dev_pm_domain stuff, but it
> looks wrong to only have one but not the other. Greg?
That looks like a bug, yes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-21 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 3:29 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2015-07-21 6:59 ` [PATCH] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-21 9:56 ` Linus Walleij
2015-07-21 11:04 ` Mark Brown
2015-07-21 14:21 ` Uwe Kleine-König
2015-07-21 14:46 ` [PATCH 1/2] regulator: rk808: add #include for gpiod functions Uwe Kleine-König
2015-07-21 14:46 ` [PATCH v2 2/2] regulator: rk808: make better use of the gpiod API Uwe Kleine-König
2015-07-22 2:21 ` Krzysztof Kozlowski
2015-07-21 13:09 ` [PATCH] " Krzysztof Kozlowski
2015-07-21 14:35 ` Uwe Kleine-König
2015-07-21 14:41 ` Mark Brown [this message]
2015-07-21 15:08 ` [PATCH] base/platform: assert that dev_pm_domain callbacks are called unconditionally Uwe Kleine-König
2015-08-06 0:06 ` Greg Kroah-Hartman
2015-07-22 0:13 ` [PATCH] regulator: rk808: make better use of the gpiod API Krzysztof Kozlowski
2015-07-22 7:13 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721144100.GU11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.